Cherry pick PR 1012 into 0.22 release (#1109)

Precompile acceptance tests for eth_call with Mirror node (#1012)

* test: acceptance tests for eth_call with precompiles



* feat: add new CI



* remove workaround



* fix workflow



* test: add negative tests



* chore: fix unintended change



* fix: assertions for custom fees



* chore: bump mirror version and disable failing tests



* chore: bump mirror node version



* chore: fix failing tests



---------

Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Co-authored-by: Ivo Yankov <[email protected]>
Co-authored-by: georgi-l95 <[email protected]>

Author: 3 people

.github/workflows/acceptance.yml

@@ -56,6 +56,12 @@ jobs:
     with:
       testfilter: htsprecompilev1
 
+  precompilecalls:
+    name: Precompile
+    uses: ./.github/workflows/acceptance-workflow.yml
+    with:
+      testfilter: precompile
+
   websocket:
     name: Websocket
     uses: ./.github/workflows/acceptance-workflow.yml

package.json

@@ -32,6 +32,7 @@
         "acceptancetest:htsprecompilev1": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@htsprecompilev1' --exit",
         "acceptancetest:release": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@release' --exit",
         "acceptancetest:ws": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@web-socket' --exit",
+        "acceptancetest:precompile": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@precompile-calls' --exit",
         "build": "npx lerna run build",
         "build-and-test": "npx lerna run build && npx lerna run test",
         "build:docker": "docker build . -t ${npm_package_name}",

packages/relay/src/lib/eth.ts

@@ -1042,22 +1042,19 @@ export class EthImpl implements Eth {
       // ETH_CALL_DEFAULT_TO_CONSENSUS_NODE = false enables the use of Mirror node
       if (process.env.ETH_CALL_DEFAULT_TO_CONSENSUS_NODE == 'false') {
         //temporary workaround until precompiles are implemented in Mirror node evm module
-        const isHts = await this.mirrorNodeClient.resolveEntityType(call.to, requestId, [constants.TYPE_TOKEN]);
-        if (!(isHts?.type === constants.TYPE_TOKEN)) {
-          // Execute the call and get the response
-          this.logger.debug(`${requestIdPrefix} Making eth_call on contract ${call.to} with gas ${gas} and call data "${call.data}" from "${call.from}" using mirror-node.`, call.to, gas, call.data, call.from);
-          const callData = {
-            ...call,
-            gas,
-            value,
-            estimate: false
-          }
-          const contractCallResponse = await this.mirrorNodeClient.postContractCall(callData, requestId);
-          if (contractCallResponse && contractCallResponse.result) {
-            return EthImpl.prepend0x(contractCallResponse.result);
-          }
-          return EthImpl.emptyHex;
+        // Execute the call and get the response
+        this.logger.debug(`${requestIdPrefix} Making eth_call on contract ${call.to} with gas ${gas} and call data "${call.data}" from "${call.from}" using mirror-node.`, call.to, gas, call.data, call.from);
+        const callData = {
+          ...call,
+          gas,
+          value,
+          estimate: false
+        }
+        const contractCallResponse = await this.mirrorNodeClient.postContractCall(callData, requestId);
+        if (contractCallResponse && contractCallResponse.result) {
+          return EthImpl.prepend0x(contractCallResponse.result);
         }
+        return EthImpl.emptyHex;
       }
 
       return await this.callConsensusNode(call, gas, requestId);