feat: ci cd (#4630)

Signed-off-by: Mariusz Jasuwienas <[email protected]>

Author: jasuwienas

.github/workflows/acceptance.yml

@@ -38,6 +38,7 @@ jobs:
           - { name: 'Websocket Batch 3', testfilter: 'ws_batch3', test_ws_server: true }
           - { name: 'Cache Service', testfilter: 'cache-service' }
           - { name: 'Server Config', testfilter: 'serverconfig' }
+          - { name: 'JSON RPC semantics and response codes compliance', testfilter: 'json_rpc_compliance' }
     uses: ./.github/workflows/acceptance-workflow.yml
     with:
       testfilter: ${{ matrix.test.testfilter }}

package.json

@@ -67,6 +67,7 @@
     "acceptancetest:rpc_api_schema_conformity": "c8 ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@api-conformity' --exit",
     "acceptancetest:serverconfig": "c8 ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@server-config' --exit",
     "acceptancetest:send_raw_transaction_extension": "c8 ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@sendRawTransactionExtension' --exit",
+    "acceptancetest:json_rpc_compliance": "c8 ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@json-rpc-compliance' --exit",
     "acceptancetest:debug": "c8 ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@debug' --exit",
     "acceptancetest:xts": "c8 ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@xts' --exit",
     "build": "npx lerna run build",

packages/server/src/compliance.ts

@@ -27,9 +27,11 @@ export const INVALID_METHOD_RESPONSE_BODY = {
 };
 
 const makeSureBodyExistsAndCanBeChecked = (ctx: IResponseContext) => {
+  if (ctx.status === 404) return false;
+
   if (!ctx.body) {
     ctx.status = 400;
-    ctx.body = { ...FALLBACK_RESPONSE_BODY };
+    ctx.body = structuredClone(FALLBACK_RESPONSE_BODY);
     return false;
   }
 
@@ -40,7 +42,7 @@ const makeSureBodyExistsAndCanBeChecked = (ctx: IResponseContext) => {
 
   if (typeof ctx.body !== 'object') {
     ctx.status = 400;
-    ctx.body = { ...FALLBACK_RESPONSE_BODY };
+    ctx.body = structuredClone(FALLBACK_RESPONSE_BODY);
     return false;
   }
   if (!ctx.body.jsonrpc) ctx.body.jsonrpc = FALLBACK_RESPONSE_BODY.jsonrpc;
@@ -59,7 +61,7 @@ const makeSureBodyExistsAndCanBeChecked = (ctx: IResponseContext) => {
 export const jsonRpcComplianceLayer = (ctx: IResponseContext & ParameterizedContext) => {
   if (!makeSureBodyExistsAndCanBeChecked(ctx)) return;
   if (ctx.status === 400) {
-    if (!ctx.body.error?.code) ctx.body.error = FALLBACK_RESPONSE_BODY.error;
+    if (!ctx.body.error?.code) ctx.body.error = structuredClone(FALLBACK_RESPONSE_BODY.error);
     if (VALID_JSON_RPC_HTTP_REQUESTS_STATUS_CODE) ctx.status = 200;
   }
 };

packages/server/tests/acceptance/responseCodes.spec.ts renamed to packages/server/tests/acceptance/jsonRpcCompliance.ts

@@ -7,7 +7,7 @@ import { overrideEnvsInMochaDescribe } from '../../../relay/tests/helpers';
 import { RELAY_URL } from './data/conformity/utils/constants';
 import { JsonRpcResponse } from './data/conformity/utils/interfaces';
 
-describe('@json-rpc HTTP/JSON-RPC semantics acceptance tests', function () {
+describe('@json-rpc-compliance HTTP/JSON-RPC semantics acceptance tests', function () {
   this.timeout(60000);
 
   const baseURL = RELAY_URL;

packages/server/tests/integration/server.spec.ts

@@ -301,15 +301,17 @@ describe('RPC Server', function () {
     expect(res.data.result).to.be.equal('0xf956fddff3899ff3cf7ac1773fdbf443ffbfb625c1a673abdba8947251f81bae');
   });
 
-  it.skip('should execute "eth_getTransactionByHash with missing transaction"', async function () {
-    // Fixme, why it works locally, but not here??
-    const res = await testClient.post('/', {
-      id: '2',
-      jsonrpc: '2.0',
-      method: RelayCalls.ETH_ENDPOINTS.ETH_GET_TRANSACTION_BY_HASH,
-      params: ['0x4a563af33c4871b51a8b108aa2fe1dd5280a30dfb7237170ae5e5e7957eb6392'],
-    });
-    expect(res.data.result).to.be.null;
+  it('should execute "eth_getTransactionByHash with missing transaction"', async function () {
+    try {
+      await testClient.post('/', {
+        id: '2',
+        jsonrpc: '2.0',
+        method: RelayCalls.ETH_ENDPOINTS.ETH_GET_TRANSACTION_BY_HASH,
+        params: ['0x4a563af33c4871b51a8b108aa2fe1dd5280a30dfb7237170ae5e5e7957eb6392'],
+      });
+    } catch (error: any) {
+      expect(error.message).to.equal('Request failed with status code 404');
+    }
   });
 
   it('should execute "eth_getUncleByBlockHashAndIndex"', async function () {