feat: make revertReason consistent on eth_getTransactionReceipt (#2517)

* chore: edit formatter

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* chore: remove leftovers

Signed-off-by: nikolay <n.atanasow94@gmail.com>

---------

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Author: natanasow

packages/relay/src/formatters.ts

@@ -50,6 +50,14 @@ function hexToASCII(str: string): string {
   return ascii;
 }
 
+function ASCIIToHex(ascii: string): string {
+  const hex: string[] = [];
+  for (let n = 0; n < ascii.length; n++) {
+    hex.push(Number(ascii.charCodeAt(n)).toString(16));
+  }
+  return hex.join('');
+}
+
 /**
  * Converts an EVM ErrorMessage to a readable form. For example this :
  * 0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000d53657420746f2072657665727400000000000000000000000000000000000000
@@ -289,4 +297,5 @@ export {
   toHexString,
   isValidEthereumAddress,
   isHex,
+  ASCIIToHex,
 };

packages/relay/src/lib/eth.ts

@@ -39,6 +39,8 @@ import {
   toHash32,
   weibarHexToTinyBarInt,
   trimPrecedingZeros,
+  ASCIIToHex,
+  isHex,
 } from '../formatters';
 import crypto from 'crypto';
 import HAPIService from './services/hapiService/hapiService';
@@ -2003,7 +2005,9 @@ export class EthImpl implements Eth {
       };
 
       if (receiptResponse.error_message) {
-        receipt.revertReason = receiptResponse.error_message;
+        receipt.revertReason = isHex(prepend0x(receiptResponse.error_message))
+          ? receiptResponse.error_message
+          : prepend0x(ASCIIToHex(receiptResponse.error_message));
       }
 
       this.logger.trace(`${requestIdPrefix} receipt for ${hash} found in block ${receipt.blockNumber}`);

packages/relay/tests/lib/formatters.spec.ts

@@ -37,6 +37,7 @@ import {
   isValidEthereumAddress,
   trimPrecedingZeros,
   isHex,
+  ASCIIToHex,
 } from '../../src/formatters';
 import constants from '../../src/lib/constants';
 import { BigNumber as BN } from 'bignumber.js';
@@ -465,4 +466,26 @@ describe('Formatters', () => {
       expect(isHex('0x58')).to.be.true;
     });
   });
+  describe('ASCIIToHex Function', () => {
+    const inputs = ['Lorem Ipsum', 'Foo', 'Bar'];
+    const outputs = ['4c6f72656d20497073756d', '466f6f', '426172'];
+
+    it('should return "" for empty string', () => {
+      expect(ASCIIToHex('')).to.equal('');
+    });
+
+    it('should return valid hex', () => {
+      expect(isHex(prepend0x(ASCIIToHex(inputs[0])))).to.be.true;
+    });
+
+    it('should return expected hex formatted value', () => {
+      expect(inputs[0]).to.equal(hexToASCII(ASCIIToHex(inputs[0])));
+    });
+
+    it('should decode correctly regarding hardcoded mapping', () => {
+      for (let i = 0; i < inputs.length; i++) {
+        expect(ASCIIToHex(inputs[i])).to.eq(outputs[i]);
+      }
+    });
+  });
 });