-
Notifications
You must be signed in to change notification settings - Fork 98
Description
Problem
Our conformity tests are not being able to capture all the new updated to the Ethereum Json RPC Spec, and neither distinguish what changes are related to methods that we will no impllement as they are not Hiero compatible or which ones are updates that perhaps we have a customization, we need to be aware of.
Detected Details
- We are pinning to a given commit, which makes our foto static
- We do have a unique skip list
Solution
(*) Point to the latest commit possible
- Check differences, and identify actions needed to be 1to1 in sync. Could be new User stories to add any new changes needed.
(*) Create several skip lists.
-
NON_SUPPORTED_ SKIP_LIST = methods that we will not support. Skip always
-
OVERRIDEN_SKIP_LIST = methods that we do support , but we hardcore/adjust behavior. Any new change should be marked as a comment
-
NOT_YET_SUPPORTED_ SKIP_LIST = methods that we will support, but we do not yet, due prioritization. skip always
-
FORK_NOT_YET_SUPPORTED_ SKIP_LIST = methods that we will support, but we do not yet, due fork is not yet supported. skip always
(*) Change GitHub action to start once a week
- Remove current on main merge behavior to a cronjob based action, that executed every friday, and opens PR on change detection
(*) Add a Support Role action to check every week the Github action execution
- Add as section for conforimity tests, to review weekly the action execution and possible PR
- Review weekly if we need to change the pinned commit