-
Notifications
You must be signed in to change notification settings - Fork 71
[Good First Issue]: Remove unused hasLabel import in unassign.js #1255
Description
🆕🐥 First-Time Friendly
This issue is especially welcoming for people who are new to contributing to the Hiero C++ SDK.
We know that opening your first pull request can feel like a big step.
Issues labeled Good First Issue are designed to make that experience easier, clearer, and more comfortable.
No prior knowledge of Hiero, Hedera, or distributed ledger technology is required.
Just a basic familiarity with JavaScript and Git is more than enough to get started.
Important
📋 About Good First Issues
Good First Issues are designed to make getting started as smooth and stress-free as possible.
They usually focus on:
- Small, clearly scoped changes
- Straightforward updates to existing code or docs
- Simple refactors or clarity improvements
👾 Description of the Issue
The file:
.github/scripts/commands/unassign.js
imports hasLabel from the helpers module at line 13, but hasLabel is never used anywhere in the file.
Unused imports add noise to the code and can confuse contributors reading the file for the first time, as they may wonder where hasLabel is called. Removing it keeps the import list clean and accurate.
💡 Proposed Solution
Remove the hasLabel identifier from the destructured import at the top of .github/scripts/commands/unassign.js.
The change should:
- Remove only the unused
hasLabelimport - Not modify any existing logic or behavior
- Leave all other imports and code untouched
👩💻 Implementation Steps (End-to-End)
To complete this change:
- Open
.github/scripts/commands/unassign.js - Locate the import statement near line 13 that includes
hasLabel - Remove
hasLabelfrom the destructured import list- If
hasLabelis the only item being removed, adjust any trailing commas accordingly - If removing
hasLabelleaves the import empty, remove the entire import line
- If
- Verify the file still runs correctly — no logic changes should be needed
- Open a pull request with the change
Example of what to look for:
// Before (example — check the actual file for exact syntax)
const { someHelper, hasLabel, anotherHelper } = require('../helpers/api');
// After
const { someHelper, anotherHelper } = require('../helpers/api');✅ Acceptance Criteria
To merge a pull request for this issue:
- Scope: Changes are limited to removing the unused
hasLabelimport - Behavior: No logic or bot behavior changes
- Tests: Existing CI checks pass
- Review: All code review feedback addressed
📋 Step-by-Step Contribution Guide
To help your first contribution go as smoothly as possible, we recommend following these steps:
- Comment
/assignto request the issue - Wait for assignment
- Fork the repository and create a branch
- Set up the project by following the instructions in
README.md - Make the requested changes
- Sign each commit using
-s -S - Push your branch and open a pull request
Read Workflow Guide for step-by-step workflow guidance.
Read README.md for setup instructions.
❗ Pull requests cannot be merged without S and s signed commits.
See the Signing Guide.
🤔 Additional Information
If you need help, reach out to the @hiero-ledger/hiero-sdk-good-first-issue-support team.
You can also join our community on Discord:
Hiero-SDK-C++
Maintainers are happy to help first-time contributors succeed!
Identified in PR #1246 — .github/scripts/commands/unassign.js line 13.