Fix advanced check email spam on non-advanced issues

Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>

Author: gangulysiddhartha22-cmyk

.github/workflows/bot-advanced-check.yml

@@ -1,9 +1,7 @@
 name: PythonBot - Advanced Requirement Check
-
 on:
   issues:
     types: [assigned, labeled]
-
   workflow_dispatch:
     inputs:
       dry_run:
@@ -15,56 +13,49 @@ on:
         description: "GitHub username to dry-run qualification check"
         required: true
         type: string
-
 permissions:
-  contents: read   # required for actions/checkout
+  contents: read
   issues: write
-
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.issue.number || github.run_id }}
   cancel-in-progress: true
-
 jobs:
   #######################################
   # Automatic enforcement + manual dry-run
   #######################################
   check-advanced-qualification:
-    if: >
+    # Skip the entire job (no run steps, no checkout, minimal visibility) when not relevant
+    if: ${{ 
+      github.event_name == 'workflow_dispatch' || 
       (
-        github.event_name == 'issues' &&
-        contains(github.event.issue.labels.*.name, 'advanced') &&
+        contains(github.event.issue.labels.*.name, 'advanced') && 
         (
-          github.event.action == 'assigned' ||
+          github.event.action == 'assigned' || 
           (
-            github.event.action == 'labeled' &&
-            github.event.label.name == 'advanced' &&
-            github.event.issue.assignees[0] != null
+            github.event.action == 'labeled' && 
+            github.event.label.name == 'advanced' && 
+            join(github.event.issue.assignees.*.login, ',') != ''
           )
         )
-      ) ||
-      github.event_name == 'workflow_dispatch'
-
+      )
+    }}
     runs-on: ubuntu-latest
-
     steps:
       - name: Checkout scripts
-        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af1b8 # v4 (latest stable)
         with:
-          sparse-checkout: .github/scripts
+          sparse-checkout: |
+            .github/scripts
+          sparse-checkout-cone-mode: false
 
       - name: Verify User Qualification
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           REPO: ${{ github.repository }}
-
-          # Issue-driven execution
           TRIGGER_ASSIGNEE: ${{ github.event.assignee.login || '' }}
           ISSUE_NUMBER: ${{ github.event.issue.number || '' }}
-
-          # Manual execution (workflow_dispatch)
           DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && inputs.dry_run || 'false' }}
           DRY_RUN_USER: ${{ github.event_name == 'workflow_dispatch' && inputs.username || '' }}
-
         run: |
           chmod +x .github/scripts/bot-advanced-check.sh
-          ./.github/scripts/bot-advanced-check.sh
+          .github/scripts/bot-advanced-check.sh

CHANGELOG.md

@@ -200,6 +200,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Update changelog workflow to trigger automatically on pull requests instead of manual dispatch (#1567)
 
 ### Fixed
+- Reduced notification spam by skipping the entire advanced qualification job for non-advanced issues and irrelevant events (#1517)
 - Aligned token freeze example filename references and improved error handling by catching broader exceptions with clearer messages. (#1412)
 - Fixed jq syntax in bot-office-hours.sh (#1502)
 - Prevented linkbot from commenting on or auto-closing bot-authored pull requests. (#1516)