fix: account pylint issues (#397)

* style: add type hints, format code and fix pylint issues in account_create_transaction.py

Signed-off-by: dosi <[email protected]>

* style: format account_balance.py and fix pylint issues

Signed-off-by: dosi <[email protected]>

* style: format account_delete_transaction.py and fix pylint issues

Signed-off-by: dosi <[email protected]>

* style: format account_id.py and fix pylint issues

Signed-off-by: dosi <[email protected]>

* style: format account_info.py and fix pylint issues

Signed-off-by: dosi <[email protected]>

* style: format account_update_transaction.py and fix pylint issues

Signed-off-by: dosi <[email protected]>

* chore: update CHANGELOG

Signed-off-by: dosi <[email protected]>

---------

Signed-off-by: dosi <[email protected]>

Author: Dosik13

CHANGELOG.md

@@ -58,6 +58,12 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Add CI tests across Python 3.10–3.12.
 
 ### Fixed
+- Format account_create_transaction.py and add type hints
+- Format account_balance.py and fix pylint issues
+- Format account_delete_transaction.py and fix pylint issues
+- Format account_id.py and fix pylint issues
+- Format account_info.py and fix pylint issues
+- Format account_update_transaction.py and fix pylint issues
 - Unit test compatibility issues when running with UV package manager
 - Type annotations in TokenRelationship class (kyc_status and freeze_status)
 - Test assertions in test_executable.py using pytest match parameter

src/hiero_sdk_python/account/account_balance.py

@@ -1,8 +1,15 @@
+"""
+AccountBalance class.
+"""
+
 from typing import Dict
 
-from hiero_sdk_python.tokens.token_id import TokenId
+from hiero_sdk_python.hapi.services.crypto_get_account_balance_pb2 import (
+    CryptoGetAccountBalanceResponse,
+)
 from hiero_sdk_python.hbar import Hbar
-from hiero_sdk_python.hapi.services.crypto_get_account_balance_pb2 import CryptoGetAccountBalanceResponse
+from hiero_sdk_python.tokens.token_id import TokenId
+
 
 class AccountBalance:
     """
@@ -13,7 +20,7 @@ class AccountBalance:
         token_balances (dict): A dictionary mapping TokenId to token balances.
     """
 
-    def __init__(self, hbars: Hbar, token_balances: Dict[TokenId,int] = None) -> None:
+    def __init__(self, hbars: Hbar, token_balances: Dict[TokenId, int] = None) -> None:
         """
         Initializes the AccountBalance with the given hbar balance and token balances.
 
@@ -25,7 +32,6 @@ def __init__(self, hbars: Hbar, token_balances: Dict[TokenId,int] = None) -> Non
         self.token_balances = token_balances or {}
 
     @classmethod
-
     def _from_proto(cls, proto: CryptoGetAccountBalanceResponse) -> "AccountBalance":
         """
         Creates an AccountBalance instance from a protobuf response.
@@ -38,7 +44,7 @@ def _from_proto(cls, proto: CryptoGetAccountBalanceResponse) -> "AccountBalance"
         """
         hbars: Hbar = Hbar.from_tinybars(tinybars=proto.balance)
 
-        token_balances: Dict[TokenId,int] = {}
+        token_balances: Dict[TokenId, int] = {}
         if proto.tokenBalances:
             for token_balance in proto.tokenBalances:
                 token_id: TokenId = TokenId._from_proto(token_balance.tokenId)

src/hiero_sdk_python/account/account_create_transaction.py

@@ -1,4 +1,8 @@
-from typing import Union
+"""
+AccountCreateTransaction class.
+"""
+
+from typing import Optional, Union
 
 from hiero_sdk_python.channels import _Channel
 from hiero_sdk_python.crypto.public_key import PublicKey
@@ -11,6 +15,9 @@
 from hiero_sdk_python.hbar import Hbar
 from hiero_sdk_python.transaction.transaction import Transaction
 
+AUTO_RENEW_PERIOD = Duration(7890000)  # around 90 days in seconds
+DEFAULT_TRANSACTION_FEE = Hbar(3).to_tinybars()  # 3 Hbars
+
 
 class AccountCreateTransaction(Transaction):
     """
@@ -19,29 +26,30 @@ class AccountCreateTransaction(Transaction):
 
     def __init__(
         self,
-        key: PublicKey = None,
+        key: Optional[PublicKey] = None,
         initial_balance: Union[Hbar, int] = 0,
-        receiver_signature_required: bool = False,
-        auto_renew_period: Duration = Duration(7890000),  # 90 days in seconds
-        memo: str = ""
-     ) -> None:
+        receiver_signature_required: Optional[bool] = None,
+        auto_renew_period: Optional[Duration] = AUTO_RENEW_PERIOD,
+        memo: Optional[str] = None,
+    ) -> None:
         """
-        Initializes a new AccountCreateTransaction instance with default values or specified keyword arguments.
+        Initializes a new AccountCreateTransaction instance with default values
+        or specified keyword arguments.
 
-        Args:
-            key (PublicKey, optional): The public key for the new account.
-            initial_balance (Hbar or int, optional): Initial balance in Hbar or tinybars.
-            receiver_signature_required (bool, optional): Whether receiver signature is required.
-            auto_renew_period (int, optional): Auto-renew period in seconds (default is ~90 days).
-            memo (str, optional): Memo for the account.
+        Attributes:
+            key (Optional[PublicKey]): The public key for the new account.
+            initial_balance (Union[Hbar, int]): Initial balance in Hbar or tinybars.
+            receiver_signature_required (Optional[bool]): Whether receiver signature is required.
+            auto_renew_period (Duration): Auto-renew period in seconds (default is ~90 days).
+            memo (Optional[str]): Memo for the account.
         """
         super().__init__()
-        self.key = key
-        self.initial_balance = initial_balance
-        self.receiver_signature_required = receiver_signature_required
-        self.auto_renew_period = auto_renew_period
-        self.account_memo = memo
-        self._default_transaction_fee = 300_000_000
+        self.key: Optional[PublicKey] = key
+        self.initial_balance: Union[Hbar, int] = initial_balance
+        self.receiver_signature_required: Optional[bool] = receiver_signature_required
+        self.auto_renew_period: Optional[Duration] = auto_renew_period
+        self.account_memo: Optional[str] = memo
+        self._default_transaction_fee = DEFAULT_TRANSACTION_FEE
 
     def set_key(self, key: PublicKey) -> "AccountCreateTransaction":
         """
@@ -89,7 +97,7 @@ def set_receiver_signature_required(self, required: bool) -> "AccountCreateTrans
         self.receiver_signature_required = required
         return self
 
-    def set_auto_renew_period(self, seconds: Union[int,Duration]) -> "AccountCreateTransaction":
+    def set_auto_renew_period(self, seconds: Union[int, Duration]) -> "AccountCreateTransaction":
         """
         Sets the auto-renew period in seconds.
 
@@ -148,7 +156,7 @@ def _build_proto_body(self):
             initialBalance=initial_balance_tinybars,
             receiverSigRequired=self.receiver_signature_required,
             autoRenewPeriod=duration_pb2.Duration(seconds=self.auto_renew_period.seconds),
-            memo=self.account_memo
+            memo=self.account_memo,
         )
 
     def build_transaction_body(self) -> transaction_pb2.TransactionBody:
@@ -183,7 +191,4 @@ def _get_method(self, channel: _Channel) -> _Method:
         Returns:
             _Method: An instance of _Method containing the transaction and query functions.
         """
-        return _Method(
-            transaction_func=channel.crypto.createAccount,
-            query_func=None
-        )
+        return _Method(transaction_func=channel.crypto.createAccount, query_func=None)

src/hiero_sdk_python/account/account_delete_transaction.py

@@ -47,9 +47,7 @@ def __init__(
         self.transfer_account_id: Optional[AccountId] = transfer_account_id
         self._default_transaction_fee = DEFAULT_TRANSACTION_FEE
 
-    def set_account_id(
-        self, account_id: Optional[AccountId]
-    ) -> "AccountDeleteTransaction":
+    def set_account_id(self, account_id: Optional[AccountId]) -> "AccountDeleteTransaction":
         """
         Sets the ID of the account to delete.
 
@@ -102,9 +100,7 @@ def _build_proto_body(self):
         return CryptoDeleteTransactionBody(
             deleteAccountID=self.account_id._to_proto(),
             transferAccountID=(
-                self.transfer_account_id._to_proto()
-                if self.transfer_account_id
-                else None
+                self.transfer_account_id._to_proto() if self.transfer_account_id else None
             ),
         )
 

src/hiero_sdk_python/account/account_id.py

@@ -1,10 +1,27 @@
+"""
+AccountId class.
+"""
+
 from typing import List
 
 from hiero_sdk_python.crypto.public_key import PublicKey
 from hiero_sdk_python.hapi.services import basic_types_pb2
 
 
 class AccountId:
+    """
+    Represents an account ID on the network.
+
+    An account ID consists of three components: shard, realm, and num.
+    These components uniquely identify an account in the network.
+
+    The standard format is `<shardNum>.<realmNum>.<accountNum>`, e.g., `0.0.10`.
+
+    In addition to the account number, the account component can also be an alias:
+    - An alias can be either a public key (ED25519 or ECDSA)
+    - The alias format is `<shardNum>.<realmNum>.<alias>`, where `alias` is the public key
+    """
+
     def __init__(
         self, shard: int = 0, realm: int = 0, num: int = 0, alias_key: PublicKey = None
     ) -> None:
@@ -28,9 +45,7 @@ def from_string(cls, account_id_str: str) -> "AccountId":
         """
         parts: List[str] = account_id_str.strip().split(".")
         if len(parts) != 3:
-            raise ValueError(
-                "Invalid account ID string format. Expected 'shard.realm.num'"
-            )
+            raise ValueError("Invalid account ID string format. Expected 'shard.realm.num'")
         shard, realm, num = map(int, parts)
         return cls(shard, realm, num)
 
@@ -51,7 +66,7 @@ def _from_proto(cls, account_id_proto: basic_types_pb2.AccountID) -> "AccountId"
             num=account_id_proto.accountNum,
         )
         if account_id_proto.alias:
-            alias = account_id_proto.alias[2:] # remove 0x prefix
+            alias = account_id_proto.alias[2:]  # remove 0x prefix
             result.alias_key = PublicKey.from_bytes(alias)
         return result
 

src/hiero_sdk_python/account/account_info.py

@@ -1,12 +1,19 @@
+# pylint: disable=too-many-instance-attributes
+"""
+AccountInfo class.
+"""
+
 from dataclasses import dataclass, field
 from typing import Optional
-from hiero_sdk_python.Duration import Duration
+
 from hiero_sdk_python.account.account_id import AccountId
 from hiero_sdk_python.crypto.public_key import PublicKey
+from hiero_sdk_python.Duration import Duration
+from hiero_sdk_python.hapi.services.crypto_get_info_pb2 import CryptoGetInfoResponse
 from hiero_sdk_python.hbar import Hbar
 from hiero_sdk_python.timestamp import Timestamp
 from hiero_sdk_python.tokens.token_relationship import TokenRelationship
-from hiero_sdk_python.hapi.services.crypto_get_info_pb2 import CryptoGetInfoResponse
+
 
 @dataclass
 class AccountInfo:
@@ -20,28 +27,33 @@ class AccountInfo:
         proxy_received (Optional[Hbar]): The total number of tinybars proxy staked to this account.
         key (Optional[PublicKey]): The key for this account.
         balance (Optional[Hbar]): The current balance of account in hbar.
-        receiver_signature_required (Optional[bool]): If true, this account's key must sign any transaction depositing into this account.
-        expiration_time (Optional[Timestamp]): The timestamp at which this account is set to expire.
-        auto_renew_period (Optional[Duration]): The duration for which this account will automatically renew.
-        token_relationships (list[TokenRelationship]): List of token relationships associated with this account.
+        receiver_signature_required (Optional[bool]): If true, this account's key must sign
+            any transaction depositing into this account.
+        expiration_time (Optional[Timestamp]): The timestamp at which this account
+            is set to expire.
+        auto_renew_period (Optional[Duration]): The duration for which this account
+            will automatically renew.
+        token_relationships (list[TokenRelationship]): List of token relationships
+            associated with this account.
         account_memo (Optional[str]): The memo associated with this account.
         owned_nfts (Optional[int]): The number of NFTs owned by this account.
     """
-    account_id : Optional[AccountId] = None
-    contract_account_id : Optional[str] = None
-    is_deleted : Optional[bool] = None
-    proxy_received : Optional[Hbar] = None
-    key : Optional[PublicKey] = None
-    balance : Optional[Hbar] = None
-    receiver_signature_required : Optional[bool] = None
-    expiration_time : Optional[Timestamp] = None
-    auto_renew_period : Optional[Duration] = None
-    token_relationships : list[TokenRelationship] = field(default_factory=list)
-    account_memo : Optional[str] = None
-    owned_nfts : Optional[int] = None
-    
+
+    account_id: Optional[AccountId] = None
+    contract_account_id: Optional[str] = None
+    is_deleted: Optional[bool] = None
+    proxy_received: Optional[Hbar] = None
+    key: Optional[PublicKey] = None
+    balance: Optional[Hbar] = None
+    receiver_signature_required: Optional[bool] = None
+    expiration_time: Optional[Timestamp] = None
+    auto_renew_period: Optional[Duration] = None
+    token_relationships: list[TokenRelationship] = field(default_factory=list)
+    account_memo: Optional[str] = None
+    owned_nfts: Optional[int] = None
+
     @classmethod
-    def _from_proto(cls, proto: CryptoGetInfoResponse.AccountInfo) -> 'AccountInfo':
+    def _from_proto(cls, proto: CryptoGetInfoResponse.AccountInfo) -> "AccountInfo":
         if proto is None:
             raise ValueError("Account info proto is None")
 
@@ -53,13 +65,20 @@ def _from_proto(cls, proto: CryptoGetInfoResponse.AccountInfo) -> 'AccountInfo':
             key=PublicKey._from_proto(proto.key) if proto.key else None,
             balance=Hbar.from_tinybars(proto.balance),
             receiver_signature_required=proto.receiverSigRequired,
-            expiration_time=Timestamp._from_protobuf(proto.expirationTime) if proto.expirationTime else None,
-            auto_renew_period=Duration._from_proto(proto.autoRenewPeriod) if proto.autoRenewPeriod else None,
-            token_relationships=[TokenRelationship._from_proto(relationship) for relationship in proto.tokenRelationships],
+            expiration_time=(
+                Timestamp._from_protobuf(proto.expirationTime) if proto.expirationTime else None
+            ),
+            auto_renew_period=(
+                Duration._from_proto(proto.autoRenewPeriod) if proto.autoRenewPeriod else None
+            ),
+            token_relationships=[
+                TokenRelationship._from_proto(relationship)
+                for relationship in proto.tokenRelationships
+            ],
             account_memo=proto.memo,
-            owned_nfts=proto.ownedNfts
+            owned_nfts=proto.ownedNfts,
         )
-        
+
     def _to_proto(self) -> CryptoGetInfoResponse.AccountInfo:
         return CryptoGetInfoResponse.AccountInfo(
             accountID=self.account_id._to_proto() if self.account_id else None,
@@ -71,7 +90,9 @@ def _to_proto(self) -> CryptoGetInfoResponse.AccountInfo:
             receiverSigRequired=self.receiver_signature_required,
             expirationTime=self.expiration_time._to_protobuf() if self.expiration_time else None,
             autoRenewPeriod=self.auto_renew_period._to_proto() if self.auto_renew_period else None,
-            tokenRelationships=[relationship._to_proto() for relationship in self.token_relationships],
+            tokenRelationships=[
+                relationship._to_proto() for relationship in self.token_relationships
+            ],
             memo=self.account_memo,
-            ownedNfts=self.owned_nfts
-        )
+            ownedNfts=self.owned_nfts,
+        )

src/hiero_sdk_python/account/account_update_transaction.py

@@ -71,9 +71,7 @@ def __init__(self, account_params: Optional[AccountUpdateParams] = None):
         self.receiver_signature_required = params.receiver_signature_required
         self.expiration_time = params.expiration_time
 
-    def set_account_id(
-        self, account_id: Optional[AccountId]
-    ) -> "AccountUpdateTransaction":
+    def set_account_id(self, account_id: Optional[AccountId]) -> "AccountUpdateTransaction":
         """
         Sets the `AccountId` that will be updated.
 
@@ -117,9 +115,7 @@ def set_auto_renew_period(
         self.auto_renew_period = auto_renew_period
         return self
 
-    def set_account_memo(
-        self, account_memo: Optional[str]
-    ) -> "AccountUpdateTransaction":
+    def set_account_memo(self, account_memo: Optional[str]) -> "AccountUpdateTransaction":
         """
         Sets the account memo (UTF-8, network enforced size limits apply).
 
@@ -181,17 +177,11 @@ def _build_proto_body(self):
         return CryptoUpdateTransactionBody(
             accountIDToUpdate=self.account_id._to_proto(),
             key=self.key._to_proto() if self.key else None,
-            memo=(
-                StringValue(value=self.account_memo)
-                if self.account_memo is not None
-                else None
-            ),
+            memo=StringValue(value=self.account_memo) if self.account_memo is not None else None,
             autoRenewPeriod=(
                 self.auto_renew_period._to_proto() if self.auto_renew_period else None
             ),
-            expirationTime=(
-                self.expiration_time._to_protobuf() if self.expiration_time else None
-            ),
+            expirationTime=self.expiration_time._to_protobuf() if self.expiration_time else None,
             receiverSigRequiredWrapper=(
                 BoolValue(value=self.receiver_signature_required)
                 if self.receiver_signature_required is not None