Skip to content

Commit 1ef0e9c

Browse files
committed
fix: Restore CHANGELOG and optimize script
Signed-off-by: prajeeta pal <prajeetapal@gmail.com>
1 parent ea074d6 commit 1ef0e9c

File tree

4 files changed

+26
-8
lines changed

4 files changed

+26
-8
lines changed

.github/scripts/issue_reminder_no_pr.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,21 +44,21 @@ parse_ts() {
4444
}
4545

4646
# Fetch open ISSUES (not PRs) that have assignees
47-
ISSUES=$(gh api "repos/$REPO/issues" \
47+
ALL_ISSUES_JSON=$(gh api "repos/$REPO/issues" \
4848
--paginate \
49-
--jq '.[] | select(.state=="open" and (.assignees | length > 0) and (.pull_request | not)) | .number')
49+
--jq '.[] | select(.state=="open" and (.assignees | length > 0) and (.pull_request | not))')
5050

51-
if [ -z "$ISSUES" ]; then
51+
if [ -z "$ALL_ISSUES_JSON" ]; then
5252
echo "No open issues with assignees found."
5353
exit 0
5454
fi
5555

56-
for ISSUE in $ISSUES; do
56+
echo "$ALL_ISSUES_JSON" | jq -c '.' | while read -r ISSUE_JSON; do
57+
ISSUE=$(echo "$ISSUE_JSON" | jq -r '.number')
5758
echo "============================================================"
5859
echo " ISSUE #$ISSUE"
5960
echo "============================================================"
6061

61-
ISSUE_JSON=$(gh api "repos/$REPO/issues/$ISSUE")
6262
ASSIGNEES=$(echo "$ISSUE_JSON" | jq -r '.assignees[].login')
6363

6464
if [ -z "$ASSIGNEES" ]; then

.github/workflows/bot-issue-reminder-no-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: bot-issue-reminder-no-pr
22

33
on:
44
schedule:
5-
- cron: "0 10 * * *" #runs daily at 10:00 UTC
5+
- cron: "0 13 * * *" #runs daily at 13:00 UTC
66
workflow_dispatch:
77
inputs:
88
dry_run:

CHANGELOG.md

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,13 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
1010

1111
### Added
1212

13+
- Fix inactivity bot execution for local dry-run testing.
1314
- Added documentation: "Testing GitHub Actions using Forks" (`docs/sdk_developers/training/testing_forks.md`).
1415
- Unified the inactivity-unassign bot into a single script with `DRY_RUN` support, and fixed handling of cross-repo PR references for stale detection.
1516
- Added unit tests for `SubscriptionHandle` class covering cancellation state, thread management, and join operations.
1617
- Refactored `account_create_transaction_create_with_alias.py` example by splitting monolithic function into modular functions: `generate_main_and_alias_keys()`, `create_account_with_ecdsa_alias()`, `fetch_account_info()`, `print_account_summary()` (#1016)
18+
- Added `.github/workflows/bot-pr-auto-draft-on-changes.yml` to automatically convert PRs to draft and notify authors when reviewers request changes.
19+
-
1720
- Modularized `transfer_transaction_fungible` example by introducing `account_balance_query()` & `transfer_transaction()`.Renamed `transfer_tokens()``main()`
1821
- Phase 2 of the inactivity-unassign bot: Automatically detects stale open pull requests (no commit activity for 21+ days), comments with a helpful InactivityBot message, closes the stale PR, and unassigns the contributor from the linked issue.
1922
- Added `__str__()` to CustomFixedFee and updated examples and tests accordingly.
@@ -34,22 +37,35 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
3437
- Add PR inactivity reminder bot for stale pull requests `.github/workflows/pr-inactivity-reminder-bot.yml`
3538
- Add comprehensive training documentation for _Executable class `docs/sdk_developers/training/executable.md`
3639
- Added empty `docs/maintainers/good_first_issues.md` file for maintainers to write Good First Issue guidelines (#1034)
37-
- Added Issue Reminder (no-PR) bot, `.github/scripts/issue_reminder_no_pr.sh` and `.github/workflows/bot-issue-reminder-no-pr.yml` to automatically detect assigned issues with no linked pull requests for 7+ days and post a gentle ReminderBot comment.(#951)
40+
-Added new `.github/ISSUE_TEMPLATE/04_good_first_issue_candidate.yml` file (1068)(https://github.com/hiero-ledger/hiero-sdk-python/issues/1068)
41+
- Enhanced `.github/ISSUE_TEMPLATE/01_good_first_issue.yml` with welcoming message and acceptance criteria sections to guide contributors in creating quality GFIs (#1052)
42+
- Add workflow to notify team about P0 issues `bot-p0-issues-notify-team.yml`
43+
- Added Issue Reminder (no-PR) bot, .github/scripts/issue_reminder_no_pr.sh and .github/workflows/bot-issue-reminder-no-pr.yml to automatically detect assigned issues with no linked pull requests for 7+ days and post a gentle ReminderBot comment.(#951)
3844

3945
### Changed
40-
46+
- Refactored `account_create_transaction_with_fallback_alias.py` by splitting the monolithic `create_account_with_fallback_alias` function into modular functions: `generate_fallback_key`, `fetch_account_info`, and `print_account_summary`. The existing `setup_client()` function was reused for improved readability and structure (#1018)
4147
- Allow `PublicKey` for `TokenUpdateKeys` in `TokenUpdateTransaction`, enabling non-custodial workflows where operators can build transactions using only public keys (#934).
4248
- Bump protobuf toml to protobuf==6.33.2
49+
- chore: Move account allowance example to correct folder
4350
- Added more tests to the CustomFee class for different functionalities (#991)
4451
- Changed messaged for test failure summaries so it is clearer by extracting test failure names into summary
4552
- Renamed example files to match src naming (#1053)
53+
- Updated bot naming conventions in `.github/workflows` to be consistent (#1042)
54+
- Renamed workflow files for consistent PR check naming:
55+
`examples.yml``pr-check-examples.yml`,
56+
`test.yml``pr-check-test.yml` (#1043)
57+
- Cleaned up `token_airdrop_claim_auto` example for pylint compliance (no functional changes). (#1079)
58+
- Update team notification script and workflow for P0 issues 'p0_issues_notify_team.js'
59+
- Rename test files across the repository to ensure they consistently end with _test.py (#1055)
4660

4761
### Fixed
4862

63+
- Fix token association verification in `token_airdrop_transaction.py` to correctly check if tokens are associated by using `token_id in token_balances` instead of incorrectly displaying zero balances which was misleading (#[815])
4964
- Fixed inactivity bot workflow not checking out repository before running (#964)
5065
- Fixed the topic_message_query integarion test
5166
- good first issue template yaml rendering
5267
- Fixed solo workflow defaulting to zero
68+
- Fix unit test tet_query.py
5369

5470
### Breaking Change
5571

@@ -616,3 +632,4 @@ contract_call_local_pb2.ContractLoginfo -> contract_types_pb2.ContractLoginfo
616632
### Removed
617633

618634
- N/A
635+

commit_msg.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fix: Restore CHANGELOG and optimize script

0 commit comments

Comments
 (0)