Skip to content

Commit 69e6a32

Browse files
chore: enable coderabbit for beginner issues (#1387)
Signed-off-by: Kushagra Kaushik <[email protected]> Signed-off-by: Kushagra Kaushik <[email protected]>
1 parent fa4c3ff commit 69e6a32

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

.github/scripts/coderabbit_plan_trigger.js

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,19 @@ async function triggerCodeRabbitPlan(github, owner, repo, issue, marker) {
2020
}
2121
}
2222

23-
function hasIntermediateOrAdvancedLabel(issue, label) {
24-
// Check if issue has intermediate or advanced label (case-insensitive)
25-
const hasIntermediateLabel = issue.labels?.some(l => l?.name?.toLowerCase() === 'intermediate');
26-
const hasAdvancedLabel = issue.labels?.some(l => l?.name?.toLowerCase() === 'advanced');
27-
23+
function hasBeginnerOrHigherLabel(issue, label) {
24+
// Check if issue has beginner, intermediate or advanced label (case-insensitive)
25+
26+
const allowed = ['beginner', 'intermediate', "advanced"];
27+
28+
const hasAllowedLabel = issue.labels?.some(l => allowed.includes(l?.name?.toLowerCase()));
29+
2830
// Also check if newly added label is intermediate/advanced
29-
const isNewLabelIntermediate = label?.name?.toLowerCase() === 'intermediate';
30-
const isNewLabelAdvanced = label?.name?.toLowerCase() === 'advanced';
31+
32+
const isNewLabelAllowed = allowed.includes(label?.name?.toLowerCase());
33+
34+
return hasAllowedLabel || isNewLabelAllowed;
3135

32-
return hasIntermediateLabel || hasAdvancedLabel || isNewLabelIntermediate || isNewLabelAdvanced;
3336
}
3437

3538
async function hasExistingCodeRabbitPlan(github, owner, repo, issueNumber) {
@@ -65,7 +68,7 @@ module.exports = async ({ github, context }) => {
6568
// Validations
6669
if (!issue?.number) return console.log('No issue in payload');
6770

68-
if (!hasIntermediateOrAdvancedLabel(issue, label)) {
71+
if (!hasBeginnerOrHigherLabel(issue, label)) {
6972
return console.log('Issue does not have intermediate or advanced label');
7073
}
7174

.github/workflows/bot-coderabbit-plan-trigger.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,16 @@ jobs:
1414
concurrency:
1515
group: coderabbit-plan-${{ github.event.issue.number }}
1616
cancel-in-progress: false
17-
# Only run for issues labeled with 'intermediate' or 'advanced' (case-insensitive)
17+
# Only run for issues labeled with 'beginner', 'intermediate' or 'advanced' (case-insensitive)
1818
if: >
1919
(github.event_name == 'issues' && (
2020
contains(github.event.issue.labels.*.name, 'intermediate') ||
21+
contains(github.event.issue.labels.*.name, 'beginner') ||
2122
contains(github.event.issue.labels.*.name, 'advanced') ||
2223
contains(github.event.issue.labels.*.name, 'Intermediate') ||
24+
contains(github.event.issue.labels.*.name, 'Beginner') ||
2325
contains(github.event.issue.labels.*.name, 'Advanced') ||
24-
(github.event.label && (github.event.label.name == 'intermediate' || github.event.label.name == 'advanced' || github.event.label.name == 'Intermediate' || github.event.label.name == 'Advanced'))
26+
(github.event.label && (github.event.label.name == 'intermediate' || github.event.label.name == 'advanced' || github.event.label.name == 'Intermediate' || github.event.label.name == 'Advanced' || github.event.label.name == 'beginner'|| github.event.label.name == 'Beginner'))
2527
))
2628
2729
steps:

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
147147
- Add CodeRabbit documentation review prompts for docs, sdk_users, and sdk_developers with priorities, philosophy, and edge case checks. ([#1236](https://github.com/hiero-ledger/hiero-sdk-python/issues/1236))
148148
- Enhance NodeAddress tests with additional coverage for proto conversion `tests/unit/node_address_test.py`
149149
- Updated `pyproject.toml` to enforce stricter Ruff linting rules, including Google-style docstrings (`D`), import sorting (`I`), and modern Python syntax (`UP`).
150+
- Modified and renamed hasIntermediateOrAdvancedLabel() to check if issue label is beginner or higher (#1385)
150151

151152
### Fixed
152153
- GFI workflow casing

0 commit comments

Comments
 (0)