feat: typing for transaction module

Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>

Author: exploreriii

src/hiero_sdk_python/transaction/query_payment.py

@@ -1,16 +1,16 @@
-from hiero_sdk_python.consensus.topic_id import TopicId
 from hiero_sdk_python.account.account_id import AccountId
-from hiero_sdk_python.tokens.token_id import TokenId
+from hiero_sdk_python.crypto.private_key import PrivateKey
 from hiero_sdk_python.hbar import Hbar
 from hiero_sdk_python.transaction.transfer_transaction import TransferTransaction
 from hiero_sdk_python.transaction.transaction_id import TransactionId
+from hiero_sdk_python.hapi.services import transaction_body_pb2
 
 def build_query_payment_transaction(
     payer_account_id: AccountId,
-    payer_private_key,
+    payer_private_key: PrivateKey,
     node_account_id: AccountId,
     amount: Hbar
-):
+) -> transaction_body_pb2.TransactionBody:
     """
     Build and sign a TransferTransaction that sends `amount` of HBAR from
     `payer_account_id` to `node_account_id`. Returns a Transaction proto

src/hiero_sdk_python/transaction/transaction.py

@@ -22,7 +22,7 @@ class Transaction(_Executable):
     2. _get_method(channel) - Return the appropriate gRPC method to call
     """
 
-    def __init__(self):
+    def __init__(self) -> None:
         """
         Initializes a new Transaction instance with default values.
         """
@@ -60,7 +60,11 @@ def _make_request(self):
         """
         return self._to_proto()
 
-    def _map_response(self, response, node_id, proto_request):
+    def _map_response(
+            self, 
+            response, 
+            node_id, 
+            proto_request):
         """
         Implements the Executable._map_response method to create a TransactionResponse.
 
@@ -386,4 +390,4 @@ def set_transaction_memo(self, memo):
         """
         self._require_not_frozen()
         self.memo = memo
-        return self
+        return self

src/hiero_sdk_python/transaction/transaction_id.py

@@ -1,7 +1,9 @@
+import secrets
+
 import time
+from typing import Any, Optional
 from hiero_sdk_python.hapi.services import basic_types_pb2, timestamp_pb2
 from hiero_sdk_python.account.account_id import AccountId
-import random
 
 class TransactionId:
     """
@@ -15,19 +17,23 @@ class TransactionId:
         valid_start (Timestamp): The valid start time of the transaction.
     """
 
-    def __init__(self, account_id: AccountId = None, valid_start: timestamp_pb2.Timestamp = None):
+    def __init__(
+        self, 
+        account_id: Optional[AccountId] = None, 
+        valid_start: Optional[timestamp_pb2.Timestamp] = None
+    ) -> None:
         """
         Initializes a TransactionId with the given account ID and valid start timestamp.
 
         Args:
-            account_id (AccountId): The account ID initiating the transaction.
-            valid_start (Timestamp): The valid start time of the transaction.
+            account_id (AccountId, optional): The account ID initiating the transaction.
+            valid_start (timestamp_pb2.Timestamp, optional): The valid start time of the transaction.
         """
-        self.account_id = account_id
-        self.valid_start = valid_start
+        self.account_id: Optional[AccountId] = account_id
+        self.valid_start: Optional[timestamp_pb2.Timestamp] = valid_start
 
     @classmethod
-    def generate(cls, account_id: AccountId):
+    def generate(cls, account_id: AccountId) -> "TransactionId":
         """
         Generates a new TransactionId using the current time as the valid start,
         subtracting a random number of seconds to adjust for potential network delays.
@@ -38,15 +44,15 @@ def generate(cls, account_id: AccountId):
         Returns:
             TransactionId: A new TransactionId instance.
         """
-        cut_off_seconds = random.randint(5, 8) # subtract random number of seconds between 5 and 8
-        adjusted_time = time.time() - cut_off_seconds
-        seconds = int(adjusted_time)
-        nanos = int((adjusted_time - seconds) * 1e9)
+        cut_off_seconds = secrets.choice([5, 6, 7, 8])
+        adjusted_time: float = time.time() - cut_off_seconds
+        seconds: int = int(adjusted_time)
+        nanos: int = int((adjusted_time - seconds) * 1e9)
         valid_start = timestamp_pb2.Timestamp(seconds=seconds, nanos=nanos)
         return cls(account_id, valid_start)
 
     @classmethod
-    def from_string(cls, transaction_id_str: str):
+    def from_string(cls, transaction_id_str: str) -> "TransactionId":
         """
         Parses a TransactionId from a string in the format 'account_id@seconds.nanos'.
 
@@ -60,6 +66,8 @@ def from_string(cls, transaction_id_str: str):
             ValueError: If the input string is not in the correct format.
         """
         try:
+            account_id_str: Optional[str] = None
+            timestamp_str: Optional[str] = None
             account_id_str, timestamp_str = transaction_id_str.split('@')
             account_id = AccountId.from_string(account_id_str)
             seconds_str, nanos_str = timestamp_str.split('.')
@@ -92,7 +100,7 @@ def _to_proto(self) -> basic_types_pb2.TransactionID:
         return transaction_id_proto
 
     @classmethod
-    def _from_proto(cls, transaction_id_proto: basic_types_pb2.TransactionID):
+    def _from_proto(cls, transaction_id_proto: basic_types_pb2.TransactionID) -> "TransactionId":
         """
         Creates a TransactionId instance from a protobuf TransactionID object.
 
@@ -106,7 +114,7 @@ def _from_proto(cls, transaction_id_proto: basic_types_pb2.TransactionID):
         valid_start = transaction_id_proto.transactionValidStart
         return cls(account_id, valid_start)
 
-    def __eq__(self, other):
+    def __eq__(self, other: Any) -> bool:
         """
         Checks if this TransactionId is equal to another.
 
@@ -123,7 +131,7 @@ def __eq__(self, other):
             self.valid_start.nanos == other.valid_start.nanos
         )
 
-    def __hash__(self):
+    def __hash__(self) -> int:
         """
         Returns the hash of the TransactionId.
 
@@ -132,7 +140,7 @@ def __hash__(self):
         """
         return hash((self.account_id, self.valid_start.seconds, self.valid_start.nanos))
 
-    def __str__(self):
+    def __str__(self) -> str:
         """
         Returns the string representation of the TransactionId.
 

src/hiero_sdk_python/transaction/transaction_receipt.py

@@ -1,12 +1,28 @@
-import warnings 
-from hiero_sdk_python.contract.contract_id import ContractId
+"""
+transaction_receipt.py
+~~~~~~~~~~~~~~~~~~~~~~
+
+Defines the TransactionReceipt class, which represents the outcome of a Hedera transaction.
+
+This module provides structured access to fields in a transaction receipt,
+including associated IDs like TokenId, TopicId, AccountId, and FileId.
+It wraps the underlying protobuf object and exposes key properties with
+optional deprecated alias support via `_DeprecatedAliasesMixin`.
+
+Classes:
+    - TransactionReceipt: Parses and exposes fields from a transaction receipt protobuf.
+"""
+from typing import Optional, cast
 from hiero_sdk_python.file.file_id import FileId
+from hiero_sdk_python.contract.contract_id import ContractId
 from hiero_sdk_python.tokens.token_id import TokenId
 from hiero_sdk_python.consensus.topic_id import TopicId
 from hiero_sdk_python.account.account_id import AccountId
 from hiero_sdk_python._deprecated import _DeprecatedAliasesMixin
+from hiero_sdk_python.transaction.transaction_id import TransactionId
+from hiero_sdk_python.hapi.services import transaction_receipt_pb2, response_code_pb2
 
-class TransactionReceipt(_DeprecatedAliasesMixin):
+class TransactionReceipt(_DeprecatedAliasesMixin):  # type: ignore[misc]
     """
     Represents the receipt of a transaction.
     Imports deprecated aliases for tokenId, topicId and accountId.
@@ -17,21 +33,27 @@ class TransactionReceipt(_DeprecatedAliasesMixin):
     Attributes:
         status (ResponseCode): The status code of the transaction.
         _receipt_proto (TransactionReceiptProto): The underlying protobuf receipt.
+        _transaction_id (TransactionId): The transaction ID associated with this receipt.
     """
 
-    def __init__(self, receipt_proto, transaction_id=None):
+    def __init__(
+        self,
+        receipt_proto: transaction_receipt_pb2.TransactionReceipt,
+        transaction_id: Optional[TransactionId] = None
+    ) -> None:
         """
         Initializes the TransactionReceipt with the provided protobuf receipt.
 
         Args:
-            receipt_proto (TransactionReceiptProto): The protobuf transaction receipt.
+            receipt_proto (transaction_receipt_pb2.TransactionReceiptProto, optional): The protobuf transaction receipt.
+            transaction_id (TransactionId, optional): The transaction ID associated with this receipt.
         """
-        self._transaction_id = transaction_id
-        self.status = receipt_proto.status
-        self._receipt_proto = receipt_proto
+        self._transaction_id: Optional[TransactionId] = transaction_id
+        self.status: Optional[response_code_pb2.ResponseCodeEnum] = receipt_proto.status
+        self._receipt_proto: transaction_receipt_pb2.TransactionReceipt = receipt_proto
 
     @property
-    def token_id(self):
+    def token_id(self) -> Optional[TokenId]:
         """
         Retrieves the TokenId associated with the transaction receipt, if available.
 
@@ -40,11 +62,10 @@ def token_id(self):
         """
         if self._receipt_proto.HasField('tokenID') and self._receipt_proto.tokenID.tokenNum != 0:
             return TokenId._from_proto(self._receipt_proto.tokenID)
-        else:
-            return None
+        return None
 
     @property
-    def topic_id(self):
+    def topic_id(self) -> Optional[TopicId]:
         """
         Retrieves the TopicId associated with the transaction receipt, if available.
 
@@ -53,44 +74,44 @@ def topic_id(self):
         """
         if self._receipt_proto.HasField('topicID') and self._receipt_proto.topicID.topicNum != 0:
             return TopicId._from_proto(self._receipt_proto.topicID)
-        else:
-            return None
+        return None
 
     @property
-    def account_id(self):
+    def account_id(self) -> Optional[AccountId]:
         """
         Retrieves the AccountId associated with the transaction receipt, if available.
 
         Returns:
             AccountId or None: The AccountId if present; otherwise, None.
         """
-        if self._receipt_proto.HasField('accountID') and self._receipt_proto.accountID.accountNum != 0:
+        if (
+            self._receipt_proto.HasField('accountID')
+            and self._receipt_proto.accountID.accountNum != 0
+        ):
             return AccountId._from_proto(self._receipt_proto.accountID)
-        else:
-            return None
+        return None
 
     @property
-    def serial_numbers(self):
+    def serial_numbers(self) -> list[int]:
         """
         Retrieves the serial numbers associated with the transaction receipt, if available.
         
         Returns:
             list of int: The serial numbers if present; otherwise, an empty list.
         """
-        return self._receipt_proto.serialNumbers
+        return cast(list[int], self._receipt_proto.serialNumbers)
 
     @property
-    def file_id(self):
+    def file_id(self) -> Optional[FileId]:
         """
         Returns the file ID associated with this receipt.
         """
         if self._receipt_proto.HasField('fileID') and self._receipt_proto.fileID.fileNum != 0:
             return FileId._from_proto(self._receipt_proto.fileID)
-        else:
-            return None
-          
+        return None
+
     @property
-    def transaction_id(self):
+    def transaction_id(self) -> Optional[TransactionId]:
         """
         Returns the transaction ID associated with this receipt.
 
@@ -117,10 +138,18 @@ def _to_proto(self):
         Returns the underlying protobuf transaction receipt.
 
         Returns:
-            TransactionReceiptProto: The protobuf transaction receipt.
+            transaction_receipt_pb2.TransactionReceipt: The protobuf transaction receipt.
         """
         return self._receipt_proto
 
     @classmethod
-    def _from_proto(cls, proto, transaction_id=None):
+    def _from_proto(cls, proto: transaction_receipt_pb2.TransactionReceipt, transaction_id: TransactionId) -> "TransactionReceipt":
+        """
+        Creates a TransactionReceipt instance from a protobuf TransactionReceipt object.
+        Args:
+            proto (transaction_receipt_pb2.TransactionReceipt): The protobuf TransactionReceipt object.
+            transaction_id (TransactionId): The transaction ID associated with this receipt.
+        Returns:
+            TransactionReceipt: A new instance of TransactionReceipt populated with data from the protobuf object.
+        """
         return cls(receipt_proto=proto, transaction_id=transaction_id)

src/hiero_sdk_python/transaction/transaction_record.py

@@ -79,7 +79,7 @@ def _from_proto(cls, proto: transaction_record_pb2.TransactionRecord, transactio
             transaction_hash=proto.transactionHash,
             transaction_memo=proto.memo,
             transaction_fee=proto.transactionFee,
-            receipt=TransactionReceipt._from_proto(proto.receipt),
+            receipt=TransactionReceipt._from_proto(proto.receipt, transaction_id),
             token_transfers=token_transfers,
             nft_transfers=nft_transfers,
             transfers=transfers,

src/hiero_sdk_python/transaction/transaction_response.py

@@ -1,19 +1,27 @@
+"""
+transaction_response.py
+~~~~~~~~~~~~~~~~~~~~~~~~
+
+Represents the response from a transaction submitted to the Hedera network.
+Provides methods to retrieve the receipt and access core transaction details.
+"""
 from hiero_sdk_python.account.account_id import AccountId
 from hiero_sdk_python.transaction.transaction_id import TransactionId
+# pylint: disable=too-few-public-methods
 
 class TransactionResponse:
     """
     Represents the response from a transaction submitted to the Hedera network.
     """
 
-    def __init__(self):
+    def __init__(self) -> None:
         """
         Initialize a new TransactionResponse instance with default values.
         """
         self.transaction_id = TransactionId()
-        self.node_id = AccountId()
-        self.hash = bytes()
-        self.validate_status = False
+        self.node_id: AccountId = AccountId()
+        self.hash: bytes = bytes()
+        self.validate_status: bool = False
         self.transaction = None
 
     def get_receipt(self, client):
@@ -30,6 +38,10 @@ def get_receipt(self, client):
         # TODO: Decide how to avoid circular imports
         from hiero_sdk_python.query.transaction_get_receipt_query import TransactionGetReceiptQuery
         # TODO: Implement set_node_account_ids() to get failure reason for preHandle failures
-        receipt = TransactionGetReceiptQuery().set_transaction_id(self.transaction_id).execute(client)
-    
-        return receipt
+        receipt = (
+            TransactionGetReceiptQuery()
+            .set_transaction_id(self.transaction_id)
+            .execute(client)
+        )
+
+        return receipt