refactor: improve token_delete_transaction (#885)

Signed-off-by: tech0priyanshu <[email protected]>

Author: tech0priyanshu

CHANGELOG.md

@@ -15,6 +15,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Document error handling patterns and best practices for transaction receipts
 
 - fix `pull_request` to `pull_request_target` in `bot-verified-commits.yml`
+- Add more robust receipt checks and removed fallback to `examples/tokens/token_delete_transaction.py`
 - Add detail to `token_airdrop.py` and `token_airdrop_cancel.py`
 - Add workflow: github bot to respond to unverified PR commits (#750)
 - Add workflow: bot workflow which notifies developers of workflow failures in their pull requests.
@@ -57,6 +58,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - changed to add concurrency to workflow bot
 
 ### Fixed
+
 - chore: updated solo action to avoid v5
 - chore: fix test.yml workflow to log import errors (#740)
 - chore: fixed integration test names without a test prefix or postfix

examples/tokens/token_delete_transaction.py

@@ -1,8 +1,5 @@
-# uv run examples/tokens/token_delete.py
-# python examples/tokens/token_delete.py
-"""
-A full example that creates a token and then immediately deletes it.
-"""
+# uv run examples/tokens/token_delete_transaction.py
+# python examples/tokens/token_delete_transaction.py
 
 import os
 import sys
@@ -15,6 +12,7 @@
     Network,
     TokenCreateTransaction,
     TokenDeleteTransaction,
+    ResponseCode,
 )
 
 # Load environment variables from .env file
@@ -64,17 +62,24 @@ def create_new_token(client, operator_id, operator_key, admin_key):
             .set_treasury_account_id(operator_id)
             .set_admin_key(admin_key)  # Use the newly generated admin key
             .freeze_with(client)
-            .sign(operator_key)  # Operator (treasury) must sign
-            .sign(admin_key)     # The new admin key must also sign
+            .sign(operator_key) # Operator (treasury) must sign
+            .sign(admin_key)  # The new admin key must also sign
         )
 
         create_receipt = create_tx.execute(client)
+
+        # Verify the receipt status
+        rc = ResponseCode(create_receipt.status)
+        if rc != ResponseCode.SUCCESS:
+            print(f"❌ Token creation failed with status: {rc.name}")
+            sys.exit(1)
+
         token_id_to_delete = create_receipt.token_id
-        print(f"✅ Success! Created token with ID: {token_id_to_delete}")
+        print(f"✅ Token created successfully: {token_id_to_delete}")
         return token_id_to_delete
 
-    except (ValueError, TypeError) as e:
-        print(f"❌ Error creating token: {e}")
+    except Exception as e:
+        print(f"❌ Error creating token: {repr(e)}")
         sys.exit(1)
 
 
@@ -87,17 +92,24 @@ def delete_token(admin_key, token_id_to_delete, client, operator_key):
         print(f"\nSTEP 2: Deleting token {token_id_to_delete}...")
         delete_tx = (
             TokenDeleteTransaction()
-            .set_token_id(token_id_to_delete)  # Use the ID from the token we just made
-            .freeze_with(client)
-            .sign(operator_key)  # Operator must sign
-            .sign(admin_key)     # Sign with the same admin key used to create it
+            .set_token_id(token_id_to_delete) # Use the ID from the token we just made
+            .freeze_with(client)  # Use the ID from the token we just made
+            .sign(operator_key) # Operator must sign
+            .sign(admin_key) # Sign with the same admin key used to create it
         )
 
-        delete_tx.execute(client)
-        print("✅ Success! Token deleted.")
+        delete_receipt = delete_tx.execute(client)
+
+        # Verify deletion receipt status
+        rc = ResponseCode(delete_receipt.status)
+        if rc != ResponseCode.SUCCESS:
+            print(f"❌ Token deletion failed with status: {rc.name}")
+            sys.exit(1)
+
+        print(f"✅ Token {token_id_to_delete} deleted successfully!")
 
-    except (ValueError, TypeError) as e:
-        print(f"❌ Error deleting token: {e}")
+    except Exception as e:
+        print(f"❌ Error deleting token: {repr(e)}")
         sys.exit(1)
 
 def main():