Skip to content

Commit ffdca53

Browse files
fix: address CodeRabbit review feedback
Signed-off-by: prishajaiswal75 <[email protected]>
1 parent db46104 commit ffdca53

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

examples/account/account_create_transaction_evm_alias.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def create_account_with_alias(client):
4848
print("\nSTEP 1: Generating a new ECDSA key pair for the account alias...")
4949
private_key = PrivateKey.generate('ecdsa')
5050
public_key = private_key.public_key()
51-
print(f"✅ Generated new ECDSA key pair. The EVM address alias will be automatically derived.")
51+
print("✅ Generated new ECDSA key pair. The EVM address alias will be automatically derived.")
5252
# Create the account with the alias
5353
print("\nSTEP 2: Creating the account with the EVM address alias...")
5454
transaction = (

examples/tokens/token_create_transaction_wipe_key.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,17 @@ def create_recipient_account(client):
7373
Helper: Create a new account to hold tokens(wiped ones)
7474
"""
7575
private_key = PrivateKey.generate_ed25519()
76+
# tx = (
77+
# AccountCreateTransaction()
78+
# .set_key_without_alias(private_key.public_key())
79+
# .set_initial_balance(Hbar(2))
80+
# )
7681
tx = (
7782
AccountCreateTransaction()
7883
.set_key_without_alias(private_key.public_key())
7984
.set_initial_balance(Hbar(2))
80-
)
85+
.freeze_with(client)
86+
)
8187
receipt = tx.execute(client)
8288
if receipt.status != ResponseCode.SUCCESS:
8389
print(

tests/unit/account_create_transaction_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def test_account_create_transaction():
161161

162162
# Use the context manager to set up and tear down the mock environment
163163
with mock_hedera_servers(response_sequences) as client, \
164-
patch('time.sleep'):
164+
patch('time.sleep'):
165165

166166
# Create the transaction
167167
new_key = PrivateKey.generate()
@@ -189,7 +189,7 @@ def test_sign_account_create_without_freezing_raises_error(mock_account_ids):
189189
AccountCreateTransaction()
190190
.set_key_without_alias(new_public_key)
191191
.set_initial_balance(100000000)
192-
.set_account_memo("Test account"))
192+
.set_account_memo("Test account")
193193
)
194194
account_tx.transaction_id = generate_transaction_id(operator_id)
195195
account_tx.node_account_id = node_account_id

0 commit comments

Comments
 (0)