-
Notifications
You must be signed in to change notification settings - Fork 167
Description
π§© Intermediate Contributors
This issue is intended for contributors who already have some familiarity with the
Hiero Python SDK codebase and contribution workflow.
You should feel comfortable:
- navigating existing source code and examples
- understanding SDK concepts without step-by-step guidance
- following the standard PR workflow without additional onboarding
If this is your very first contribution to the project, we recommend starting with a few
Good First Issues before working on this one.
π Problem Description
Coderabbit is our first-review-stage AI reviewer
We seek to prompt code rabbit to reach senior-level feedback, and provide this helpful feedback to every pull request
We've prompted it on how to review /examples and /tests, but not yet /docs.
π‘ Expected Solution
Prompt code rabbit on how to review /docs
π§ Implementation Notes
- Edit .coderabbit.yaml at the project root
- Add custom instructions on how to review /docs
Note our /docs are a work in progress meaning they are not yet perfect, somewhat not perfectly structured or complete. Therefore, it is more important to prompt code rabbit on general PRINCIPLES rather than exact instructions without flexibility.
Helpful resources:
Read our existing prompts at root:
.coderabbit.yaml
Read code rabbit documentation:
https://docs.coderabbit.ai/reference/configuration
https://github.com/coderabbitai/awesome-coderabbit/blob/main/configs/python/coderabbit-python-portal.yaml
https://github.com/coderabbitai/awesome-coderabbit/tree/main/configs/python
How our /docs are currently structured:
- sdk_developers
- sdk_users
Code rabbit should generally understand docs placed in each file serve slightly different purposes.
for sdk developers, it will be technical, how to develop for the SDK, so is more training based in multple areas like writing examples, source code, tests, etc, as well as following our workflow.
for sdk users, they do not need to know any of the workflow or source code , tests, etc, they just need to clearly understand HOW to USE the sdk. Most likely, they'll spend most of the time studying /examples.
These users have different goals:
sdk developers want to understand how to become a python sdk developer
sdk users want to understand how to use the python sdk as quickly as possible, and as correctly as possible
inside sdk_developers we have /training which will one day become a more structured training scheme. WIP.
Here are SOME ideas I have, but this is just a rough guide and only a starting point:
path_instructions:
path: "docs/**"
represent general documentation for both sdk users and sdk developers
Focus on correctness, clarity, and usefulness, not detail.
Consider whether missing explanations in a pull request should be additions to that PR or a new issue raised
Avoid suggesting large-scale restructures unless a problem blocks understanding.
Check URls if possible
path: "docs/sdk_users/**"
instructions: >-
-These documents are user facing guidelines intended for
developers consuming the SDK.
Assume readers have some development experience but may be totally new new to this SDK.
Do not assume any knowledge of how to use the sdk
Do not assume any knowledge of how the sdk was constructed, nor desire
The user just wants to learn how to use the sdk
Explanations must be concrete, actionable, and unambiguous.
Steps should be explicit and ordered.
Ensure snippets are correct, complete, and up to date.
path: "docs/sdk_developers/**"
instructions: >-
These documents are developer-facing and may include tutorials,
architectural explanations, or contribution guidance.
Assume some readers may be total beginners yet some experts
Assume intent to extend, debug, or contribute to the SDK.
β Acceptance Criteria
To merge this issue, the pull request must:
- Fully address the problem described above
- Follow existing project conventions and patterns
- Include tests or example updates where appropriate
- Pass all CI checks
- Include a valid changelog entry
- Use DCO and GPG-signed commits