Skip to content

Conversation

@dtee1
Copy link
Contributor

@dtee1 dtee1 commented Jan 31, 2026

Description:

Related issue(s):

Fixes #1657

Notes for reviewer:

Checklist

  • [✔ ] Documented (Code comments, README, etc.)
  • [ ✔] Tested (unit, integration, etc.)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2026

Walkthrough

Updates the bot comment marker from a visible text token to an HTML comment (<!-- commit-verification-bot -->) and adds a CHANGELOG entry documenting that the marker is now hidden in pull request comments.

Changes

Cohort / File(s) Summary
Configuration Update
.github/scripts/bot-verified-commits.js
Changed CONFIG.COMMENT_MARKER default from '[commit-verification-bot]' to '<!-- commit-verification-bot -->' so the marker is emitted as an HTML comment.
Changelog
CHANGELOG.md
Added an Unreleased → Changed entry: "Hide the commit verification bot marker in pull request comments."

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: hide commit verification bot comment' clearly summarizes the main change of updating the bot marker to be hidden as an HTML comment.
Description check ✅ Passed The description references the linked issue #1657 and indicates documentation and tests were updated, which is related to the changeset.
Linked Issues check ✅ Passed The code change exactly matches the requirement in #1657: updating CONFIG.COMMENT_MARKER from '[commit-verification-bot]' to '' in bot-verified-commits.js.
Out of Scope Changes check ✅ Passed Only the specified marker change and changelog update were made; no extraneous modifications beyond issue #1657 requirements are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@dtee1 dtee1 changed the title Hide commit verification bot comment chore: hide commit verification bot comment Jan 31, 2026
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1662   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         140      140           
  Lines        8765     8765           
=======================================
  Hits         8142     8142           
  Misses        623      623           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@exploreriii exploreriii merged commit 8a69134 into hiero-ledger:main Jan 31, 2026
20 of 21 checks passed
@github-actions
Copy link

🎉 Nice work completing a Good First Issue!

Thank you for your contribution to the Hiero Python SDK! We're excited to have you as part of our community.

Here are some issues labeled Beginner you might be interested in working on next:

  1. [Beginner]: Fix duplication in next issue recommendation sub text

    🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level...

  2. [Beginner]: Implement __repr__ Method for FileId Class

    🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

  3. [Beginner]: Implement __repr__ Method for NftId Class

    🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

🌟 Stay connected with the project:

We look forward to seeing more contributions from you! If you have any questions, feel free to ask in our Discord community.

From the Hiero Python SDK Team 🚀

@exploreriii
Copy link
Contributor

Super ! Thank you so much @dtee1 for this valuable improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Hide [commit-verification-bot] comment

2 participants