Suggestion: Apply settings for each team to automatically assign members on pull requests

[rbarker-dev]

Currently all teams defined in hiero-ledger are missing some key settings:

We should have each team that is listed in a CODEOWNERS file within the hiero-ledger organization auto-assigning team members.

The recommended settings are included above. This will provide load balancing on counted issues per user on a given team; it will still display which codeowners teams are on a given PR etc.

[poulok]

+1

[andrewb1269hg]

I think this is excellent.

[rbarker-dev]

Doing this will also remove the spam notifications that are received by all teams whenever a new PR is created that includes their codeowner team.

[nathanklick]

+1

[litt3]

I'll chime in, since it was this conversation that prompted the change:

For me personally, getting auto assigned as a reviewer ever will be enough to keep me from joining to organization.

[rbarker-dev]

It is possible to ensure certain team members aren't assigned as reviewers.

[cody-littley]

Ditto. Back when I was on the team, I never found the auto-assign functionality to be helpful. When I created a review, I would always have to manually select the people I wanted to be reviewers, since the auto-picker always did a bad job guessing the appropriate reviewers. Just because github provides a feature doesn't mean it has to be used.

[nathanklick]

@litt3 If you don't want to be assigned as reviewer, we can exclude you from the assignment rotation and you can still retain your maintainer standing with the ability to review PRs as you see fit.

[litt3]

When I get the next hiero invite, I'll be able to accept, in order to be excludable (the latest invite I have is expired, and they seem to come every 8 days or so though)

[rbarker-dev]

I'll send one now.

[rbarker-dev]

@litt3 I've ensured that for the teams you are in in the hiero-ledger org that you are explicitly excluded from the review request list.

[lpetrovic05]

+1

[poulok]

@cody-littley, do you also plan on accepting? I'm sure @rbarker-dev is happy to set the same setting for you that he did for @litt3

[cody-littley]

Sure, I'll accept.

[rbarker-dev]

You have been configured so that you are explicitly excluded from the review request list.

[litt3]

@rbarker-dev With the current settings, my name isn't explicitly added as a reviewer, but I am still notified for a review and auto-subscribed whenever the group is in the reviewer list, e.g. on this PR. Do you know if there is any way to prevent this?

[rbarker-dev]

@litt3 I can double check the team notifications.. It should only be notifying if assigned.

[litt3]

I'm still getting buried in notifications. Any updates here?

[cody-littley]

I'm getting notifications now asking me to review new PRs, so unfortunately I will have to leave the org.

[rbarker-dev]

@cody-littley @litt3 that's because we renamed teams. Let me get that fixed ASAP

[poulok]

@litt3 and @cody-littley - @rbarker-dev believes he has fixed the settings so that you will no longer be spammed with PR review notifications. Do you want to accept the invitation to return and verify? Do you prefer we remove you from the committer/maintainer roles, respectively?

[rbarker-dev]

I'll need a little bit of grace to make sure that once you've accepted there's sufficient time to set the "do not auto-assign these people"

[litt3]

@rbarker-dev Accepted the invite. Thanks!

[cody-littley]

Please remove me from the role in the Heiro repo.

[rbarker-dev]

@litt3 the two teams you are a part of now have round robin assignment and only notify assigned members, and you are on the never assign list.

@cody-littley I will open a PR directly.

[poulok]

@cody-littley has been removed from his role per his request, and the settings for @litt3 have been adjusted per his request. Is it ok to close this discussion?