Tests caught stuff; good tests

Author: fkotsian

.travis.yml

@@ -23,8 +23,8 @@ matrix:
         components:
           - tools
           - platform-tools
-          - build-tools-28.0.3
-          - android-28
+          - build-tools-29.0.2
+          - android-29
       sudo: true
       before_install:
         - nvm install --lts

android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java

@@ -70,7 +70,7 @@ private int currentAndroidVersion() {
     }
 
     private boolean requiresLegacyAuthentication() {
-        return currentAndroidVersion < 23;
+        return currentAndroidVersion() < 23;
     }
 
     public class AuthCallback extends BiometricPrompt.AuthenticationCallback {
@@ -269,6 +269,8 @@ private String legacyGetErrorMessage() {
         } else if (!getFingerprintIdentify().isFingerprintEnable()) {
             return "FingerprintScannerNotAvailable";
         }
+
+        return null;
     }
 
 
@@ -299,7 +301,7 @@ public void onFailed(boolean isDeviceLocked) {
                 if(isDeviceLocked){
                     promise.reject("AuthenticationFailed", "DeviceLocked");
                 } else {
-                    promise.reject("AuthenticationFailed", TYPE_FINGERPRINT);
+                    promise.reject("AuthenticationFailed", TYPE_FINGERPRINT_LEGACY);
                 }
                 ReactNativeFingerprintScannerModule.this.release();
             }