Skip to content

Add solhint rule to enforce that all interface function implementations should be "override" #89

@scorpion9979

Description

@scorpion9979

In the Hifi monorepo, all the interface function implementations use the "override" modifier. The issue here is that the "override" modifier has been made optional for interface functions since Solidity v0.8.8, and so any implementations that are defined without it would still result in successful compilation.

I think we should not just stick to our current coding style throughout the entire monorepo, but we should also enforce it by enabling the "comprehensive-interface" solhint rule.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions