Merge changes from the higan and bsnes copies of nall.

In general, I chose the higan version if there was a difference, except for the
few things I knew had been patched specifically in bsnes:

  - endian-detection made more portable
  - fixed a buffer-overflow in string formatting

Also, while merging I realised there was a place that used "char *" while most
of nall uses "char*", so I fixed that too.

Author: Screwtapello

intrinsics.hpp

@@ -117,14 +117,6 @@ namespace nall {
 
 }
 
-#if defined(PLATFORM_MACOS)
-  #include <machine/endian.h>
-#elif defined(PLATFORM_LINUX)
-  #include <endian.h>
-#elif defined(PLATFORM_BSD)
-  #include <sys/endian.h>
-#endif
-
 /* Architecture detection */
 
 namespace nall {
@@ -157,12 +149,44 @@ namespace nall {
 
 /* Endian detection */
 
+#if defined(PLATFORM_MACOS)
+  #include <machine/endian.h>
+#elif defined(PLATFORM_LINUX)
+  #include <endian.h>
+#elif defined(PLATFORM_BSD)
+  #include <sys/endian.h>
+#endif
+
 namespace nall {
 
-#if (defined(__BYTE_ORDER) && defined(__LITTLE_ENDIAN) && __BYTE_ORDER == __LITTLE_ENDIAN) || defined(__LITTLE_ENDIAN__) || defined(__i386__) || defined(__amd64__) || defined(_M_IX86) || defined(_M_AMD64)
+// A note on endian constants: Traditional UNIX provides a header that defines
+// constants LITTLE_ENDIAN, BIG_ENDIAN, and BYTE_ORDER (set to LITTLE_ENDIAN or
+// BIG_ENDIAN as appropriate). However, C89 says that the compiler/libc should
+// not introduce any names unless they start with an underscore, so when you're
+// compiling in standards-compilant mode, those constants are named
+// __LITTLE_ENDIAN, or sometimes _LITTLE_ENDIAN, or sometimes even LITTLE_ENDIAN
+// on platforms that care more about tradition than standards. The platforms
+// that rename the constants usually provide some other name you can #define to
+// say, "forget C89, yes I really want traditional constant names", but *that*
+// name also differs from platform to platform, and it affects more than just
+// the endian header.
+//
+// Rather than wade into that mess, let's just test for all the constants we
+// know about.
+
+#if  (defined(__BYTE_ORDER) && defined(__LITTLE_ENDIAN) && __BYTE_ORDER == __LITTLE_ENDIAN) \
+  || (defined( _BYTE_ORDER) && defined( _LITTLE_ENDIAN) &&  _BYTE_ORDER ==  _LITTLE_ENDIAN) \
+  || (defined(  BYTE_ORDER) && defined(  LITTLE_ENDIAN) &&   BYTE_ORDER ==   LITTLE_ENDIAN) \
+  || defined(__LITTLE_ENDIAN__) \
+  || defined(__i386__) || defined(__amd64__) \
+  || defined(_M_IX86) || defined(_M_AMD64)
   #define ENDIAN_LSB
   constexpr auto endian() -> Endian { return Endian::LSB; }
-#elif (defined(__BYTE_ORDER) && defined(__BIG_ENDIAN) && __BYTE_ORDER == __BIG_ENDIAN) || defined(__BIG_ENDIAN__) || defined(__powerpc__) || defined(_M_PPC)
+#elif(defined(__BYTE_ORDER) && defined(__BIG_ENDIAN) && __BYTE_ORDER == __BIG_ENDIAN) \
+  || (defined( _BYTE_ORDER) && defined( _BIG_ENDIAN) &&  _BYTE_ORDER ==  _BIG_ENDIAN) \
+  || (defined(  BYTE_ORDER) && defined(  BIG_ENDIAN) &&   BYTE_ORDER ==   BIG_ENDIAN) \
+  || defined(__BIG_ENDIAN__) \
+  || defined(__powerpc__) || defined(_M_PPC)
   #define ENDIAN_MSB
   constexpr auto endian() -> Endian { return Endian::MSB; }
 #else

path.hpp

@@ -91,7 +91,7 @@ inline auto userSettings() -> string {
   string result = {Path::user(), "Library/Application Support/"};
   #else
   string result;
-  if(const char *env = getenv("XDG_CONFIG_HOME")) {
+  if(const char* env = getenv("XDG_CONFIG_HOME")) {
     result = string(env);
   } else {
     result = {Path::user(), ".config/"};

string/format.hpp

@@ -41,7 +41,7 @@ inline auto string::format(const nall::string_format& params) -> type& {
 
     if(sourceSize > targetSize) {
       uint difference = sourceSize - targetSize;
-      memory::move(&data[x], &data[x + difference], remaining);
+      memory::move(&data[x], &data[x + difference], remaining - difference);
       size -= difference;
     } else if(targetSize > sourceSize) {
       uint difference = targetSize - sourceSize;