add: extend support for AttributePhaseChange. (#67)

The attribute phase change property can be applied  to
group, dataset and file create property lists. This commit
adds support for dataset and file property lists.

---------

Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>

Author: radistmorse

include/highfive/H5PropertyList.hpp

@@ -689,16 +689,27 @@ class AttributePhaseChange {
     /// attributes are moved to compact storage.
     AttributePhaseChange(unsigned max_compact, unsigned min_dense);
 
+    /// \brief Extract threshold values from property list.
+    explicit AttributePhaseChange(const FileCreateProps& gcpl);
+
     /// \brief Extract threshold values from property list.
     explicit AttributePhaseChange(const GroupCreateProps& gcpl);
 
+    /// \brief Extract threshold values from property list.
+    explicit AttributePhaseChange(const DataSetCreateProps& gcpl);
+
     unsigned max_compact() const;
     unsigned min_dense() const;
 
   private:
+    friend DataSetCreateProps;
+    friend FileCreateProps;
     friend GroupCreateProps;
     void apply(hid_t hid) const;
 
+    template <class PList>
+    void init(const PList& plist);
+
     unsigned _max_compact;
     unsigned _min_dense;
 };

include/highfive/bits/H5PropertyList_misc.hpp

@@ -472,8 +472,21 @@ inline AttributePhaseChange::AttributePhaseChange(unsigned max_compact, unsigned
     : _max_compact(max_compact)
     , _min_dense(min_dense) {}
 
+template <class PList>
+void AttributePhaseChange::init(const PList& plist) {
+    detail::h5p_get_attr_phase_change(plist.getId(), &_max_compact, &_min_dense);
+}
+
+inline AttributePhaseChange::AttributePhaseChange(const FileCreateProps& fcpl) {
+    init(fcpl);
+}
+
 inline AttributePhaseChange::AttributePhaseChange(const GroupCreateProps& gcpl) {
-    detail::h5p_get_attr_phase_change(gcpl.getId(), &_max_compact, &_min_dense);
+    init(gcpl);
+}
+
+inline AttributePhaseChange::AttributePhaseChange(const DataSetCreateProps& dcpl) {
+    init(dcpl);
 }
 
 inline unsigned AttributePhaseChange::max_compact() const {

tests/unit/tests_high_five_base.cpp

@@ -1225,19 +1225,41 @@ TEST_CASE("WriteLargeAttribute") {
     CHECK_NOTHROW(group.createAttribute("attr", large_attr));
 }
 
+template <class CPL, class CreateObject>
+void check_attribute_phase_change(CreateObject create_object) {
+    auto cpl = CPL::Default();
+    cpl.add(HighFive::AttributePhaseChange(42, 24));
+
+    auto obj = create_object(cpl);
+    auto actual = AttributePhaseChange(obj.getCreatePropertyList());
+    CHECK(actual.min_dense() == 24);
+    CHECK(actual.max_compact() == 42);
+}
+
 TEST_CASE("AttributePhaseChange") {
-    auto fapl = HighFive::FileAccessProps::Default();
-    fapl.add(HighFive::FileVersionBounds(H5F_LIBVER_LATEST, H5F_LIBVER_LATEST));
-    HighFive::File file("attribute_phase_change.h5", HighFive::File::Truncate, fapl);
+    auto create_file = [](HighFive::FileCreateProps fcpl = HighFive::FileCreateProps::Default()) {
+        auto fapl = HighFive::FileAccessProps::Default();
+        fapl.add(HighFive::FileVersionBounds(H5F_LIBVER_LATEST, H5F_LIBVER_LATEST));
+        return HighFive::File("attribute_phase_change.h5", HighFive::File::Truncate, fcpl, fapl);
+    };
 
-    auto gcpl = HighFive::GroupCreateProps::Default();
-    gcpl.add(HighFive::AttributePhaseChange(42, 24));
+    SECTION("File") {
+        check_attribute_phase_change<HighFive::FileCreateProps>(create_file);
+    }
 
-    auto group = file.createGroup("grp", gcpl);
+    SECTION("Group") {
+        auto file = create_file();
+        check_attribute_phase_change<HighFive::GroupCreateProps>(
+            [&file](auto gcpl) { return file.createGroup("grp", gcpl); });
+    }
 
-    auto actual = AttributePhaseChange(group.getCreatePropertyList());
-    CHECK(actual.min_dense() == 24);
-    CHECK(actual.max_compact() == 42);
+    SECTION("Dataset") {
+        auto file = create_file();
+        check_attribute_phase_change<HighFive::DataSetCreateProps>([&file](auto dcpl) {
+            auto space = HighFive::DataSpace::Scalar();
+            return file.createDataSet<double>("dset", space, dcpl);
+        });
+    }
 }
 
 TEST_CASE("datasetOffset") {