remove: ObjectInfo::getAddress

The function was moved to Object::getAddress.

Author: 1uc

doc/migration_guide.md

@@ -262,3 +262,15 @@ an address. Meaning one can't take it's address or const-references of it
 ## Removal of `Object*Props`.
 To our knowledge these could not be used meaningfully. Please create an issue
 if you relied on these.
+
+## Removal of `ObjectInfo::getAddress()`.
+The functionality was moved to Object::getAddress. Typically, replace
+```
+// old
+dataset.getInfo().getAddress()
+
+// new
+dataset.getAddress()
+```
+Keep in mind that not all files (e.g. HSDS) have addresses. Instead they seem
+to have VOL tokens. This is likely best avoided in generic code.

include/highfive/H5Object.hpp

@@ -118,11 +118,6 @@ class ObjectInfo {
   public:
     ObjectInfo(const Object& obj);
 
-    /// \brief Retrieve the address of the object (within its file)
-    /// \deprecated Deprecated since HighFive 2.2. Soon supporting VOL tokens
-    H5_DEPRECATED("Deprecated since HighFive 2.2. Soon supporting VOL tokens")
-    haddr_t getAddress() const noexcept;
-
     /// \brief Retrieve the number of references to this object
     size_t getRefCount() const noexcept;
 

include/highfive/bits/H5Object_misc.hpp

@@ -118,10 +118,6 @@ inline ObjectInfo::ObjectInfo(const Object& obj) {
     detail::h5o_get_info1(obj.getId(), &raw_info);
 }
 
-inline haddr_t ObjectInfo::getAddress() const noexcept {
-    return raw_info.addr;
-}
-
 inline size_t ObjectInfo::getRefCount() const noexcept {
     return raw_info.rc;
 }

tests/unit/tests_high_five_base.cpp

@@ -871,8 +871,7 @@ TEST_CASE("DataTypeEqualTakeBack") {
     CHECK(s == dataset.getDataType());
     CHECK(d != dataset.getDataType());
 
-    // Test getAddress and expect deprecation warning
-    auto addr = dataset.getInfo().getAddress();
+    auto addr = dataset.getAddress();
     CHECK(addr != 0);
 }