Skip to content

Commit d232494

Browse files
committed
Compact naming.
1 parent a3dc4ae commit d232494

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

compiler/src/main/java/org/hisrc/jsonix/compiler/CreateTypeInfoDeclarationVisitor.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ final class CreateTypeInfoDeclarationVisitor<T, C extends T> implements
6161
private static final String IDREFS_TYPE_INFO_NAME = "IDREFS";
6262
private static final String IDREF_TYPE_INFO_NAME = "IDREF";
6363
private static final String ID_TYPE_INFO_NAME = "ID";
64-
64+
6565
private static Map<QName, String> XSD_TYPE_MAPPING = new HashMap<QName, String>();
6666
{
6767
XSD_TYPE_MAPPING.put(XmlSchemaConstants.ANYTYPE, "AnyType");
@@ -162,7 +162,7 @@ public JSAssignmentExpression visitEnumLeafInfo(MEnumLeafInfo<T, C> info) {
162162
public JSAssignmentExpression visitClassInfo(MClassInfo<T, C> info) {
163163
return createTypeInfoDeclaration(info);
164164
}
165-
165+
166166
@Override
167167
public JSAssignmentExpression visitClassRef(MClassRef<T, C> info) {
168168
return createTypeInfoDeclaration(info);
@@ -171,8 +171,13 @@ public JSAssignmentExpression visitClassRef(MClassRef<T, C> info) {
171171
public JSAssignmentExpression visitList(MList<T, C> info) {
172172
final JSObjectLiteral list = this.codeModel.object();
173173
list.append(naming.type(), this.codeModel.string(naming.list()));
174-
list.append(naming.typeInfo(),
175-
info.getItemTypeInfo().acceptTypeInfoVisitor(this));
174+
final JSAssignmentExpression typeInfoDeclaration = info
175+
.getItemTypeInfo().acceptTypeInfoVisitor(this);
176+
if (!typeInfoDeclaration
177+
.acceptExpressionVisitor(new CheckValueStringLiteralExpressionVisitor(
178+
"String"))) {
179+
list.append(naming.typeInfo(), typeInfoDeclaration);
180+
}
176181
return list;
177182
}
178183

compiler/src/main/java/org/hisrc/jsonix/compiler/PropertyInfoVisitor.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737

3838
import org.hisrc.jscm.codemodel.JSCodeModel;
3939
import org.hisrc.jscm.codemodel.expression.JSArrayLiteral;
40+
import org.hisrc.jscm.codemodel.expression.JSAssignmentExpression;
4041
import org.hisrc.jscm.codemodel.expression.JSMemberExpression;
4142
import org.hisrc.jscm.codemodel.expression.JSObjectLiteral;
4243
import org.jvnet.jaxb2_commons.xml.bind.model.MAnyAttributePropertyInfo;
@@ -93,9 +94,13 @@ private void createTypedOptions(MTyped<T, C> info,
9394
typeInfo.acceptTypeInfoVisitor(new DefaultTypeInfoVisitor<T, C, Void>() {
9495
@Override
9596
public Void visitTypeInfo(MTypeInfo<T, C> typeInfo) {
96-
options.append(naming.typeInfo(),
97-
PropertyInfoVisitor.this.jsonixCompiler
98-
.getTypeInfoDeclaration(typeInfo));
97+
final JSAssignmentExpression typeInfoDeclaration = PropertyInfoVisitor.this.jsonixCompiler
98+
.getTypeInfoDeclaration(typeInfo);
99+
if (!typeInfoDeclaration
100+
.acceptExpressionVisitor(new CheckValueStringLiteralExpressionVisitor(
101+
"String"))) {
102+
options.append(naming.typeInfo(), typeInfoDeclaration);
103+
}
99104
return null;
100105
}
101106

0 commit comments

Comments
 (0)