Skip to content

Commit de233c1

Browse files
sfc-gh-alisowskisfc-gh-alisowski
committed
tests
1 parent 8b2c554 commit de233c1

File tree

6 files changed

+48
-31
lines changed

6 files changed

+48
-31
lines changed

‎packages/react/src/ReactWindowSplitter.test.tsx‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ test("Keyboard interactions with collapsed panels", async () => {
255255
fireEvent.keyDown(resizer2, { key: "Enter" });
256256
await expectTemplate(
257257
handle.current,
258-
"209px 10px 168.953125px 10px 100.03125px"
258+
"209.015625px 10px 167px 10px 101.984375px"
259259
);
260260

261261
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
@@ -264,22 +264,25 @@ test("Keyboard interactions with collapsed panels", async () => {
264264
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
265265
await expectTemplate(
266266
handle.current,
267-
"209px 10px 164.96875px 10px 104.03125px"
267+
"209.015625px 10px 163px 10px 105.984375px"
268268
);
269269

270270
fireEvent.keyDown(resizer2, { key: "ArrowLeft", shiftKey: true });
271271
await expectTemplate(
272272
handle.current,
273-
"209px 10px 149.96875px 10px 119.03125px"
273+
"209.03125px 10px 147.984375px 10px 120.984375px"
274274
);
275275

276276
fireEvent.keyDown(resizer2, { key: "Enter" });
277-
await expectTemplate(handle.current, "209px 10px 209px 10px 60px");
277+
await expectTemplate(
278+
handle.current,
279+
"209.03125px 10px 208.96875px 10px 60px"
280+
);
278281

279282
fireEvent.keyDown(resizer2, { key: "Enter" });
280283
await expectTemplate(
281284
handle.current,
282-
"209px 10px 149.96875px 10px 119.03125px"
285+
"209.046875px 10px 144.9375px 10px 124.015625px"
283286
);
284287
});
285288

‎packages/solid/src/SolidWindowSplitter.test.tsx‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,25 +221,28 @@ test("Keyboard interactions with collapsed panels", async () => {
221221

222222
const resizer2 = document.getElementById("resizer-2")!;
223223
fireEvent.keyDown(resizer2, { key: "Enter" });
224-
await expectTemplate(handle, "209px 10px 169px 10px 100px");
224+
await expectTemplate(handle, "209.015625px 10px 167px 10px 101.984375px");
225225

226226
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
227227
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
228228
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
229229
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
230-
await expectTemplate(handle, "209px 10px 165px 10px 104px");
230+
await expectTemplate(handle, "209.015625px 10px 163px 10px 105.984375px");
231231

232232
fireEvent.keyDown(resizer2, { key: "ArrowLeft", shiftKey: true });
233233
await expectTemplate(
234234
handle,
235-
"209.03125px 10px 149.984375px 10px 118.984375px"
235+
"209.03125px 10px 147.984375px 10px 120.984375px"
236236
);
237237

238238
fireEvent.keyDown(resizer2, { key: "Enter" });
239239
await expectTemplate(handle, "209.03125px 10px 208.96875px 10px 60px");
240240

241241
fireEvent.keyDown(resizer2, { key: "Enter" });
242-
await expectTemplate(handle, "209.0625px 10px 149.96875px 10px 118.96875px");
242+
await expectTemplate(
243+
handle,
244+
"209.046875px 10px 144.9375px 10px 124.015625px"
245+
);
243246
});
244247

245248
describe("imperative panel API", async () => {

‎packages/state/src/index.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2260,8 +2260,6 @@ export function groupMachine(
22602260
(output) => {
22612261
actions.onAnimationEnd(output);
22622262
transition("idle");
2263-
panel.collapsed = true;
2264-
panel.onCollapseChange?.current?.(true);
22652263
if (event.resolve) {
22662264
requestAnimationFrame(event.resolve);
22672265
}
@@ -2285,8 +2283,6 @@ export function groupMachine(
22852283
(output) => {
22862284
actions.onAnimationEnd(output);
22872285
transition("idle");
2288-
panel.collapsed = false;
2289-
panel.onCollapseChange?.current?.(false);
22902286
if (event.resolve) {
22912287
requestAnimationFrame(event.resolve);
22922288
}

‎packages/svelte/src/SvelteWindowSplitter.test.svelte.ts‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -255,18 +255,24 @@ test("Keyboard interactions with collapsed panels", async () => {
255255

256256
const resizer2 = document.getElementById("resizer-2")!;
257257
fireEvent.keyDown(resizer2, { key: "Enter" });
258-
await expectTemplate(collapsibleHandle, "209px 10px 169px 10px 100px");
258+
await expectTemplate(
259+
collapsibleHandle,
260+
"209.015625px 10px 167px 10px 101.984375px"
261+
);
259262

260263
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
261264
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
262265
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
263266
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
264-
await expectTemplate(collapsibleHandle, "209px 10px 165px 10px 104px");
267+
await expectTemplate(
268+
collapsibleHandle,
269+
"209.015625px 10px 163px 10px 105.984375px"
270+
);
265271

266272
fireEvent.keyDown(resizer2, { key: "ArrowLeft", shiftKey: true });
267273
await expectTemplate(
268274
collapsibleHandle,
269-
"209.03125px 10px 149.984375px 10px 118.984375px"
275+
"209.03125px 10px 147.984375px 10px 120.984375px"
270276
);
271277

272278
fireEvent.keyDown(resizer2, { key: "Enter" });
@@ -278,6 +284,6 @@ test("Keyboard interactions with collapsed panels", async () => {
278284
fireEvent.keyDown(resizer2, { key: "Enter" });
279285
await expectTemplate(
280286
collapsibleHandle,
281-
"209.0625px 10px 149.96875px 10px 118.96875px"
287+
"209.046875px 10px 144.9375px 10px 124.015625px"
282288
);
283289
});

‎packages/vue/src/VueWindowSplitter.test.ts‎

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,10 @@ describe("Autosave", () => {
101101
await expectTemplate(handle.value!, "342px 10px 146px");
102102

103103
await waitForCondition(() =>
104-
Boolean(localStorage.getItem("autosave-example-vue")),
104+
Boolean(localStorage.getItem("autosave-example-vue"))
105105
);
106106
const obj = JSON.parse(
107-
localStorage.getItem("autosave-example-vue") || "{}",
107+
localStorage.getItem("autosave-example-vue") || "{}"
108108
);
109109
expect(obj.items).toMatchSnapshot();
110110
});
@@ -145,7 +145,7 @@ describe("Autosave", () => {
145145
await expectTemplate(handle.value!, "343px 10px 147px");
146146

147147
await waitForCondition(() =>
148-
document.cookie.includes("autosave-cookie-vue"),
148+
document.cookie.includes("autosave-cookie-vue")
149149
);
150150

151151
expect(document.cookie).toMatchSnapshot();
@@ -163,7 +163,7 @@ describe("Autosave", () => {
163163
});
164164
});
165165

166-
test("Keyboard interactions with collapsed panels", async () => {
166+
test.only("Keyboard interactions with collapsed panels", async () => {
167167
const handle = { value: null } as { value: PanelGroupHandle | null };
168168
await Collapsible.run({ args: { handle } });
169169

@@ -172,18 +172,24 @@ test("Keyboard interactions with collapsed panels", async () => {
172172

173173
const resizer2 = document.getElementById("resizer-2")!;
174174
fireEvent.keyDown(resizer2, { key: "Enter" });
175-
await expectTemplate(handle.value!, "209px 10px 169px 10px 100px");
175+
await expectTemplate(
176+
handle.value!,
177+
"209.015625px 10px 167px 10px 101.984375px"
178+
);
176179

177180
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
178181
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
179182
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
180183
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
181-
await expectTemplate(handle.value!, "209px 10px 165px 10px 104px");
184+
await expectTemplate(
185+
handle.value!,
186+
"209.015625px 10px 163px 10px 105.984375px"
187+
);
182188

183189
fireEvent.keyDown(resizer2, { key: "ArrowLeft", shiftKey: true });
184190
await expectTemplate(
185191
handle.value!,
186-
"209.03125px 10px 149.984375px 10px 118.984375px",
192+
"209.03125px 10px 147.984375px 10px 120.984375px"
187193
);
188194

189195
fireEvent.keyDown(resizer2, { key: "Enter" });
@@ -192,7 +198,7 @@ test("Keyboard interactions with collapsed panels", async () => {
192198
fireEvent.keyDown(resizer2, { key: "Enter" });
193199
await expectTemplate(
194200
handle.value!,
195-
"209.0625px 10px 149.96875px 10px 118.96875px",
201+
"209.046875px 10px 144.9375px 10px 124.015625px"
196202
);
197203
});
198204

@@ -260,10 +266,10 @@ describe("imperative panel API", async () => {
260266
expect(leftHandle.value!.isCollapsed()).toBe(true);
261267
expect(leftHandle.value!.isExpanded()).toBe(false);
262268
expect(rightHandle.value!.getPercentageSize()).toBe(
263-
leftHandle.value!.getPercentageSize(),
269+
leftHandle.value!.getPercentageSize()
264270
);
265271
expect(rightHandle.value!.getPixelSize()).toBe(
266-
leftHandle.value!.getPixelSize(),
272+
leftHandle.value!.getPixelSize()
267273
);
268274

269275
leftHandle.value!.expand();

‎packages/web-component/src/WebComponentWindowSplitter.test.ts‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,25 +199,28 @@ test("Keyboard interactions with collapsed panels", async () => {
199199

200200
const resizer2 = document.getElementById("resizer-2")!;
201201
fireEvent.keyDown(resizer2, { key: "Enter" });
202-
await expectTemplate(handle!, "209px 10px 169px 10px 100px");
202+
await expectTemplate(handle!, "209.015625px 10px 167px 10px 101.984375px");
203203

204204
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
205205
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
206206
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
207207
fireEvent.keyDown(resizer2, { key: "ArrowLeft" });
208-
await expectTemplate(handle!, "209px 10px 165px 10px 104px");
208+
await expectTemplate(handle!, "209.015625px 10px 163px 10px 105.984375px");
209209

210210
fireEvent.keyDown(resizer2, { key: "ArrowLeft", shiftKey: true });
211211
await expectTemplate(
212212
handle!,
213-
"209.03125px 10px 149.984375px 10px 118.984375px"
213+
"209.03125px 10px 147.984375px 10px 120.984375px"
214214
);
215215

216216
fireEvent.keyDown(resizer2, { key: "Enter" });
217217
await expectTemplate(handle!, "209.03125px 10px 208.96875px 10px 60px");
218218

219219
fireEvent.keyDown(resizer2, { key: "Enter" });
220-
await expectTemplate(handle!, "209.0625px 10px 149.96875px 10px 118.96875px");
220+
await expectTemplate(
221+
handle!,
222+
"209.046875px 10px 144.9375px 10px 124.015625px"
223+
);
221224
});
222225

223226
describe("imperative panel API", async () => {

0 commit comments

Comments
 (0)