moved isResponseOk() to Helper class

Author: hiqsol

src/base/Controller.php

@@ -11,6 +11,7 @@
 namespace hidev\base;
 
 use hidev\console\CommonBehavior;
+use hidev\helpers\Helper;
 
 /**
  * Basic controller.
@@ -61,22 +62,12 @@ public function runActions($actions)
         foreach ($this->normalizeTasks($actions) as $action => $enabled) {
             if ($enabled) {
                 $res = $this->runAction($action);
-                if (!static::isResponseOk($res)) {
+                if (!Helper::isResponseOk($res)) {
                     return $res;
                 }
             }
         }
 
         return 0;
     }
-
-    /**
-     * Is response Ok.
-     * @param Response|int $response
-     * @return bool
-     */
-    public static function isResponseOk($response)
-    {
-        return !(is_object($response) ? $response->exitStatus : $response);
-    }
 }

src/console/CommonBehavior.php

@@ -11,6 +11,7 @@
 namespace hidev\console;
 
 use hidev\base\Controller;
+use hidev\helpers\Helper;
 use Yii;
 use yii\console\Request;
 
@@ -32,7 +33,7 @@ public function events()
     public function onBeforeAction($event)
     {
         $result = $this->runRequests($event->sender->before);
-        if (!Controller::isResponseOk($result)) {
+        if (!Helper::isResponseOk($result)) {
             $this->beforeResult = $result;
             $event->isValid = false;
         }
@@ -53,7 +54,7 @@ public function runRequests($requests)
         foreach ($this->normalizeTasks($requests) as $request => $enabled) {
             if ($enabled) {
                 $response = $this->runRequest($request);
-                if (!Controller::isResponseOk($response)) {
+                if (!Helper::isResponseOk($response)) {
                     return $response;
                 }
             }

src/helpers/Helper.php

@@ -108,4 +108,14 @@ public static function readpassword($prompt)
 
         return $password;
     }
+
+    /**
+     * Is response Ok.
+     * @param Response|int $response
+     * @return bool
+     */
+    public static function isResponseOk($response)
+    {
+        return !(is_object($response) ? $response->exitStatus : $response);
+    }
 }