HP-1751 tiny

Author: VadymHrechukha

src/product/BillingRegistry.php

@@ -19,16 +19,16 @@
 class BillingRegistry implements BillingRegistryInterface
 {
     /** @var TariffTypeDefinitionInterface[] */
-    private array $tariffTypes = [];
+    private array $tariffTypeDefinitions = [];
     private bool $locked = false;
 
-    public function addTariffType(TariffTypeDefinitionInterface $tariffType): void
+    public function addTariffType(TariffTypeDefinitionInterface $tariffTypeDefinition): void
     {
         if ($this->locked) {
             throw new BillingRegistryLockedException("BillingRegistry is locked and cannot be modified.");
         }
 
-        $this->tariffTypes[] = $tariffType;
+        $this->tariffTypeDefinitions[] = $tariffTypeDefinition;
     }
 
     public function lock(): void
@@ -38,8 +38,8 @@ public function lock(): void
 
     public function priceTypes(): \Generator
     {
-        foreach ($this->tariffTypes as $tariffType) {
-            foreach ($tariffType->withPrices() as $priceTypeDefinition) {
+        foreach ($this->tariffTypeDefinitions as $tariffTypeDefinition) {
+            foreach ($tariffTypeDefinition->withPrices() as $priceTypeDefinition) {
                 yield $priceTypeDefinition;
             }
         }
@@ -146,7 +146,7 @@ private function findBehaviorInPriceType(
 
     public function getBehaviors(string $behaviorClassWrapper): \Generator
     {
-        foreach ($this->tariffTypes as $tariffType) {
+        foreach ($this->tariffTypeDefinitions as $tariffType) {
             foreach ($tariffType->withBehaviors() as $behavior) {
                 if ($behavior instanceof $behaviorClassWrapper) {
                     yield $behavior;

tests/unit/product/BillingRegistryTest.php

@@ -67,10 +67,9 @@ public function testGetBehavior(): void
         $tariffType = new DummyTariffType();
         $tariffTypeDefinition = new TariffTypeDefinition($tariffType);
         $dummyBehavior = new DummyBehavior('dummy');
-        $tariffTypeDefinition->withBehaviors()
-            ->attach($dummyBehavior);
+        $tariffTypeDefinition->withBehaviors()->attach($dummyBehavior);
+        $this->registry->addTariffType($tariffTypeDefinition);  // monthly()
 
-        $this->registry->addTariffType($tariffTypeDefinition);
         $behavior = $this->registry->getBehavior($tariffType->name(), DummyBehavior::class);
 
         $this->assertSame($dummyBehavior->getContext(), $behavior->getContext());