HP-2419 extended functional of BillingRegistry for easier use

Author: VadymHrechukha

src/product/BillingRegistry.php

@@ -2,38 +2,42 @@
 
 namespace hiqdev\php\billing\product;
 
-use hiqdev\php\billing\product\behavior\InvalidBehaviorException;
-use hiqdev\php\billing\product\Exception\AggregateNotFoundException;
-use hiqdev\php\billing\product\invoice\InvalidRepresentationException;
-use hiqdev\php\billing\product\invoice\RepresentationInterface;
-use hiqdev\php\billing\product\price\PriceTypeDefinition;
 use hiqdev\php\billing\product\quantity\QuantityFormatterInterface;
-use hiqdev\php\billing\product\quantity\QuantityFormatterNotFoundException;
 use hiqdev\php\billing\product\quantity\FractionQuantityData;
 use hiqdev\php\billing\product\behavior\BehaviorInterface;
-use hiqdev\php\billing\product\behavior\BehaviorNotFoundException;
 use hiqdev\php\billing\product\trait\HasLock;
-use hiqdev\php\billing\type\Type;
-use hiqdev\php\billing\type\TypeInterface;
 
 class BillingRegistry implements BillingRegistryInterface
 {
     use HasLock;
 
     /** @var TariffTypeDefinitionInterface[] */
     private array $tariffTypeDefinitions = [];
+
     private bool $locked = false;
 
+    private BillingRegistryService $service;
+
+    public function __construct()
+    {
+        $this->service = new BillingRegistryService($this);
+    }
+
     public function addTariffType(TariffTypeDefinitionInterface $tariffTypeDefinition): void
     {
         $this->ensureNotLocked();
 
         $this->tariffTypeDefinitions[] = $tariffTypeDefinition;
     }
 
+    public function getTariffTypeDefinitions(): array
+    {
+        return $this->tariffTypeDefinitions;
+    }
+
     public function priceTypes(): \Generator
     {
-        foreach ($this->tariffTypeDefinitions as $tariffTypeDefinition) {
+        foreach ($this->getTariffTypeDefinitions() as $tariffTypeDefinition) {
             foreach ($tariffTypeDefinition->withPrices() as $priceTypeDefinition) {
                 yield $priceTypeDefinition;
             }
@@ -42,129 +46,42 @@ public function priceTypes(): \Generator
 
     public function getRepresentationsByType(string $representationClass): array
     {
-        if (!class_exists($representationClass)) {
-            throw new InvalidRepresentationException("Class '$representationClass' does not exist");
-        }
-
-        if (!is_subclass_of($representationClass, RepresentationInterface::class)) {
-            throw new InvalidBehaviorException(
-                sprintf('Representation class "%s" does not implement RepresentationInterface', $representationClass)
-            );
-        }
-
-        $representations = [];
-        foreach ($this->priceTypes() as $priceTypeDefinition) {
-            foreach ($priceTypeDefinition->documentRepresentation() as $representation) {
-                if ($representation instanceof $representationClass) {
-                    $representations[] = $representation;
-                }
-            }
-        }
-
-        return $representations;
+        return $this->service->getRepresentationsByType($representationClass);
     }
 
     public function createQuantityFormatter(
         string $type,
         FractionQuantityData $data,
     ): QuantityFormatterInterface {
-        $type = $this->convertStringTypeToType($type);
-
-        foreach ($this->priceTypes() as $priceTypeDefinition) {
-            if ($priceTypeDefinition->hasType($type)) {
-                return $priceTypeDefinition->createQuantityFormatter($data);
-            }
-        }
-
-        throw new QuantityFormatterNotFoundException('Quantity formatter not found');
-    }
-
-    private function convertStringTypeToType(string $type): TypeInterface
-    {
-        return Type::anyId($type);
+        return $this->service->createQuantityFormatter($type, $data);
     }
 
     public function getBehavior(string $type, string $behaviorClassWrapper): BehaviorInterface
     {
-        if (!class_exists($behaviorClassWrapper)) {
-            throw new InvalidBehaviorException(
-                sprintf('Behavior class "%s" does not exist', $behaviorClassWrapper)
-            );
-        }
-
-        if (!is_subclass_of($behaviorClassWrapper, BehaviorInterface::class)) {
-            throw new InvalidBehaviorException(
-                sprintf('Behavior class "%s" does not implement BehaviorInterface', $behaviorClassWrapper)
-            );
-        }
-
-        $billingType = $this->convertStringTypeToType($type);
-
-        foreach ($this->priceTypes() as $priceTypeDefinition) {
-            if ($priceTypeDefinition->hasType($billingType)) {
-                $behavior = $this->findBehaviorInPriceType($priceTypeDefinition, $behaviorClassWrapper);
-
-                if ($behavior) {
-                    return $behavior;
-                }
-            }
-        }
-
-        throw new BehaviorNotFoundException(
-            sprintf('Behavior of class "%s" not found for type "%s"', $behaviorClassWrapper, $type),
-        );
-    }
-
-    private function findBehaviorInPriceType(
-        PriceTypeDefinition $priceTypeDefinition,
-        string $behaviorClassWrapper
-    ): ?BehaviorInterface {
-        foreach ($priceTypeDefinition->withBehaviors() as $behavior) {
-            if ($behavior instanceof $behaviorClassWrapper) {
-                return $behavior;
-            }
-        }
-
-        return null;
+        return $this->service->getBehavior($type, $behaviorClassWrapper);
     }
 
+    /**
+     * @inerhitDoc
+     */
     public function getBehaviors(string $behaviorClassWrapper): \Generator
     {
-        foreach ($this->tariffTypeDefinitions as $tariffTypeDefinition) {
-            foreach ($tariffTypeDefinition->withBehaviors() as $behavior) {
-                if ($behavior instanceof $behaviorClassWrapper) {
-                    yield $behavior;
-                }
-            }
-        }
-
-        foreach ($this->priceTypes() as $priceTypeDefinition) {
-            foreach ($priceTypeDefinition->withBehaviors() as $behavior) {
-                if ($behavior instanceof $behaviorClassWrapper) {
-                    yield $behavior;
-                }
-            }
-        }
+        return $this->service->getBehaviors($behaviorClassWrapper);
     }
 
     public function getAggregate(string $type): AggregateInterface
     {
-        $type = $this->convertStringTypeToType($type);
-
-        foreach ($this->priceTypes() as $priceTypeDefinition) {
-            if ($priceTypeDefinition->hasType($type)) {
-                return $priceTypeDefinition->getAggregate();
-            }
-        }
+        return $this->service->getAggregate($type);
+    }
 
-        throw new AggregateNotFoundException('Aggregate was not found');
+    public function findTariffTypeDefinitionByBehavior(BehaviorInterface $behavior): TariffTypeDefinitionInterface
+    {
+        return $this->service->findTariffTypeDefinitionByBehavior($behavior);
     }
 
-    public function getTariffTypeDefinitions(): \Generator
+    public function findPriceTypeDefinitionsByBehavior(string $behaviorClassWrapper): \Generator
     {
-        foreach ($this->tariffTypeDefinitions as $tariffTypeDefinition) {
-            yield $tariffTypeDefinition;
-        }
+        return $this->service->findPriceTypeDefinitionsByBehavior($behaviorClassWrapper);
     }
 
     protected function afterLock(): void

src/product/BillingRegistryInterface.php

@@ -15,11 +15,12 @@
 interface BillingRegistryInterface extends HasLockInterface
 {
     /**
-     * @return Generator
-     * @psalm-return Generator<PriceTypeDefinitionInterface>
+     * @return Generator<PriceTypeDefinitionInterface>
      */
     public function priceTypes(): Generator;
 
+    public function getTariffTypeDefinitions(): array;
+
     public function addTariffType(TariffTypeDefinitionInterface $tariffTypeDefinition): void;
 
     /**
@@ -40,17 +41,22 @@ public function createQuantityFormatter(string $type, FractionQuantityData $data
     public function getBehavior(string $type, string $behaviorClassWrapper): BehaviorInterface;
 
     /**
+     * Find all behaviors attached to any TariffType or PriceType by specified Behavior class.
+     *
      * @param string $behaviorClassWrapper
-     * @return Generator
-     * @psalm-return Generator<BehaviorInterface>
+     * @return Generator<BehaviorInterface>
      */
     public function getBehaviors(string $behaviorClassWrapper): Generator;
 
-    public function getAggregate(string $type): AggregateInterface;
+    public function findTariffTypeDefinitionByBehavior(BehaviorInterface $behavior): TariffTypeDefinitionInterface;
 
     /**
-     * @return Generator
-     * @psalm-return Generator<TariffTypeDefinitionInterface>
+     * Find all PriceTypeDefinition in registry by specified Behavior class.
+     *
+     * @param string $behaviorClassWrapper
+     * @return \Generator<PriceTypeDefinitionInterface>
      */
-    public function getTariffTypeDefinitions(): Generator;
+    public function findPriceTypeDefinitionsByBehavior(string $behaviorClassWrapper): \Generator;
+
+    public function getAggregate(string $type): AggregateInterface;
 }