fix: treat incorrect get-token-uri none values as undefined (#1183)

Author: rafaelcr

src/tests-tokens/strict-mode-tests.ts

@@ -1,5 +1,5 @@
 import * as nock from 'nock';
-import { ChainID, ClarityAbi, cvToHex, uintCV } from '@stacks/transactions';
+import { ChainID, ClarityAbi, cvToHex, noneCV, uintCV } from '@stacks/transactions';
 import { PoolClient } from 'pg';
 import { TestBlockBuilder } from '../test-utils/test-builders';
 import { ApiServer, startApiServer } from '../api/init';
@@ -262,6 +262,34 @@ describe('token metadata strict mode', () => {
     expect(entry.result?.processed).toBe(false);
   });
 
+  test('incorrect none uri strings are parsed as undefined', async () => {
+    const mockResponse = {
+      okay: true,
+      result: cvToHex(noneCV()),
+    };
+    nock('http://127.0.0.1:20443')
+      .post(
+        '/v2/contracts/call-read/SP176ZMV706NZGDDX8VSQRGMB7QN33BBDVZ6BMNHD/project-indigo-act1/get-token-uri'
+      )
+      .reply(200, mockResponse);
+    const handler = new TokensContractHandler({
+      contractId: contractId,
+      smartContractAbi: NFT_CONTRACT_ABI,
+      datastore: db,
+      chainId: ChainID.Testnet,
+      txId: contractTxId,
+      dbQueueId: 1,
+    });
+    await handler.start();
+    const entry = await db.getTokenMetadataQueueEntry(1);
+    expect(entry.result?.retry_count).toEqual(0);
+    expect(entry.result?.processed).toBe(true);
+    const metadata = await db.getNftMetadata(
+      'SP176ZMV706NZGDDX8VSQRGMB7QN33BBDVZ6BMNHD.project-indigo-act1'
+    );
+    expect(metadata.result?.token_uri).toEqual('');
+  });
+
   test('metadata timeout errors get retried immediately', async () => {
     process.env['STACKS_API_TOKEN_METADATA_FETCH_TIMEOUT_MS'] = '500';
     const mockTokenUri = {

src/token-metadata/tokens-contract-handler.ts

@@ -505,13 +505,15 @@ export class TokensContractHandler {
     );
   }
 
-  private checkAndParseString(responseCV: ClarityValue): string {
+  private checkAndParseString(responseCV: ClarityValue): string | undefined {
     const unwrappedClarityValue = this.unwrapClarityType(responseCV);
     if (
       unwrappedClarityValue.type === ClarityType.StringASCII ||
       unwrappedClarityValue.type === ClarityType.StringUTF8
     ) {
       return unwrappedClarityValue.data;
+    } else if (unwrappedClarityValue.type === ClarityType.OptionalNone) {
+      return undefined;
     }
     throw new RetryableTokenMetadataError(
       `Unexpected Clarity type '${unwrappedClarityValue.type}' while unwrapping string`

src/token-metadata/tokens-processor-queue.ts

@@ -144,9 +144,6 @@ export class TokensProcessorQueue {
           contractId: queueEntry.contractId,
           txId: queueEntry.txId,
         });
-        logger.info(
-          `[token-metadata] finished token contract processing for: ${queueEntry.contractId} from tx ${queueEntry.txId}`
-        );
         if (this.queuedEntries.size < this.queue.concurrency) {
           void this.checkDbQueue();
         }