fix: do not duplicate miner rewards in v2 balance endpoint (#2302)

* fix: do not duplicate miner rewards in v2 balance endpoint

* test: rewards

* test: exclusive

Author: rafaelcr

src/api/routes/v2/addresses.ts

@@ -167,7 +167,7 @@ export const AddressRoutesV2: FastifyPluginAsync<
           sql,
           stxAddress,
         });
-        let stxBalance = stxBalancesResult.found ? stxBalancesResult.result.balance : 0n;
+        const stxBalance = stxBalancesResult.found ? stxBalancesResult.result.balance : 0n;
 
         // Get pox-locked info for STX token
         const stxPoxLockedResult = await fastify.db.v2.getStxPoxLockedAtBlock({
@@ -183,7 +183,6 @@ export const AddressRoutesV2: FastifyPluginAsync<
           stxAddress,
           blockHeight: chainTip.block_height,
         });
-        stxBalance += totalMinerRewardsReceived;
 
         const result: StxBalance = {
           balance: stxBalance.toString(),

tests/api/address.test.ts

@@ -3177,4 +3177,63 @@ describe('address tests', () => {
     expect(result.type).toBe('application/json');
     expect(JSON.parse(result.text).balance).toBe(v1balance);
   });
+
+  test('balance calculation after miner rewards', async () => {
+    const addr1 = 'SP3D6PV2ACBPEKYJTCMH7HEN02KP87QSP8KTEH335';
+
+    // Send some initial balance for addr1
+    await db.update(
+      new TestBlockBuilder({
+        block_height: 1,
+        index_block_hash: '0x0001',
+        parent_index_block_hash: '',
+      })
+        .addTx({
+          tx_id: '0x1101',
+          token_transfer_recipient_address: addr1,
+          type_id: DbTxTypeId.TokenTransfer,
+          token_transfer_amount: 20_000n,
+          fee_rate: 50n,
+        })
+        .addTxStxEvent({
+          amount: 20_000n,
+          block_height: 1,
+          recipient: addr1,
+          tx_id: '0x1101',
+        })
+        .build()
+    );
+    // Add some miner rewards
+    await db.update(
+      new TestBlockBuilder({
+        block_height: 2,
+        index_block_hash: '0x0002',
+        parent_index_block_hash: '0x0001',
+      })
+        .addMinerReward({
+          index_block_hash: '0x0002',
+          recipient: addr1,
+          coinbase_amount: 2000n,
+          tx_fees_anchored: 0n,
+          tx_fees_streamed_confirmed: 0n,
+          tx_fees_streamed_produced: 0n,
+        })
+        .build()
+    );
+
+    // Check that v1 balance matches v2 balance.
+    let result = await supertest(api.server).get(`/extended/v1/address/${addr1}/stx`);
+    expect(result.status).toBe(200);
+    expect(result.type).toBe('application/json');
+    let json = JSON.parse(result.text);
+    const v1balance = json.balance;
+    const v1Rewards = json.total_miner_rewards_received;
+    expect(v1balance).toBe('22000');
+    result = await supertest(api.server).get(`/extended/v2/addresses/${addr1}/balances/stx`);
+    expect(result.status).toBe(200);
+    expect(result.type).toBe('application/json');
+    json = JSON.parse(result.text);
+    expect(json.balance).toBe(v1balance);
+    expect(json.total_miner_rewards_received).toBe(v1Rewards);
+  });
 });