refactor: refactor the code, added comment, added docker-composer in package.json

Author: asimm241

package-lock.json

@@ -153,6 +153,7 @@
     "@typescript-eslint/parser": "^2.25.0",
     "compare-versions": "^3.6.0",
     "concurrently": "^5.2.0",
+    "docker-compose": "^0.23.5",
     "eslint": "^6.8.0",
     "eslint-config-prettier": "^6.10.1",
     "eslint-plugin-prettier": "^3.1.2",

package.json

@@ -10,7 +10,6 @@ import {
 } from '@blockstack/stacks-blockchain-api-types';
 import { RosettaErrors, RosettaConstants } from '../../rosetta-constants';
 import { rosettaValidateRequest, ValidSchema, makeRosettaError } from '../../rosetta-validate';
-import { StacksCoreRpcClient } from '../../../core-rpc/client';
 
 export function createRosettaAccountRouter(db: DataStore): RouterWithAsync {
   const router = addAsync(express.Router());
@@ -49,13 +48,6 @@ export function createRosettaAccountRouter(db: DataStore): RouterWithAsync {
 
     const block = blockQuery.result;
     const result = await db.getStxBalanceAtBlock(accountIdentifier.address, block.block_height);
-    let value = result.balance.toString();
-
-    if (value == '0') {
-      const fake = await new StacksCoreRpcClient().getAccountBalance(accountIdentifier.address);
-      console.log(`-------- fake for ${accountIdentifier.address} is ${fake}`);
-      value = fake.toString();
-    }
 
     const response: RosettaAccountBalanceResponse = {
       block_identifier: {
@@ -64,7 +56,7 @@ export function createRosettaAccountRouter(db: DataStore): RouterWithAsync {
       },
       balances: [
         {
-          value: value,
+          value: result.balance.toString(),
           currency: {
             symbol: RosettaConstants.symbol,
             decimals: RosettaConstants.decimals,

src/api/routes/rosetta/account.ts

@@ -520,6 +520,12 @@ export function createRosettaConstructionRouter(db: DataStore): RouterWithAsync
     let newSignature: MessageSignature;
 
     try {
+      /**
+       * the elliptic library produces signatures that aren't in an "allowed" format
+       * it preapend v (i.e 01) while it should append it at the end, to incorporate that rotate
+       * the signature to match the elipcitc library
+       * Discussion here: https://github.com/coinbase/rosetta-sdk-go/issues/201
+       */
       let hash = signatures[0].hex_bytes;
       if (!hash.startsWith('01') && hash.slice(128) == '01') {
         hash = signatures[0].hex_bytes.slice(128) + signatures[0].hex_bytes.slice(0, -2);

src/api/routes/rosetta/construction.ts

@@ -1472,15 +1472,13 @@ describe('Rosetta API', () => {
       ],
     };
 
-    const accountInfo = await new StacksCoreRpcClient().getAccount(sender);
-
     const tokenTransferOptions: UnsignedTokenTransferOptions = {
       recipient: recipient,
       amount: new BN('500000'),
       fee: new BN(fee),
       publicKey: publicKey,
       network: GetStacksTestnetNetwork(),
-      nonce: accountInfo.nonce ? new BN(accountInfo.nonce) : new BN(0),
+      nonce: new BN(0),
     };
 
     const transaction = await makeUnsignedSTXTokenTransfer(tokenTransferOptions);
@@ -1489,12 +1487,7 @@ describe('Rosetta API', () => {
 
     const signer = new TransactionSigner(transaction);
 
-    const prehash = makeSigHashPreSign(
-      signer.sigHash,
-      AuthType.Standard,
-      new BN(fee),
-      accountInfo.nonce ? new BN(accountInfo.nonce) : new BN(0)
-    );
+    const prehash = makeSigHashPreSign(signer.sigHash, AuthType.Standard, new BN(fee), new BN(0));
 
     const result = await supertest(api.server)
       .post(`/rosetta/v1/construction/payloads`)