chore: fix openapi schema validation errors, clean up type definitions (#1170)

* fix: openapi lint validator

* fix: balances schema

* fix: add title to all entities

* fix: some additionalProperties and duplicate names

* fix: remove additional properties for rosetta

* fix: rosetta tests

* style: remove empty description

Author: rafaelcr

docs/.validaterc

@@ -1,8 +1,8 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
   "description": "GET request that returns address assets",
   "title": "AddressAssetsListResponse",
   "type": "object",
+  "additionalProperties": false,
   "required": ["results", "limit", "offset", "total"],
   "properties": {
     "limit": {

docs/api/address/get-address-assets.schema.json

@@ -1,7 +1,7 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
   "description": "GET request that returns address balances",
   "title": "AddressBalanceResponse",
+  "additionalProperties": false,
   "type": "object",
   "required": ["stx", "fungible_tokens", "non_fungible_tokens"],
   "properties": {
@@ -10,18 +10,22 @@
     },
     "fungible_tokens": {
       "type": "object",
-      "patternProperties": {
-        "*": {
-          "$ref": "../../entities/balance/ft-balance.schema.json"
-        }
+      "additionalProperties": {
+        "anyOf": [
+          {
+            "$ref": "../../entities/balance/ft-balance.schema.json"
+          }
+        ]
       }
     },
     "non_fungible_tokens": {
       "type": "object",
-      "patternProperties": {
-        "*": {
-          "$ref": "../../entities/balance/nft-balance.schema.json"
-        }
+      "additionalProperties": {
+        "anyOf": [
+          {
+            "$ref": "../../entities/balance/nft-balance.schema.json"
+          }
+        ]
       }
     },
     "token_offering_locked": {

docs/api/address/get-address-balances.schema.json

@@ -1,7 +1,7 @@
 {
-  "$schema": "http://json-schema.org/draft-04/schema#",
   "type": "object",
   "title": "AddressNftListResponse",
+  "additionalProperties": false,
   "required": [
     "limit",
     "offset",

docs/api/address/get-address-nft-events.schema.json

@@ -1,5 +1,4 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
   "description": "GET request that returns address balances",
   "title": "AddressStxBalanceResponse",
   "type": "object",
@@ -8,6 +7,8 @@
       "$ref": "../../entities/balance/stx-balance.schema.json"
     },
     {
+      "type": "object",
+      "additionalProperties": false,
       "properties": {
         "token_offering_locked": {
           "$ref": "../../entities/address/token-offering-locked.schema.json"

docs/api/address/get-address-stx-balance.schema.json

@@ -1,7 +1,7 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
   "description": "GET request that returns a list of inbound STX transfers with a memo",
   "title": "AddressStxInboundListResponse",
+  "additionalProperties": false,
   "type": "object",
   "required": ["results", "limit", "offset", "total"],
   "properties": {

docs/api/address/get-address-stx-inbound.schema.json

@@ -1,5 +1,4 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
   "description": "GET request that returns account transactions",
   "title": "AddressTransactionsWithTransfersListResponse",
   "type": "object",

docs/api/address/get-address-transactions-with-transfers.schema.json

@@ -1,5 +1,4 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
   "description": "GET request that returns account transactions",
   "title": "AddressTransactionsListResponse",
   "type": "object",

docs/api/address/get-address-transactions.schema.json

@@ -1,5 +1,4 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
   "description": "GET request that returns blocks",
   "additionalProperties": false,
   "title": "BlockListResponse",

docs/api/blocks/get-blocks.schema.json

@@ -1,9 +1,8 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema",
-  "$id": "bns-error",
   "title": "BnsError",
   "description": "Error",
   "type": "object",
+  "additionalProperties": false,
   "properties": {
     "error": { "type": "string" }
   }