Skip to content

Commit 6a12936

Browse files
authored
fix: filter BNS processing for successful txs only (#1309)
1 parent ed8b6f5 commit 6a12936

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/event-stream/bns/bns-helpers.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ export function getBnsContractID(chainId: ChainID) {
243243

244244
function isEventFromBnsContract(event: SmartContractEvent): boolean {
245245
return (
246+
event.committed === true &&
246247
event.contract_event.topic === printTopic &&
247248
(event.contract_event.contract_identifier === BnsContractIdentifier.mainnet ||
248249
event.contract_event.contract_identifier === BnsContractIdentifier.testnet)
@@ -255,6 +256,7 @@ export function parseNameRenewalWithNoZonefileHashFromContractCall(
255256
): DbBnsName | undefined {
256257
const payload = tx.parsed_tx.payload;
257258
if (
259+
tx.core_tx.status === 'success' &&
258260
payload.type_id === TxPayloadTypeID.ContractCall &&
259261
payload.function_name === 'name-renewal' &&
260262
getBnsContractID(chainId) === `${payload.address}.${payload.contract_name}` &&
@@ -292,7 +294,7 @@ export function parseNameFromContractEvent(
292294
blockHeight: number,
293295
chainId: ChainID
294296
): DbBnsName | undefined {
295-
if (!isEventFromBnsContract(event)) {
297+
if (tx.core_tx.status !== 'success' || !isEventFromBnsContract(event)) {
296298
return;
297299
}
298300
let attachment: Attachment;
@@ -338,7 +340,7 @@ export function parseNamespaceFromContractEvent(
338340
tx: CoreNodeParsedTxMessage,
339341
blockHeight: number
340342
): DbBnsNamespace | undefined {
341-
if (!isEventFromBnsContract(event)) {
343+
if (tx.core_tx.status !== 'success' || !isEventFromBnsContract(event)) {
342344
return;
343345
}
344346
// Look for a `namespace-ready` BNS print event.

0 commit comments

Comments
 (0)