fix: missing txs from address/transactions endpoint #1119 #1098

Author: zone117x

src/datastore/postgres-store.ts

@@ -1706,6 +1706,10 @@ export class PgDataStore
       );
     }
 
+    // TODO: [bug] This is can end up with incorrect canonical state due to missing the `index_block_hash` column
+    // which is required for the way micro-reorgs are handled. Queries against this table can work around the
+    // bug by using the `txs` table canonical state in the JOIN condition.
+
     // Update `principal_stx_txs`
     await client.query(
       `UPDATE principal_stx_txs
@@ -5540,15 +5544,17 @@ export class PgDataStore
         WITH stx_txs AS (
           SELECT tx_id, ${countOverColumn()}
           FROM principal_stx_txs
-          WHERE principal = $1 AND ${blockCond} AND canonical = TRUE AND microblock_canonical = TRUE
+          WHERE principal = $1 AND ${blockCond}
           ORDER BY block_height DESC, microblock_sequence DESC, tx_index DESC
           LIMIT $2
           OFFSET $3
         )
         SELECT ${txColumns()}, ${abiColumn()}, count
         FROM stx_txs
-        INNER JOIN txs USING (tx_id)
-        WHERE canonical = TRUE AND microblock_canonical = TRUE
+        INNER JOIN txs
+          ON stx_txs.tx_id = txs.tx_id
+          AND txs.canonical = TRUE
+          AND txs.microblock_canonical = TRUE
         `,
         [args.stxAddress, args.limit, args.offset, args.blockHeight]
       );