fix: typos and add check signer in parse test

Author: Faizan Dastgir

src/api/routes/rosetta/construction.ts

@@ -26,7 +26,7 @@ import {
   bitcoinAddressToSTXAddress,
   getOperations,
   getOptionsFromOperations,
-  getSingers,
+  getSigners,
   isDecimalsSupported,
   isSignedTransaction,
   isSymbolSupported,
@@ -249,18 +249,18 @@ export function createRosettaConstructionRouter(db: DataStore): RouterWithAsync
       return;
     }
     const inputTx = req.body.transaction;
-    const singed = req.body.signed;
+    const signed = req.body.signed;
     const transaction = rawTxToStacksTransaction(inputTx);
     const checkSigned = isSignedTransaction(transaction);
-    if (singed != checkSigned) {
+    if (signed != checkSigned) {
       res.status(400).json(RosettaErrors.invalidParams);
       return;
     }
     const operations = getOperations(rawTxToBaseTx(inputTx));
-    if (singed) {
+    if (signed) {
       res.json({
         operations: operations,
-        account_identifier_signers: getSingers(transaction),
+        account_identifier_signers: getSigners(transaction),
       });
     } else {
       res.json({

src/rosetta-helpers.ts

@@ -359,7 +359,7 @@ export function rawTxToBaseTx(raw_tx: string): BaseTx {
   return dbtx;
 }
 
-export function getSingers(transaction: StacksTransaction): RosettaAccountIdentifier[] | undefined {
+export function getSigners(transaction: StacksTransaction): RosettaAccountIdentifier[] | undefined {
   let address;
   if (transaction.payload.payloadType == PayloadType.TokenTransfer) {
     address = transaction.payload.recipient.address;
@@ -373,25 +373,25 @@ export function getSingers(transaction: StacksTransaction): RosettaAccountIdenti
   const account_identifier_signers: RosettaAccountIdentifier[] = [];
   if (transaction.auth.authType == AuthType.Standard) {
     if (transaction.auth.spendingCondition) {
-      const singer = {
+      const signer = {
         address: addressToString({
           version: version,
           hash160: transaction.auth.spendingCondition.signer,
           type: type,
         }),
       };
-      account_identifier_signers.push(singer);
+      account_identifier_signers.push(signer);
     }
   } else if (transaction.auth.authType == AuthType.Sponsored) {
     if (transaction.auth.spendingCondition) {
-      const singer = {
+      const signer = {
         address: addressToString({
           version: version,
           hash160: transaction.auth.spendingCondition.signer,
           type: type,
         }),
       };
-      account_identifier_signers.push(singer);
+      account_identifier_signers.push(signer);
     }
     if (transaction.auth.sponsorSpendingCondition) {
       const sponsored = {

src/tests-rosetta/api.ts

@@ -967,6 +967,8 @@ describe('Rosetta API', () => {
     // test recipient
     expect(actual.operations[2].account?.address).toEqual(recipientAddr);
     expect(actual.operations[2].amount?.value).toEqual(amount.toString());
+    // test signer
+    expect(actual.account_identifier_signers?.[0].address).toEqual(senderAddr);
   });
 
   test('construction/parse - unsigned', async () => {