fix: include index_block_hash in /block (#1253)

* fix: add index_block_hash to block responses

* chore: undo launch changes

* test: index_block_hash in /block

Author: rafaelcr

docs/entities/blocks/block.example.json

@@ -2,6 +2,7 @@
   "canonical": true,
   "height": 3275,
   "hash": "0xe77ba8cf6bb7c0e4f64adc83356289ed467d31a22354907b4bb814590058430f",
+  "index_block_hash": "0x918697ef63f9d8bdf844c3312b299e72a231cde542f3173f7755bb8c1cdaf3a7",
   "parent_block_hash": "0x75ab21ef25cbff2caa14c27d830ed7886a4d1522e1b6f9e5dc3b59ccf73ed49f",
   "burn_block_time": 1594233639,
   "burn_block_time_iso": "2020-08-27T16:41:26.000Z",

docs/entities/blocks/block.schema.json

@@ -7,6 +7,7 @@
     "canonical",
     "height",
     "hash",
+    "index_block_hash",
     "parent_block_hash",
     "txs",
     "burn_block_time",
@@ -37,6 +38,10 @@
       "type": "string",
       "description": "Hash representing the block"
     },
+    "index_block_hash": {
+      "type": "string",
+      "description": "The only hash that can uniquely identify an anchored block or an unconfirmed state trie"
+    },
     "parent_block_hash": {
       "type": "string",
       "description": "Hash of the parent block"

docs/generated.d.ts

@@ -1112,6 +1112,10 @@ export interface Block {
    * Hash representing the block
    */
   hash: string;
+  /**
+   * The only hash that can uniquely identify an anchored block or an unconfirmed state trie
+   */
+  index_block_hash: string;
   /**
    * Hash of the parent block
    */

src/api/controllers/db-controller.ts

@@ -464,6 +464,7 @@ function parseDbBlock(
     canonical: dbBlock.canonical,
     height: dbBlock.block_height,
     hash: dbBlock.block_hash,
+    index_block_hash: dbBlock.index_block_hash,
     parent_block_hash: dbBlock.parent_block_hash,
     burn_block_time: dbBlock.burn_block_time,
     burn_block_time_iso: unixEpochToIso(dbBlock.burn_block_time),

src/tests/api-tests.ts

@@ -2330,6 +2330,7 @@ describe('api tests', () => {
       execution_cost_write_count: 0,
       execution_cost_write_length: 0,
       hash: '0x1234000000000000000000000000000000000000000000000000000000000000',
+      index_block_hash: '0xdeadbeef',
       height: 1,
       microblocks_accepted: [],
       microblocks_streamed: [],
@@ -7269,6 +7270,7 @@ describe('api tests', () => {
       canonical: true,
       hash: '0x1234',
       height: 1235,
+      index_block_hash: '0xdeadbeef',
       parent_block_hash: '0xff0011',
       parent_microblock_hash: '',
       parent_microblock_sequence: 0,
@@ -7390,6 +7392,7 @@ describe('api tests', () => {
       execution_cost_write_count: 0,
       execution_cost_write_length: 0,
       hash: '0x0001',
+      index_block_hash: '0x0001',
       height: 1,
       microblocks_accepted: [],
       microblocks_streamed: [
@@ -7438,6 +7441,7 @@ describe('api tests', () => {
       execution_cost_write_count: 0,
       execution_cost_write_length: 0,
       hash: '0x0002',
+      index_block_hash: '0x0002',
       height: 2,
       microblocks_accepted: [microblock1.microblocks[0].microblock_hash],
       microblocks_streamed: [],
@@ -9399,7 +9403,8 @@ describe('api tests', () => {
     // fetch all blocks
     const result1 = await supertest(api.server).get(`/extended/v1/block`);
     expect(result1.body.total).toBe(1);
-    expect(result1.body.results[0].hash).toBe(tx.tx_id);
+    expect(result1.body.results[0].hash).toBe('0x1234');
+    expect(result1.body.results[0].index_block_hash).toBe('0xdeadbeef');
   });
 
   test('fetch transactions from block', async () => {

src/tests/cache-control-tests.ts

@@ -155,6 +155,7 @@ describe('cache-control tests', () => {
       miner_txid: '0x4321',
       canonical: true,
       hash: '0x1234',
+      index_block_hash: '0xdeadbeef',
       height: 1,
       parent_block_hash: '0xff0011',
       parent_microblock_hash: '',
@@ -298,6 +299,7 @@ describe('cache-control tests', () => {
       miner_txid: '0x4321',
       canonical: true,
       hash: '0x1234',
+      index_block_hash: '0xdeadbeef',
       height: 1,
       parent_block_hash: '0xff0011',
       parent_microblock_hash: '',