refactor: improve publicKeyToBitcoinAddress

Author: asimm241

src/api/routes/rosetta/construction.ts

@@ -30,6 +30,10 @@ export function createRosettaConstructionRouter(db: DataStore): RouterWithAsync
 
     try {
       const btcAddress = publicKeyToBitcoinAddress(publicKey.hex_bytes, network.network);
+      if (btcAddress === undefined) {
+        res.status(400).json(RosettaErrors.invalidPublicKey);
+        return;
+      }
       const stxAddress = bitcoinAddressToSTXAddress(btcAddress);
 
       const response: RosettaConstructionDeriveResponse = {

src/rosetta-helpers.ts

@@ -174,7 +174,7 @@ function makePoisonMicroblockOperation(tx: DbMempoolTx | DbTx, index: number): R
   return sender;
 }
 
-export function publicKeyToBitcoinAddress(publicKey: string, network: string): string {
+export function publicKeyToBitcoinAddress(publicKey: string, network: string): string | undefined {
   const publicKeyBuffer = Buffer.from(publicKey, 'hex');
 
   let btcNetwork: btc.Network;
@@ -188,7 +188,7 @@ export function publicKeyToBitcoinAddress(publicKey: string, network: string): s
     pubkey: publicKeyBuffer,
     network: btcNetwork,
   });
-  return address.address ? address.address : '';
+  return address.address;
 }
 
 export function bitcoinAddressToSTXAddress(btcAddress: string): string {