Skip to content

Commit 34b7696

Browse files
authored
Merge pull request #1252
* fix(37047): fix bug in opening the drawer * fix(37047): fix navigation route * test(37047): fix tests * chore(37047): trigger ci
1 parent 3c082d4 commit 34b7696

File tree

6 files changed

+10
-5
lines changed

6 files changed

+10
-5
lines changed

.github/workflows/trigger.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
just for that one then
1+
ok, this one too

hivemq-edge-frontend/src/modules/Workspace/components/controls/ConfigurationPanelController.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,11 @@ const ConfigurationPanelController: FC<ConfigurationPanelControllerProps> = ({ t
7575
onOpen()
7676
}, [nodes.length, onOpen, selectedNode])
7777

78+
useEffect(() => {
79+
if (!nodes.length || !selectedEdge) return
80+
onOpen()
81+
}, [nodes.length, onOpen, selectedEdge])
82+
7883
const handleClose = () => {
7984
onClose()
8085
navigate('/workspace')

hivemq-edge-frontend/src/modules/Workspace/components/edges/DynamicEdge.spec.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ describe('MonitoringEdge', () => {
5656
cy.getByTestId('observability-panel-trigger').should('have.attr', 'aria-label', 'Open the Observability panel')
5757
cy.getByTestId('test-navigate-pathname').should('have.text', '/')
5858
cy.getByTestId('observability-panel-trigger').click()
59-
cy.getByTestId('test-navigate-pathname').should('have.text', `/workspace/link/${MOCK_EDGE_ID}`)
59+
cy.getByTestId('test-navigate-pathname').should('have.text', `/workspace/connector/${MOCK_EDGE_ID}`)
6060
})
6161

6262
it('should be accessible', () => {

hivemq-edge-frontend/src/modules/Workspace/components/edges/DynamicEdge.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export const DynamicEdge: FC<EdgeProps> = ({ id, source, target, markerEnd, styl
3838
}, [policies])
3939

4040
const handleOpenObservability = () => {
41-
navigate(`/workspace/link/${id}`)
41+
navigate(`/workspace/connector/${id}`)
4242
}
4343

4444
const handleShowPolicy = (route: string) => {

hivemq-edge-frontend/src/modules/Workspace/components/edges/MonitoringEdge.spec.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ describe('MonitoringEdge', () => {
5555
cy.getByTestId('observability-panel-trigger').should('have.attr', 'aria-label', 'Open the Observability panel')
5656
cy.getByTestId('test-navigate-pathname').should('have.text', '/')
5757
cy.getByTestId('observability-panel-trigger').click()
58-
cy.getByTestId('test-navigate-pathname').should('have.text', `/workspace/link/${MOCK_EDGE_ID}`)
58+
cy.getByTestId('test-navigate-pathname').should('have.text', `/workspace/connector/${MOCK_EDGE_ID}`)
5959
})
6060

6161
it('should be accessible', () => {

hivemq-edge-frontend/src/modules/Workspace/components/edges/MonitoringEdge.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const MonitoringEdge: FC<EdgeProps> = (props) => {
3131
}, [policies])
3232

3333
const handleOpenObservability = () => {
34-
navigate(`/workspace/link/${id}`)
34+
navigate(`/workspace/connector/${id}`)
3535
}
3636

3737
const handleShowPolicy = (route: string) => {

0 commit comments

Comments
 (0)