Merge pull request #1004

* fix(29953): fix bug with missing arguments

* fix(29953): fix bug with missing arguments

* refactor(29953): refactor the function fetcher

* test(29953): add tests

* refactor(29953): refactor policy validation to incorporate content va…

* fix(29953): fix bug with definition of the DataHub.transform function

* fix(29953): fix bug with filtering

* test(29953): fix test

* refactor(29953): refactor the mapping of schema validation

* refactor(29953): refactor the functions fetch

* test(29953): fix tests

* test(29953): fix tests

* test(29953): add tests

* fix(29953): linting

* chore(29953): add sonarjs linting rules

* test(29953): add tests

Author: vanch3d

hivemq-edge-frontend/eslint.config.mjs

@@ -7,6 +7,7 @@ import tsEslint from 'typescript-eslint'
 import eslintConfigPrettier from 'eslint-config-prettier'
 import pluginCypress from 'eslint-plugin-cypress/flat'
 import pluginQuery from '@tanstack/eslint-plugin-query'
+import sonarjs from 'eslint-plugin-sonarjs'
 
 export default tsEslint.config(
   { ignores: ['dist', '**/__generated__/*'] },
@@ -29,6 +30,7 @@ export default tsEslint.config(
       'react-hooks': reactHooks,
       'react-refresh': reactRefresh,
       cypress: pluginCypress,
+      sonarjs,
     },
     rules: {
       ...reactHooks.configs.recommended.rules,
@@ -51,6 +53,24 @@ export default tsEslint.config(
       'cypress/no-unnecessary-waiting': 'error',
       '@typescript-eslint/consistent-type-imports': 'error',
       'react/jsx-curly-brace-presence': ['error', { props: 'never', children: 'never' }],
+      // temporary sonarQube rules
+      'sonarjs/todo-tag': 'off',
+      'sonarjs/no-all-duplicated-branches': 'off',
+      'sonarjs/no-duplicate-in-composite': 'off',
+      'sonarjs/no-duplicate-string': 'off',
+      'sonarjs/no-duplicated-branches': 'off',
+      // 'sonarjs/no-ignored-exceptions': 'off',
+      // 'sonarjs/no-commented-code': 'off',
+      // 'sonarjs/no-nested-functions': 'off',
+      // 'sonarjs/cognitive-complexity': 'warn',
+      // 'sonarjs/no-small-switch': 'warn',
+      // 'sonarjs/no-nested-conditional': 'warn',
+    },
+  },
+  {
+    files: ['**/*.spec.cy.tsx'],
+    rules: {
+      'sonarjs/no-duplicate-string': 'off',
     },
   }
 )

hivemq-edge-frontend/package.json

@@ -152,6 +152,7 @@
     "eslint-plugin-react": "7.37.5",
     "eslint-plugin-react-hooks": "5.2.0",
     "eslint-plugin-react-refresh": "0.4.20",
+    "eslint-plugin-sonarjs": "^3.0.2",
     "fs-extra": "11.3.0",
     "globals": "16.1.0",
     "i18next-pseudo": "2.2.1",
@@ -165,7 +166,7 @@
     "stylelint-config-standard-scss": "14.0.0",
     "typescript": "5.7.3",
     "typescript-eslint": "8.32.1",
-    "vite": "6.2.5",
+    "vite": "6.2.7",
     "vite-plugin-istanbul": "6.0.2",
     "vitest": "3.1.1"
   },

hivemq-edge-frontend/pnpm-lock.yaml

@@ -26,6 +26,8 @@ import { styleDefaultEdge } from '@/extensions/datahub/utils/edge.utils.ts'
 import { MOCK_DEFAULT_NODE } from '@/__test-utils__/react-flow/nodes.ts'
 import { MockChecksStoreWrapper, MockStoreWrapper } from '@datahub/__test-utils__/MockStoreWrapper.tsx'
 
+const MOCK_POLICY_ID = 'my-policy-id'
+
 export const MOCK_INITIAL_POLICY = () => {
   const baseNode: Node<{ label: string }> = {
     id: '0',
@@ -49,7 +51,7 @@ export const MOCK_INITIAL_POLICY = () => {
 
   const dataPolicyNode: Node<DataPolicyData> = {
     id: '3',
-    data: { id: 'my-policy-id' },
+    data: { id: MOCK_POLICY_ID },
     type: DataHubNodeType.DATA_POLICY,
     position: { x: 345, y: 105 },
   }
@@ -87,7 +89,7 @@ export const MOCK_INITIAL_POLICY = () => {
 
   const behaviorPolicyNode: Node<BehaviorPolicyData> = {
     id: '7',
-    data: { id: 'my-policy-id', model: BehaviorPolicyType.MQTT_EVENT },
+    data: { id: MOCK_POLICY_ID, model: BehaviorPolicyType.MQTT_EVENT },
     type: DataHubNodeType.BEHAVIOR_POLICY,
     position: { x: 345, y: 195 },
   }
@@ -176,7 +178,7 @@ export const MOCK_INITIAL_POLICY = () => {
 export const MOCK_NODE_DATA_POLICY: Node<DataPolicyData> = {
   id: 'node-id',
   type: DataHubNodeType.DATA_POLICY,
-  data: { id: 'my-policy-id' },
+  data: { id: MOCK_POLICY_ID },
   ...MOCK_DEFAULT_NODE,
   position: { x: 0, y: 0 },
 }