Merge pull request #597 from hivemq/fix/validate-incoming-update

codepitbull · web-flow · commit 49196cfcfab9 · 2024-10-16T15:12:30.000+02:00
Fix/validate incoming update
diff --git a/hivemq-edge/src/main/java/com/hivemq/api/resources/impl/ProtocolAdaptersResourceImpl.java b/hivemq-edge/src/main/java/com/hivemq/api/resources/impl/ProtocolAdaptersResourceImpl.java
@@ -266,6 +266,11 @@ public int getDepth() {
         if (instance.isEmpty()) {
             return ApiErrorUtils.notFound("Cannot update an adapter that does not exist");
         }
+        ApiErrorMessages errorMessages = ApiErrorUtils.createErrorContainer();
+        validateAdapterSchema(errorMessages, adapter);
+        if (ApiErrorUtils.hasRequestErrors(errorMessages)) {
+            return ApiErrorUtils.badRequest(errorMessages);
+        }
         if (logger.isDebugEnabled()) {
             logger.debug("Updating adapter \"{}\".", adapterId);
         }

Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,11 @@ public int getDepth() {`
`266`	`266`	`if (instance.isEmpty()) {`
`267`	`267`	`return ApiErrorUtils.notFound("Cannot update an adapter that does not exist");`
`268`	`268`	`}`
	`269`	`+ ApiErrorMessages errorMessages = ApiErrorUtils.createErrorContainer();`
	`270`	`+ validateAdapterSchema(errorMessages, adapter);`
	`271`	`+ if (ApiErrorUtils.hasRequestErrors(errorMessages)) {`
	`272`	`+ return ApiErrorUtils.badRequest(errorMessages);`
	`273`	`+ }`
`269`	`274`	`if (logger.isDebugEnabled()) {`
`270`	`275`	`logger.debug("Updating adapter \"{}\".", adapterId);`
`271`	`276`	`}`