fix(37027): Improve code quality (#1210)

* fix(37009): Prefer `Number.parseInt` over `parseInt`

* fix(37009): Use `new Array()` instead of `Array()`.

* fix(37009): Provide a compare function to avoid sorting elements alphabetically.

* fix(37009): Use `new Error()` instead of `Error()`.

* fix(37009): Prefer `Number.isNaN` over `isNaN`.

* fix(37009): Prefer `String#replaceAll()` over `String#replace()`.

* fix(37009): Correct one of the identical sub-expressions on both sides of operator "&&"

* fix(37009): A fragment with only one child is redundant.

* fix(37009): Consider removing 'undefined' type or '?' specifier, one of them is redundant.

* fix(37009): Use `export…from` to re-export

* fix(37009): Prefer using an optional chain expression instead, as it's more concise and easier to read

* chore(37009): try fixing the CI check

* chore(37009): try fixing the CI check

* chore(37009): try fixing the CI check (2)

* chore(37009): try fixing the CI check (3)

* chore(37009): try fixing the CI check (4)

* chore(37009): try fixing the CI check (4)

* chore(37009): try fixing the CI check (4)

* chore(37009): cypress summary

* Revert "chore(37009): cypress summary"

This reverts commit bc81fb9.

* fix(37009): fix condition

* test(37009): add tests

Author: vanch3d

.github/workflows/check.yml

@@ -56,6 +56,11 @@ jobs:
               - 'hivemq-edge-openapi/**'
               - '.github/**'
 
+      - name: Debug openapi-changed output
+        run: |
+          echo "openapi-changed: ${{ steps.frontend.outputs.changed }}"
+
+
   check-openapi:
     needs: check-for-changes
     uses: ./.github/workflows/check-openapi.yml

hivemq-edge-frontend/cypress/utils/datahub.utils.ts

@@ -45,8 +45,8 @@ export const cy_checkDataPolicyGraph = () => {
 
       const areArraysIdentical = (a: string[], b: string[]): boolean => {
         if (a.length !== b.length) return false
-        const sortedA = [...a].sort()
-        const sortedB = [...b].sort()
+        const sortedA = [...a].sort((a, b) => a.localeCompare(b))
+        const sortedB = [...b].sort((a, b) => a.localeCompare(b))
         return sortedA.every((val, idx) => val === sortedB[idx])
       }
 

hivemq-edge-frontend/src/__test-utils__/color.ts

@@ -10,9 +10,9 @@ export const hexToRgb = (hex: string, asString = false) => {
   const result = /^#?([a-f\d]{2})([a-f\d]{2})([a-f\d]{2})$/i.exec(hex)
   const format = result
     ? {
-        r: parseInt(result[1], 16),
-        g: parseInt(result[2], 16),
-        b: parseInt(result[3], 16),
+        r: Number.parseInt(result[1], 16),
+        g: Number.parseInt(result[2], 16),
+        b: Number.parseInt(result[3], 16),
       }
     : null
   if (!format) return null

hivemq-edge-frontend/src/__test-utils__/rjsf/rjsf.mocks.tsx

@@ -12,7 +12,7 @@ import { ArrayFieldItemTemplate } from '@/components/rjsf/ArrayFieldItemTemplate
 
 interface RjsfMocksProps {
   schema: RJSFSchema
-  uiSchema?: UiSchema | undefined
+  uiSchema?: UiSchema
   onSubmit?: (data: IChangeEvent, event: FormEvent) => void
   onError?: (errors: RJSFValidationError[]) => void
   formData?: unknown

hivemq-edge-frontend/src/api/hooks/useEvents/__handlers__/index.ts

@@ -43,7 +43,7 @@ const contentType = [
 ]
 
 export const mockEdgeEvent = (n = maxEvents): Event[] =>
-  Array.from(Array(n), (_, x) => ({
+  Array.from(new Array(n), (_, x) => ({
     identifier: makeID(TypeIdentifier.type.EVENT, x),
 
     severity: severityKeys[x % severityKeys.length] as Event.severity,

hivemq-edge-frontend/src/api/hooks/useGetMetrics/__handlers__/index.ts

@@ -66,7 +66,7 @@ export const MOCK_METRIC_SAMPLE: DataPoint = {
   value: 50000,
 }
 
-export const MOCK_METRIC_SAMPLE_ARRAY: DataPoint[] = Array.from(Array(10), (_, x) => ({
+export const MOCK_METRIC_SAMPLE_ARRAY: DataPoint[] = Array.from(new Array(10), (_, x) => ({
   sampleTime: DateTime.fromISO(MOCK_METRIC_SAMPLE.sampleTime as string)
     .plus({ hour: x })
     .toISO(),

hivemq-edge-frontend/src/components/Icons/index.ts

@@ -1,13 +1,4 @@
-import { TbArrowsJoin, TbArrowsShuffle } from 'react-icons/tb'
-import { MdOutlineCloudDone, MdOutlineCloudOff } from 'react-icons/md'
-import { WorkspaceIcon } from './TopicIcon.tsx'
-import { PulseAgentIcon } from './PulseAgentIcon.tsx'
-
-export {
-  TbArrowsJoin as HqCombiner,
-  TbArrowsShuffle as HqAssets,
-  MdOutlineCloudDone as HqPulseActivated,
-  MdOutlineCloudOff as HqPulseNotActivated,
-  WorkspaceIcon,
-  PulseAgentIcon,
-}
+export { TbArrowsJoin as HqCombiner, TbArrowsShuffle as HqAssets } from 'react-icons/tb'
+export { MdOutlineCloudDone as HqPulseActivated, MdOutlineCloudOff as HqPulseNotActivated } from 'react-icons/md'
+export { WorkspaceIcon } from './TopicIcon.tsx'
+export { PulseAgentIcon } from './PulseAgentIcon.tsx'

hivemq-edge-frontend/src/components/PaginatedTable/PaginatedTable.spec.cy.tsx

@@ -20,7 +20,7 @@ const MOCK_COLUMN: ColumnDef<MOCK_TYPE>[] = [
 ]
 
 const MOCK_DATA = (n: number): MOCK_TYPE[] =>
-  Array.from(Array(n), (_, x) => ({
+  Array.from(new Array(n), (_, x) => ({
     column1: `item ${x}`,
     column2: n - x,
   }))

hivemq-edge-frontend/src/components/WarningMessage.tsx

@@ -4,7 +4,7 @@ import DefaultLogo from '@/assets/app/bridge-empty.svg'
 
 interface WarningMessageProps extends HTMLChakraProps<'div'> {
   title?: string
-  image?: string | undefined
+  image?: string
   prompt: string
   alt: string
 }

hivemq-edge-frontend/src/components/rjsf/ArrayFieldItemTemplate.tsx

@@ -58,7 +58,6 @@ export const ArrayFieldItemTemplate: FC<ArrayFieldTemplateItemType> = (props) =>
 
   const { isOpen, onToggle, getButtonProps, getDisclosureProps, onOpen } = useDisclosure({
     defaultIsOpen:
-      !collapsableItems ||
       !collapsableItems?.titleKey ||
       (index === props.totalItems - 1 && children.props.formData[collapsableItems?.titleKey] === undefined),
   })