More finegrained configuration and handling of TLS and reconnection features. #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepitbull
force-pushed
the
feature/disable-cert-validation
branch
from
7146b85 to
a22f84d
Compare
caoccao
requested changes
Nov 4, 2025
hivemq-edge/src/main/java/com/hivemq/protocols/ProtocolAdapterManager.java
Outdated
Show resolved
Hide resolved
...mq-edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/OpcUaClientConnection.java
Show resolved
Hide resolved
...mq-edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/OpcUaClientConnection.java
Show resolved
Hide resolved
...mq-edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/OpcUaClientConnection.java
Show resolved
Hide resolved
codepitbull
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the OPC UA adapter with configurable connection timeouts, automatic reconnection, health monitoring, and TLS certificate validation controls. The changes improve connection reliability and provide better control over certificate validation behavior.
- Added
ConnectionOptionsfor configurable timeouts (session, request, keep-alive, connection, health check, retry) and automatic reconnection - Introduced
TlsChecksenum to control certificate validation levels (NONE, STANDARD, ALL) - Implemented health monitoring with automatic reconnection on connection failures
- Added connection retry logic with configurable intervals
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| ConnectionOptions.java | New configuration class for connection timeout and retry settings |
| TlsChecks.java | New enum defining certificate validation levels |
| Tls.java | Added tlsChecks field and default factory method |
| OpcUaSpecificAdapterConfig.java | Added connectionOptions field and updated defaults |
| BidirectionalOpcUaSpecificAdapterConfig.java | Updated constructor to pass connectionOptions |
| OpcUaProtocolAdapter.java | Implemented health monitoring, reconnection logic, and retry scheduling |
| OpcUaClientConnection.java | Added connection timeout and health check functionality |
| OpcUaClientConfigurator.java | Applied timeout configurations from ConnectionOptions |
| ParsedConfig.java | Added TLS validation check selection based on TlsChecks |
| OpcUaSubscriptionLifecycleHandler.java | Added keep-alive health monitoring |
| Test files | Updated to accommodate new constructor parameters and configuration fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/config/ConnectionOptions.java
Outdated
Show resolved
Hide resolved
...edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/config/ConnectionOptions.java
Outdated
Show resolved
Hide resolved
...edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/config/ConnectionOptions.java
Outdated
Show resolved
Hide resolved
...edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/config/ConnectionOptions.java
Outdated
Show resolved
Hide resolved
...edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/config/ConnectionOptions.java
Outdated
Show resolved
Hide resolved
modules/hivemq-edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/config/Tls.java
Outdated
Show resolved
Hide resolved
...emq-edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/OpcUaProtocolAdapter.java
Outdated
Show resolved
Hide resolved
hivemq-edge/src/main/java/com/hivemq/protocols/ProtocolAdapterManager.java
Outdated
Show resolved
Hide resolved
hivemq-edge/src/main/java/com/hivemq/embedded/internal/EmbeddedHiveMQImpl.java
Show resolved
Hide resolved
...emq-edge-module-opcua/src/main/java/com/hivemq/edge/adapters/opcua/OpcUaProtocolAdapter.java
Outdated
Show resolved
Hide resolved
…/adapters/opcua/config/ConnectionOptions.java Co-authored-by: Copilot <[email protected]>
…/adapters/opcua/config/TlsChecks.java Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #37845 and #37976
Changes