Cleaned up code

Author: SgtSilvio

src/main/java/com/hivemq/client/internal/mqtt/codec/decoder/mqtt3/Mqtt3SubAckDecoder.java

@@ -61,7 +61,7 @@ public class Mqtt3SubAckDecoder implements MqttMessageDecoder {
         final int packetIdentifier = in.readUnsignedShort();
 
         final int returnCodeCount = in.readableBytes();
-        final ImmutableList.Builder<Mqtt3SubAckReturnCode> returnCodesBuilder = ImmutableList.builder();
+        final ImmutableList.Builder<Mqtt3SubAckReturnCode> returnCodesBuilder = ImmutableList.builder(returnCodeCount);
         for (int i = 0; i < returnCodeCount; i++) {
             final Mqtt3SubAckReturnCode returnCode = Mqtt3SubAckReturnCode.fromCode(in.readUnsignedByte());
             if (returnCode == null) {

src/main/java/com/hivemq/client/internal/mqtt/datatypes/MqttBinaryData.java

@@ -34,17 +34,15 @@ public class MqttBinaryData {
     public static final int MAX_LENGTH = 65_535;
     public static final int EMPTY_LENGTH = 2;
 
-    private MqttBinaryData() {
-    }
+    private MqttBinaryData() {}
 
     /**
      * Decodes binary data from the given byte buffer at the current reader index.
      *
      * @param byteBuf the byte buffer to decode from.
      * @return the decoded binary data or null if there are not enough bytes in the byte buffer.
      */
-    @Nullable
-    public static byte[] decode(final @NotNull ByteBuf byteBuf) {
+    public static @Nullable byte[] decode(final @NotNull ByteBuf byteBuf) {
         if (byteBuf.readableBytes() < 2) {
             return null;
         }
@@ -64,8 +62,7 @@ public static byte[] decode(final @NotNull ByteBuf byteBuf) {
      * @param direct  whether the created byte buffer should be direct.
      * @return the decoded binary data or null if there are not enough bytes in the byte buffer.
      */
-    @Nullable
-    public static ByteBuffer decode(final @NotNull ByteBuf byteBuf, final boolean direct) {
+    public static @Nullable ByteBuffer decode(final @NotNull ByteBuf byteBuf, final boolean direct) {
         if (byteBuf.readableBytes() < 2) {
             return null;
         }
@@ -157,5 +154,4 @@ public static int encodedLength(final @NotNull byte[] binary) {
     public static int encodedLength(final @NotNull ByteBuffer byteBuffer) {
         return 2 + byteBuffer.remaining();
     }
-
 }

src/main/java/com/hivemq/client/internal/mqtt/datatypes/MqttVariableByteInteger.java

@@ -40,8 +40,7 @@ public class MqttVariableByteInteger {
     public static final int FOUR_BYTES_MAX_VALUE = (1 << (VALUE_BITS * 4)) - 1;
     public static final int MAXIMUM_PACKET_SIZE_LIMIT = 1 + 4 + FOUR_BYTES_MAX_VALUE;
 
-    private MqttVariableByteInteger() {
-    }
+    private MqttVariableByteInteger() {}
 
     /**
      * Decodes a variable byte integer from the given byte buffer at the current reader index.
@@ -129,5 +128,4 @@ public static int encodedLength(final int value) {
         }
         return length;
     }
-
 }

src/main/java/com/hivemq/client/internal/mqtt/handler/publish/outgoing/MqttPublishFlowables.java

@@ -41,8 +41,7 @@ public class MqttPublishFlowables extends Flowable<Flowable<MqttPublishWithFlow>
     private long requested;
 
     @Inject
-    MqttPublishFlowables() {
-    }
+    MqttPublishFlowables() {}
 
     @Override
     protected void subscribeActual(final @NotNull Subscriber<? super Flowable<MqttPublishWithFlow>> s) {

src/main/java/com/hivemq/client/internal/mqtt/handler/publish/outgoing/MqttTopicAliasAutoMapping.java

@@ -153,7 +153,7 @@ private void swapNewer(final @NotNull Entry entry, final long priority) {
         return s.toString();
     }
 
-    public static class Entry {
+    static class Entry {
 
         int topicAlias;
         long used; // number of accesses, decays over time

src/main/java/com/hivemq/client/internal/mqtt/message/disconnect/mqtt3/Mqtt3DisconnectView.java

@@ -40,10 +40,6 @@ public class Mqtt3DisconnectView implements Mqtt3Disconnect {
 
     private Mqtt3DisconnectView() {}
 
-    public @NotNull MqttDisconnect getDelegate() {
-        return DELEGATE;
-    }
-
     @Override
     public @NotNull String toString() {
         return "MqttDisconnect{}";

src/main/java/com/hivemq/client/internal/mqtt/message/subscribe/MqttSubscription.java

@@ -73,7 +73,7 @@ public boolean isRetainAsPublished() {
         return retainAsPublished;
     }
 
-    public @NotNull String toAttributeString() {
+    private @NotNull String toAttributeString() {
         return "topicFilter=" + topicFilter + ", qos=" + qos + ", noLocal=" + noLocal + ", retainHandling=" +
                 retainHandling + ", retainAsPublished=" + retainAsPublished;
     }

src/main/java/com/hivemq/client/internal/rx/RxFutureConverter.java

@@ -32,8 +32,7 @@
  */
 public class RxFutureConverter {
 
-    private RxFutureConverter() {
-    }
+    private RxFutureConverter() {}
 
     public static @NotNull CompletableFuture<Void> toFuture(final @NotNull Completable completable) {
         return new RxJavaCompletableFuture(completable);

src/main/java/com/hivemq/client/mqtt/mqtt5/message/subscribe/Mqtt5Subscription.java

@@ -51,7 +51,7 @@ public interface Mqtt5Subscription {
     boolean DEFAULT_RETAIN_AS_PUBLISHED = false;
 
     /**
-     * Creatse a builder for a Subscription.
+     * Creates a builder for a Subscription.
      *
      * @return the created builder.
      */