Skip to content
This repository was archived by the owner on Oct 3, 2020. It is now read-only.

Commit f4de06c

Browse files
authored
#47 use Background propagation policy (#54)
* #47 use Background propagation policy * update dependencies
1 parent 05414ed commit f4de06c

File tree

3 files changed

+109
-108
lines changed

3 files changed

+109
-108
lines changed

kube_janitor/janitor.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ def delete(resource, dry_run: bool):
147147
try:
148148
# force cascading delete also for older objects (e.g. extensions/v1beta1)
149149
# see https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#setting-the-cascading-deletion-policy
150-
resource.delete(propagation_policy="Foreground")
150+
# use "Background" instead of "Foreground" to fix CRD deletion, see https://github.com/hjacobs/kube-janitor/issues/47
151+
resource.delete(propagation_policy="Background")
151152
except Exception as e:
152153
logger.error(
153154
f"Could not delete {resource.kind} {resource.namespace}/{resource.name}: {e}"

0 commit comments

Comments
 (0)