chapter 3 black

hjwp · hjwp · commit 018475d9637c · 2023-03-13T18:00:38.000Z
diff --git a/chapter_unit_test_first_view.asciidoc b/chapter_unit_test_first_view.asciidoc
@@ -126,9 +126,9 @@ Does that seem slightly redundant? Sometimes it can feel that way, but
 functional tests and unit tests do really have very different objectives, and
 they will usually end up looking quite different.  
 
-NOTE: Functional tests should help you build an application with the right
-functionality, and guarantee you never accidentally break it.  Unit tests
-should help you to write code that's clean and bug free.
+NOTE: Functional tests should help you build an application with the right functionality,
+    and guarantee you never accidentally break it.
+    Unit tests should help you to write code that's clean and bug free.
 
 Enough theory for now—let's see how it looks in practice.
 
@@ -174,8 +174,8 @@ silly failing test:
 ----
 from django.test import TestCase
 
-class SmokeTest(TestCase):
 
+class SmokeTest(TestCase):
     def test_bad_maths(self):
         self.assertEqual(1 + 1, 3)
 ----
@@ -274,13 +274,13 @@ test to something like this:
 ----
 from django.urls import resolve
 from django.test import TestCase
-from lists.views import home_page  #<2>
+from lists.views import home_page  # <2>
 
-class HomePageTest(TestCase):
 
+class HomePageTest(TestCase):
     def test_root_url_resolves_to_home_page_view(self):
-        found = resolve('/')  #<1>
-        self.assertEqual(found.func, home_page)  #<1>
+        found = resolve("/")  # <1>
+        self.assertEqual(found.func, home_page)  # <1>
 ----
 ====
 
@@ -361,7 +361,7 @@ ERROR: test_root_url_resolves_to_home_page_view
 Traceback (most recent call last):
   File "...python-tdd-book/lists/tests.py", line 8, in
 test_root_url_resolves_to_home_page_view
-    found = resolve('/')
+    found = resolve("/")
             ^^^^^^^^^^^^
   File ".../django/urls/base.py", line 24, in resolve
     return get_resolver(urlconf).resolve(path)
@@ -396,7 +396,7 @@ ERROR: test_root_url_resolves_to_home_page_view
 Traceback (most recent call last):
   File "...python-tdd-book/lists/tests.py", line 8, in
 test_root_url_resolves_to_home_page_view
-    found = resolve('/')  <3>
+    found = resolve("/")  <3>
             ^^^^^^^^^^^^
   File ".../django/urls/base.py", line 24, in resolve
     return get_resolver(urlconf).resolve(path)
@@ -471,7 +471,7 @@ from django.contrib import admin
 from django.urls import path
 
 urlpatterns = [
-    path('admin/', admin.site.urls),
+    path("admin/", admin.site.urls),
 ]
 ----
 ====
@@ -513,7 +513,7 @@ from django.urls import path
 from lists import views
 
 urlpatterns = [
-    path('', views.home_page, name='home'),
+    path("", views.home_page, name="home"),
 ]
 ----
 ====
@@ -544,6 +544,7 @@ Back in 'lists/views.py':
 ----
 from django.shortcuts import render
 
+
 # Create your views here.
 def home_page():
     pass
@@ -610,25 +611,23 @@ with HTML to the browser. Open up 'lists/tests.py', and add a new
 ----
 from django.urls import resolve
 from django.test import TestCase
-from django.http import HttpRequest #<1>
+from django.http import HttpRequest  # <1>
 
 from lists.views import home_page
 
 
 class HomePageTest(TestCase):
-
     def test_root_url_resolves_to_home_page_view(self):
-        found = resolve('/')
+        found = resolve("/")
         self.assertEqual(found.func, home_page)
 
-
     def test_home_page_returns_correct_html(self):
-        request = HttpRequest()  #<1>
-        response = home_page(request)  #<2>
-        html = response.content.decode('utf8')  #<3>
-        self.assertTrue(html.startswith('<html>'))  #<4>
-        self.assertIn('<title>To-Do lists</title>', html)  #<5>
-        self.assertTrue(html.endswith('</html>'))  #<4>
+        request = HttpRequest()  # <1>
+        response = home_page(request)  # <2>
+        html = response.content.decode("utf8")  # <3>
+        self.assertTrue(html.startswith("<html>"))  # <4>
+        self.assertIn("<title>To-Do lists</title>", html)  # <5>
+        self.assertTrue(html.endswith("</html>"))  # <4>
 ----
 ====
 
@@ -666,8 +665,10 @@ The Unit-Test/Code Cycle
 ^^^^^^^^^^^^^^^^^^^^^^^^
 
 
-((("unit tests", "in Django", "unit-test/code cycle", secondary-sortas="Django")))((("unit-test/code cycle")))((("Test-Driven Development (TDD)", "concepts", "unit-test/code cycle")))We
-can start to settle into the TDD 'unit-test/code cycle' now:
+((("unit tests", "in Django", "unit-test/code cycle", secondary-sortas="Django")))
+((("unit-test/code cycle")))
+((("Test-Driven Development (TDD)", "concepts", "unit-test/code cycle")))
+We can start to settle into the TDD 'unit-test/code cycle' now:
 
 1. In the terminal, run the unit tests and see how they fail.
 2. In the editor, make a minimal code change to address the current test failure.
@@ -699,8 +700,10 @@ def home_page(request):
 * Tests:
 +
 ----
-html = response.content.decode('utf8')
+    html = response.content.decode("utf8")
+           ^^^^^^^^^^^^^^^^
 AttributeError: 'NoneType' object has no attribute 'content'
+
 ----
 
 * Code--we use `django.http.HttpResponse`, as predicted:
@@ -712,6 +715,7 @@ AttributeError: 'NoneType' object has no attribute 'content'
 ----
 from django.http import HttpResponse
 
+
 # Create your views here.
 def home_page(request):
     return HttpResponse()
@@ -721,7 +725,7 @@ def home_page(request):
 * Tests again:
 +
 ----
-    self.assertTrue(html.startswith('<html>'))
+    self.assertTrue(html.startswith("<html>"))
 AssertionError: False is not true
 ----
 
@@ -734,7 +738,7 @@ AssertionError: False is not true
 [source,python]
 ----
 def home_page(request):
-    return HttpResponse('<html>')
+    return HttpResponse("<html>")
 ----
 ====
 
@@ -752,14 +756,14 @@ AssertionError: '<title>To-Do lists</title>' not found in '<html>'
 [source,python]
 ----
 def home_page(request):
-    return HttpResponse('<html><title>To-Do lists</title>')
+    return HttpResponse("<html><title>To-Do lists</title>")
 ----
 ====
 
 * Tests--almost there?
 +
 ----
-    self.assertTrue(html.endswith('</html>'))
+    self.assertTrue(html.endswith("</html>"))
 AssertionError: False is not true
 ----
 
@@ -771,7 +775,7 @@ AssertionError: False is not true
 [source,python]
 ----
 def home_page(request):
-    return HttpResponse('<html><title>To-Do lists</title></html>')
+    return HttpResponse("<html><title>To-Do lists</title></html>")
 ----
 ====
 
@@ -807,7 +811,7 @@ FAIL: test_can_start_a_list_and_retrieve_it_later
 Traceback (most recent call last):
   File "...python-tdd-book/functional_tests.py", line 19, in
 test_can_start_a_list_and_retrieve_it_later
-    self.fail('Finish the test!')
+    self.fail("Finish the test!")
 AssertionError: Finish the test!
 
  ---------------------------------------------------------------------
diff --git a/source/chapter_unit_test_first_view/superlists b/source/chapter_unit_test_first_view/superlists
@@ -1 +1 @@
-Subproject commit 83787edd24ab226b04102baedbfeb6517eaf7e84
+Subproject commit d0a2f4e30214a6125afa4e293930f8f61d8f15c5
