Skip to content

Commit 034c370

Browse files
committed
suggest rewording the traceback of the failing FT
1 parent e221ffd commit 034c370

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

chapter_12_organising_test_files.asciidoc

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -628,18 +628,24 @@ FAILED (errors=1)
628628
The order of the traceback is a little confusing, but we can more or less follow
629629
through what happened:
630630

631-
<1> At line 15 in our FT, we go into our `self.wait_for` helper,
632-
passing it the `lambda`-ified version of the `assertEqual`.
631+
<1> In our FT, we call our `self.wait_for` helper, where we pass
632+
the `lambda`-ified version of `assertEqual`.
633633

634-
<2> We go into `self.wait_for` in _base.py_,
635-
where we can see that we're inside `fn()`,
636-
which is the name for our lambda inside the helper.
634+
<2> We go into `self.wait_for` in `base.py`,
635+
where we're calling (and returning) `fn()`, which refers to the passed
636+
lambda function encapsulating our test assertion.
637637

638638
<3> To explain where the exception has actually come from,
639639
the traceback takes us back into _test_list_item_validation.py_
640640
and inside the body of the `lambda` function,
641641
and tells us that the attempt to find the `.invalid-feedback` element
642642
that failed.
643+
// CSANAD: I changed two things here:
644+
// First, I think it's better to remove the specific line number which may
645+
// vary due to personal formatting preferences (and following the pep8 puts
646+
// this on line 16 for me)
647+
// Secondly, we say we go into self.wait_for in step#2. Here, in step#1 we
648+
// are only calling it. Overall, I tried making it clearer a bit.
643649

644650

645651
((("functional programming")))

0 commit comments

Comments
 (0)