Skip to content

Commit 03d4b27

Browse files
committed
Review of chapter 11
1 parent 7f7807a commit 03d4b27

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

chapter_11_ansible.asciidoc

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,14 @@ We _could_ do all these things manually,
1717
but a key insight of the modern infrastructure management
1818
is that automation really pays off in reducing maintenance burdens.
1919

20+
// SEBASTIAN: IMO, above statement is not strong enough (my opinion)
21+
// I'd add something that software development nowadays is made in short cycles with frequent deployments
22+
// and automation is a MUST - the earlier one invests into it, the faster they can focus on doing what's
23+
// actually giving value.
24+
//
25+
// ALSO... to reassure readers - automating anything requires deep understanding, so they will not miss anything.
26+
// Perhaps this is even more important. When I first read this, I was like "ohhh, I'm gonna miss some fun!"
27+
2028
It's also key to making sure our tests give us true confidence over our deployments.
2129
If we go to the trouble of building a staging server,footnote:[
2230
What I'm calling a "staging" server, some people would
@@ -121,6 +129,7 @@ They're unlikely to ever go away,
121129
and knowing a bit about them will get you some respect
122130
from all the grizzled dinosaurs out there.
123131

132+
// SEBASTIAN: Nice, and seem-to-be timeless choice!
124133

125134

126135
==== Spinning Up a Server
@@ -750,6 +759,11 @@ but I wanted to keep this (already long) chapter as simple as possible.
750759
*******************************************************************************
751760

752761

762+
// SEBASTIAN: I feel the above section would make more sense if it was mentioned waaay earlier.
763+
// I must say I got lost while reading about Chef, Puppet and suddenly I see some Ansible examples
764+
// without any explanation how Ansible works, any diagrams etc.
765+
// I'd also appreciate seeing some example of SSH first as this is a prerequisite to
766+
// using Ansible. Currently, there are too many "open loops" and I think this chapter is hard to follow.
753767

754768
Let's run the latest version of our playbook and see how our tests get on:
755769

@@ -808,6 +822,8 @@ selenium.common.exceptions.WebDriverException: Message: Reached error page:
808822
about:neterror?e=connectionFailure&u=http%3A//staging.ottg.co.uk/[...]
809823
----
810824

825+
// SEBASTIAN: It's awesome that by this moment by using `TEST_SERVER` one is able to run tests against "staging". Just wow!
826+
811827
That `neterror` makes me think it's another networking problem.
812828
Let's try `curl` locally:
813829

@@ -1170,8 +1186,14 @@ which are a fairly typical set of steps for deployment in general
11701186
In more advanced setups, you might be trying to achieve zero-downtime deploys,
11711187
and looking into techniques like red-green deployments.
11721188
1189+
// SEBASTIAN: Is red-green deployment a thing? I must admit it's the first time
1190+
// I see the name and so far I've only know blue-green. I also read there's red-black deployment,
1191+
// but am I looking for this wrong, so I cannot find anything about red-green? 🤔
1192+
11731193
// TODO is there a better word than "switching across"?
11741194
1195+
// SEBASTIAN: How about simply "updating" or "changing"?
1196+
11751197
Every single aspect of deployment can and probably should be automated.
11761198
Here are a couple of general principles to think about
11771199
when implementing infrastructure-as-code:
@@ -1187,5 +1209,6 @@ Declarative::
11871209
rather than _how_ we should get there.
11881210
This goes hand-in-hand with the idea of idempotency above.
11891211
1212+
// SEBASTIAN: Okay, this summary is goldie 👌
11901213
11911214
*******************************************************************************

0 commit comments

Comments
 (0)