add early return to the FT

add a reminder for its removal to the scratchpad, remove note on refactor with broken state

Author: Xronophobe

chapter_13_database_layer_validation.asciidoc

@@ -583,7 +583,39 @@ see that we've got past the first part of the test, and are now onto the second
 check--that submitting a second empty item also shows an error.
 
 ((("", startref="MLVsurfac13")))We've
-got some working code though, so let's have a commit:
+got some working code though, so let's put an early return in the FT to separate
+what we got working from those that still need to be dealt with:
+[role="sourcecode"]
+// TODO fix code listing reference number
+.src/functional_tests/test_list_item_validation.py (ch13l???)
+====
+[source,python]
+----
+class ItemValidationTest(FunctionalTest):
+    def test_cannot_add_empty_list_items(self):
+        [...]
+        self.browser.find_element(By.ID, "id_new_item").send_keys(Keys.ENTER)
+        self.wait_for_row_in_list_table("1: Buy milk")
+
+        return
+        # TODO fix the remaining test scenarios
+
+        # Perversely, she now decides to submit a second blank list item
+        self.browser.find_element(By.ID, "id_new_item").send_keys(Keys.ENTER)
+        [...]
+====
+
+
+We should also remind ourselves not to forget to remove this early return:
+
+
+[role="scratchpad"]
+*****
+* 'Remove hardcoded URLs from views.py'
+* 'Remove the early return from the FT'
+*****
+
+...and it's time to commit our changes:
 
 
 [subs="specialcharacters,quotes"]
@@ -642,6 +674,7 @@ and while we're thinking about it, there's one in 'home.html' too:
 [role="scratchpad"]
 *****
 * 'Remove hardcoded URLs from views.py'
+* 'Remove the early return from the FT'
 * 'Remove hardcoded URL from forms in list.html and home.html'
 *****
 
@@ -798,7 +831,17 @@ OK
 ----
 
 
-Let's try a full FT run:
+Let's try a full FT run: they're all passing! We can remove the early return
+now.
+
+[role="scratchpad"]
+*****
+* 'Remove hardcoded URLs from views.py'
+* '[strikethrough line-through]#Remove the early return from the FT#'
+* 'Remove hardcoded URL from forms in list.html and home.html'
+*****
+
+Run the FTs again to see what's still there that needs to be fixed:
 
 
 [subs="specialcharacters,quotes"]
@@ -822,17 +865,6 @@ We should commit there:
 $ *git commit -am "Refactor list view to handle new item POSTs"*
 ----
 
-NOTE: So did I break the rule about never refactoring against failing tests?
-    In this case, it's allowed, because the refactor is required
-    to get our new functionality to work.
-    You should definitely never refactor against failing _unit_ tests.
-    But in my book it's OK for the FT for the current story you're working on
-    to be failing.footnote:[
-    If you really want a "clean" test run, you could add a skip or an early return
-    to the current FT, but you'd need to make sure you didn't accidentally forget it.]
-
-
-
 
 
 ==== Enforcing Model Validation in view_list
@@ -915,6 +947,7 @@ We'll just add it to our scratchpad for now:
 [role="scratchpad"]
 *****
 * 'Remove hardcoded URLs from views.py'
+* '[strikethrough line-through]#Remove the early return from the FT#'
 * 'Remove hardcoded URL from forms in list.html and home.html'
 * 'Remove duplication of validation logic in views'
 *****
@@ -1029,6 +1062,7 @@ $ *git commit -am "Refactor hard-coded URLs out of templates"*
 [role="scratchpad"]
 *****
 * 'Remove hardcoded URLs from views.py'
+* '[strikethrough line-through]#Remove the early return from the FT#'
 * '[strikethrough line-through]#Remove hardcoded URL from forms in list.html and home.html#'
 * 'Remove duplication of validation logic in views'
 *****
@@ -1162,6 +1196,7 @@ Cross off our to-dos...
 [role="scratchpad"]
 *****
 * '[strikethrough line-through]#Remove hardcoded URLs from views.py#'
+* '[strikethrough line-through]#Remove the early return from the FT#'
 * '[strikethrough line-through]#Remove hardcoded URL from forms in list.html and home.html#'
 * 'Remove duplication of validation logic in views'
 *****