wip on blackifying post and db chapter listings

Author: hjwp

chapter_post_and_database.asciidoc

@@ -70,9 +70,9 @@ Now, running our FTs gives us a slightly cryptic, unexpected error:
 $ pass:quotes[*python functional_tests.py*]
 [...]
 Traceback (most recent call last):
-  File "...python-tdd-book/functional_tests.py", line 41, in
+  File "...python-tdd-book/functional_tests.py", line 38, in
 test_can_start_a_list_and_retrieve_it_later
-    table = self.browser.find_element(By.ID, 'id_list_table')
+    table = self.browser.find_element(By.ID, "id_list_table")
 [...]
 selenium.common.exceptions.NoSuchElementException: Message: Unable to locate
 element: [id="id_list_table"]
@@ -362,10 +362,11 @@ ERROR: test_uses_home_template
 (lists.tests.HomePageTest.test_uses_home_template)
 
 [...]
-  File "...python-tdd-book/lists/views.py", line 5, in home_page
     {"new_item_text": request.POST["item_text"]},
+                      ~~~~~~~~~~~~^^^^^^^^^^^^^
 [...]
 django.utils.datastructures.MultiValueDictKeyError: 'item_text'
+
 ----
 
 
@@ -391,7 +392,7 @@ site manually, and we can get on with fixing it straight away.  Here's how:
 
 
 [role="sourcecode"]
-.lists/views.py
+.lists/views.py (ch05l010)
 ====
 [source,python]
 ----
@@ -436,7 +437,7 @@ improved error messages stay around to help debug any future errors:
 ----
 self.assertTrue(
     any(row.text == "1: Buy peacock feathers" for row in rows),
-    f"New to-do item did not appear in table. Contents were:\n{table.text}"  #<1>
+    f"New to-do item did not appear in table. Contents were:\n{table.text}",  #<1>
 )
 ----
 ====
@@ -541,13 +542,12 @@ check for adding a second item to the table (copy and paste is our friend), we
 begin to see that our first cut solution really isn't going to, um, cut it:
 
 [role="sourcecode"]
-.functional_tests.py
+.functional_tests.py (ch05l014)
 ====
 [source,python]
 ----
-def thing():
-    # There is still a text box inviting her to add another item. She
-    # enters "Use peacock feathers to make a fly"
+    # There is still a text box inviting her to add another item.
+    # She enters "Use peacock feathers to make a fly"
     # (Edith is very methodical)
     inputbox = self.browser.find_element(By.ID, "id_new_item")
     inputbox.send_keys("Use peacock feathers to make a fly")
@@ -623,20 +623,18 @@ only methods that begin with `test_` will get run as tests, so you can use
 other methods for your own purposes:
 
 [role="sourcecode"]
-.functional_tests.py
+.functional_tests.py (ch05l015)
 ====
 [source,python]
 ----
     def tearDown(self):
         self.browser.quit()
 
-
     def check_for_row_in_list_table(self, row_text):
-        table = self.browser.find_element(By.ID, 'id_list_table')
-        rows = table.find_elements(By.TAG_NAME, 'tr')
+        table = self.browser.find_element(By.ID, "id_list_table")
+        rows = table.find_elements(By.TAG_NAME, "tr")
         self.assertIn(row_text, [row.text for row in rows])
 
-
     def test_can_start_a_list_and_retrieve_it_later(self):
         [...]
 ----
@@ -646,27 +644,27 @@ I like to put helper methods near the top of the class, between the `tearDown`
 and the first test. Let's use it in the FT:
 
 [role="sourcecode"]
-.functional_tests.py
+.functional_tests.py (ch05l016)
 ====
 [source,python]
 ----
     # When she hits enter, the page updates, and now the page lists
     # "1: Buy peacock feathers" as an item in a to-do list table
     inputbox.send_keys(Keys.ENTER)
     time.sleep(1)
-    self.check_for_row_in_list_table('1: Buy peacock feathers')
+    self.check_for_row_in_list_table("1: Buy peacock feathers")
 
-    # There is still a text box inviting her to add another item. She
-    # enters "Use peacock feathers to make a fly" (Edith is very
-    # methodical)
-    inputbox = self.browser.find_element(By.ID, 'id_new_item')
-    inputbox.send_keys('Use peacock feathers to make a fly')
+    # There is still a text box inviting her to add another item.
+    # She enters "Use peacock feathers to make a fly"
+    # (Edith is very methodical)
+    inputbox = self.browser.find_element(By.ID, "id_new_item")
+    inputbox.send_keys("Use peacock feathers to make a fly")
     inputbox.send_keys(Keys.ENTER)
     time.sleep(1)
 
     # The page updates again, and now shows both items on her list
-    self.check_for_row_in_list_table('1: Buy peacock feathers')
-    self.check_for_row_in_list_table('2: Use peacock feathers to make a fly')
+    self.check_for_row_in_list_table("1: Buy peacock feathers")
+    self.check_for_row_in_list_table("2: Use peacock feathers to make a fly")
 
     # Edith wonders whether the site will remember her list. Then she sees
     [...]
@@ -713,31 +711,30 @@ how we want it to work.
 Let's create a new class in 'lists/tests.py':
 
 [role="sourcecode"]
-.lists/tests.py
+.lists/tests.py (ch05l017)
 ====
 [source,python]
 ----
 from lists.models import Item
 [...]
 
 class ItemModelTest(TestCase):
-
     def test_saving_and_retrieving_items(self):
         first_item = Item()
-        first_item.text = 'The first (ever) list item'
+        first_item.text = "The first (ever) list item"
         first_item.save()
 
         second_item = Item()
-        second_item.text = 'Item the second'
+        second_item.text = "Item the second"
         second_item.save()
 
         saved_items = Item.objects.all()
         self.assertEqual(saved_items.count(), 2)
 
         first_saved_item = saved_items[0]
         second_saved_item = saved_items[1]
-        self.assertEqual(first_saved_item.text, 'The first (ever) list item')
-        self.assertEqual(second_saved_item.text, 'Item the second')
+        self.assertEqual(first_saved_item.text, "The first (ever) list item")
+        self.assertEqual(second_saved_item.text, "Item the second")
 ----
 ====
 
@@ -803,6 +800,7 @@ creating a class:
 ----
 from django.db import models
 
+
 class Item(object):
     pass
 ----
@@ -829,6 +827,7 @@ model, we make it inherit from the `Model` class:
 ----
 from django.db import models
 
+
 class Item(models.Model):
     pass
 ----
@@ -967,7 +966,7 @@ self-explanatory:
 [source,python]
 ----
 class Item(models.Model):
-    text = models.TextField(default='')
+    text = models.TextField(default="")
 ----
 ====
 
@@ -1033,14 +1032,14 @@ response. We can do that by adding three new lines to the existing test called
 [source,python]
 ----
 def test_can_save_a_POST_request(self):
-    response = self.client.post('/', data={'item_text': 'A new list item'})
+    response = self.client.post("/", data={"item_text": "A new list item"})
 
-    self.assertEqual(Item.objects.count(), 1)  #<1>
-    new_item = Item.objects.first()  #<2>
-    self.assertEqual(new_item.text, 'A new list item')  #<3>
+    self.assertEqual(Item.objects.count(), 1)  # <1>
+    new_item = Item.objects.first()  # <2>
+    self.assertEqual(new_item.text, "A new list item")  # <3>
 
-    self.assertIn('A new list item', response.content.decode())
-    self.assertTemplateUsed(response, 'home.html')
+    self.assertIn("A new list item", response.content.decode())
+    self.assertTemplateUsed(response, "home.html")
 ----
 ====
 
@@ -1083,14 +1082,17 @@ Let's adjust our view:
 from django.shortcuts import render
 from lists.models import Item
 
+
 def home_page(request):
     item = Item()
-    item.text = request.POST.get('item_text', '')
+    item.text = request.POST.get("item_text", "")
     item.save()
 
-    return render(request, 'home.html', {
-        'new_item_text': request.POST.get('item_text', ''),
-    })
+    return render(
+        request,
+        "home.html",
+        {"new_item_text": request.POST.get("item_text", "")},
+    )
 ----
 ====
 
@@ -1115,9 +1117,14 @@ refactoring:
 ====
 [source,python]
 ----
-    return render(request, 'home.html', {
-        'new_item_text': item.text
-    })
+    [...]
+    item.save()
+
+    return render(
+        request,
+        "home.html",
+        {"new_item_text": item.text},
+    )
 ----
 ====
 
@@ -1137,7 +1144,7 @@ test, but it's best to keep unit tests to testing one thing at a time, so let's
 add a new one:
 
 [role="sourcecode"]
-.lists/tests.py
+.lists/tests.py (ch05l022)
 ====
 [source,python]
 ----
@@ -1155,20 +1162,22 @@ quite a small change to the logic of the view, there are quite a few little
 tweaks to the implementation in code:
 
 [role="sourcecode"]
-.lists/views.py
+.lists/views.py (ch05l023)
 ====
 [source,python]
 ----
 def home_page(request):
-    if request.method == 'POST':
-        new_item_text = request.POST['item_text']  #<1>
-        Item.objects.create(text=new_item_text)  #<2>
+    if request.method == "POST":
+        new_item_text = request.POST["item_text"]  # <1>
+        Item.objects.create(text=new_item_text)  # <2>
     else:
-        new_item_text = ''  #<1>
+        new_item_text = ""  # <1>
 
-    return render(request, 'home.html', {
-        'new_item_text': new_item_text,  #<1>
-    })
+    return render(
+        request,
+        "home.html",
+        {"new_item_text": new_item_text},  # <1>
+    )
 ----
 ====
 
@@ -1239,12 +1248,13 @@ substantially:
 from django.shortcuts import redirect, render
 from lists.models import Item
 
+
 def home_page(request):
-    if request.method == 'POST':
-        Item.objects.create(text=request.POST['item_text'])
-        return redirect('/')
+    if request.method == "POST":
+        Item.objects.create(text=request.POST["item_text"])
+        return redirect("/")
 
-    return render(request, 'home.html')
+    return render(request, "home.html")
 ----
 ====
 

source/chapter_post_and_database/superlists

@@ -224,9 +224,7 @@ def check_listing_matches_commit(listing, commit, future_contents):
         if new_line.strip() not in stripped_listing_lines:
             # print('stripped_listing_lines', stripped_listing_lines)
             raise ApplyCommitException(
-                'could not find commit new line {0} in listing:\n{1}'.format(
-                    new_line, listing.contents
-                )
+                f"could not find commit new line {new_line!r} in listing:\n{listing.contents}"
             )
 
     future_lines = future_contents.split('\n')