Skip to content

Commit 132a9d1

Browse files
authored
Rita edits ch 10
1 parent b1a2836 commit 132a9d1

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

chapter_10_production_readiness.asciidoc

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[[chapter_10_production_readiness]]
2-
== Making our App Production-Ready
2+
== Making Our App Production-Ready
33

44
Our container is working fine but it's not production-ready.
55
Let's try to get it there, using the tests to keep us safe.
@@ -21,7 +21,7 @@ This chapter is still very fresh,
2121
but the content is all there,
2222
so you should be able to follow along.
2323
24-
But as always I really, really need fedback.
24+
But as always I really, really need feedback.
2525
So please hit me up at [email protected], or via
2626
https://github.com/hjwp/Book-TDD-Web-Dev-Python/issues[GitHub Issues]
2727
and Pull Requests.
@@ -58,6 +58,7 @@ an ORM, all sorts of middleware, the admin site...
5858
"What else do you want, a pony?" Well, Gunicorn stands for "Green Unicorn",
5959
which I guess is what you'd want next if you already had a pony...
6060

61+
//RITA: Was cmdg intentional?
6162
//001
6263
cmdg
6364

@@ -182,7 +183,7 @@ Ran 3 tests in 10.718s
182183
OK
183184
----
184185

185-
Phew. Let's commit that
186+
Phew. Let's commit that:
186187

187188
[subs="specialcharacters,quotes"]
188189
----
@@ -218,12 +219,13 @@ See http://www.clearlytech.com/2014/01/04/12-factor-apps-plain-english/[
218219
Another common way of handling this
219220
is to have different versions of _settings.py_ for dev and prod.
220221
That can work fine too, but it can get confusing to manage.
221-
Environment variables also have the advantage of working for non-Django stuff too...
222+
Environment variables also have the advantage of working for non-Django stuff too.
222223
]
223224

224225

225226
==== Setting DEBUG=True and SECRET_KEY
226227

228+
//RITA: What do you mean by "this"? Please add a word or two for context.
227229
There's lots of ways you might do this.
228230
Here's what I propose; it may seem a little fiddly,
229231
but I'll provide a little justification for each choice.
@@ -301,7 +303,7 @@ $ pass:specialcharacters,quotes[*docker build -t superlists . && docker run \
301303
KeyError: 'DJANGO_SECRET_KEY'
302304
----
303305

304-
Ooops, and I forgot to set said secret key env var,
306+
Oops. I forgot to set said secret key env var,
305307
mere seconds after having dreamt it up!
306308

307309

@@ -335,7 +337,7 @@ AssertionError: 'To-Do' not found in 'Bad Request (400)'
335337

336338
==== ALLOWED_HOSTS is Required When Debug Mode is Turned Off
337339

338-
Not quite! Let's take a look manually: <<django-400-error>>.
340+
It's not quite working yet! Let's take a look manually: <<django-400-error>>.
339341

340342
[[django-400-error]]
341343
.An ugly 400 error
@@ -393,7 +395,7 @@ else:
393395
====
394396

395397
This is a setting that we want to change,
396-
depending on whether our docker image is running locally,
398+
depending on whether our Docker image is running locally,
397399
or on a server, so we'll use the `-e` flag again:
398400

399401

@@ -410,7 +412,7 @@ $ *docker build -t superlists . && \
410412
==== Collectstatic is Required when Debug is Turned Off
411413

412414
An FT run (or just looking at the site) reveals that we've had a regression
413-
in our static files.
415+
in our static files:
414416

415417
[role="small-code"]
416418
[subs="specialcharacters,macros"]
@@ -456,7 +458,7 @@ OK
456458

457459
We have a container that we're ready to ship to production!
458460

459-
Find out how in the next exciting installment...
461+
Find out how in the next exciting chapter installment...
460462

461463

462464

0 commit comments

Comments
 (0)