Skip to content

Commit 24dbc85

Browse files
authored
Merge pull request #233 from zipperer/main
chapters 8 and 9: propose a few small edits
2 parents 114f32f + cbc434e commit 24dbc85

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

chapter_08_prettification.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Here are a few things we might want:
8888
// including Django documentation or learnpython.org
8989
// Both look completely different today - not so ugly anymore
9090

91-
* A nice large input field for adding new and existing lists
91+
* A nice large input field for adding to new and existing lists
9292
* A large, attention-grabbing, centered box to put it in
9393

9494
((("aesthetics, testing", seealso="design and layout testing")))

chapter_09_docker.asciidoc

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ and this is a very new draft.
6161
What that means is that I'd, really, really love feedback from readers.
6262
Please have a go at following along and let me know what you think!
6363
I'm [email protected], or you can open up
64-
https://github.com/hjwp/Book-TDD-Web-Dev-Python/issues[GitHub Issue]
64+
https://github.com/hjwp/Book-TDD-Web-Dev-Python/issues[GitHub Issues]
6565
or Pull Requests.
6666
6767
Let me know how you got on, if you get stuck on anything,
@@ -861,6 +861,7 @@ The docker daemon lets you list all the currently running containers
861861
with `docker ps`:
862862
863863
[role="skipme small-code"]
864+
[subs="quotes"]
864865
----
865866
$ *docker ps*
866867
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
@@ -873,8 +874,9 @@ and a randomly-generated name (you can override that if you want to).
873874
We can use the ID or the name to kill the container with `docker kill`:
874875
875876
[role="skipme"]
877+
[subs="quotes"]
876878
----
877-
$ docker kill 0818e1b8e9bf
879+
$ *docker kill 0818e1b8e9bf*
878880
0818e1b8e9bf
879881
----
880882
@@ -904,7 +906,7 @@ What's going on here? Time for a little debugging.
904906

905907

906908

907-
=== Debugging a Container Networking Problems
909+
=== Debugging Container Networking Problems
908910

909911
First, let's try and take a look ourselves, in our browser, by going to http://localhost:8888/:
910912

@@ -955,7 +957,7 @@ Starting development server at http://127.0.0.1:8888/
955957

956958
A quick run of the FT or check in our browser will show us that nope, that doesn't work either.
957959
Let's try an even lower-level smoke test, the traditional Unix utility `curl`.
958-
It's a command-line tool for making HTTP requests. Try it on your own computer first:
960+
It's a command-line tool for making HTTP requests.footnote:[`curl` can make many other types of requests. For details see https://man7.org/linux/man-pages/man1/curl.1.html[curl manual].] Try it on your own computer first:
959961

960962
[role="ignore-errors"]
961963
[subs="specialcharacters,macros"]
@@ -1484,7 +1486,7 @@ Tests and small steps take some of the uncertainty out of deployment::
14841486
14851487
Some typical pain points--networking, ports, static files, and the database::
14861488
Moving from the local django development server to a container
1487-
is chance to rehearse the fiddliness of configuring networking
1489+
is a chance to rehearse the fiddliness of configuring networking
14881490
in a deployed environment.
14891491
It's also a chance to think about persistence and the database,
14901492
and some configuration issues like static files.

0 commit comments

Comments
 (0)