Skip to content

Commit 485d967

Browse files
committed
improve commits in the chapter
1 parent b553a1e commit 485d967

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

chapter_15_advanced_forms.asciidoc

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -382,11 +382,15 @@ now it's time to commit our model-layer changes:
382382
[subs="specialcharacters,macros"]
383383
----
384384
$ pass:[<strong>git status</strong>] # should show changes to tests + models and new migration
385-
# let's give our new migration a better name
386-
$ pass:[<strong>git add lists</strong>]
385+
$ pass:[<strong>git add src/lists</strong>]
387386
$ pass:[<strong>git diff --staged</strong>]
388-
$ pass:[<strong>git commit -am "Implement duplicate item validation at model layer"</strong>]
387+
$ pass:[<strong>git commit -m "Implement duplicate item validation at model layer"</strong>]
389388
----
389+
// CSANAD we manually added src/lists I'm guessing, not to commit the currently
390+
// failing FT. Or, we could commit the FT too, but in that case adding src/lists
391+
// is unnecessary because we would be doing `commit -a` anyway. I removed the
392+
// comment to name the migration because it's descriptive enough now:
393+
// 0005_alter_item_unique_together.
390394

391395

392396
=== Experimenting with Duplicate Item Validation at the Views Layer
@@ -594,8 +598,10 @@ And we're there! A quick commit:
594598
[subs="specialcharacters,quotes"]
595599
----
596600
$ *git diff*
597-
$ *git commit -a*
601+
$ *git add src/lists/forms.py src/lists/tests/test_forms.py*
602+
$ *git commit -m "implement ExistingListItemForm, add DUPLICATE_ITEM_ERROR message"*
598603
----
604+
// CSANAD I think it's better to keep the commit neat.
599605

600606

601607
=== Using the Existing List Item Form in the List View

0 commit comments

Comments
 (0)