start addressing some issues in 10, incl some of those in #281

Author: hjwp

chapter_10_production_readiness.asciidoc

@@ -126,13 +126,13 @@ Let's change the command our image runs:
 [source,dockerfile]
 ----
 [...]
-RUN pip install "django<5" gunicorn  <1>
+RUN pip install "django<5" gunicorn  # <1>
 
 COPY src /src
 
 WORKDIR /src
 
-CMD gunicorn --bind :8888 superlists.wsgi:application  <2>
+CMD gunicorn --bind :8888 superlists.wsgi:application  # <2>
 ----
 ====
 // CSANAD:  shouldn't we try it out before adding this to the Dockerfile?
@@ -230,9 +230,6 @@ MIDDLEWARE = [
 // CSANAD:  I would add a few thoughts on the significance of the order of
 //          middlewares.
 
-And if you take another manual look at your site after rebuilding the
-container, things should look much healthier.
-
 And then we need to add it to our pip installs in the Dockerfile:
 
 .Dockerfile (ch10l003)
@@ -374,11 +371,8 @@ whitenoise==6.6.0
 
 That's a good first cut, let's commit it:
 
-// SEBASTIAN I am not very fond of freezing just "top-level" dependencies of the project,
-// . This is not guaranteeing the reproducible builds and I failed to build & deploy because of that more than once.
-// But I understand it's a trade-off so the reader does get bogged down.
-// TODO: add a note about this and a link to some more reading
 
+[subs="specialcharacters,quotes"]
 ----
 $ *git add requirements.txt*
 $ *git commit -m "Add a requirements.txt with Django, gunicorn and whitenoise"*
@@ -420,14 +414,14 @@ FROM python:slim
 RUN python -m venv /venv
 ENV PATH="/venv/bin:$PATH"
 
-COPY requirements.txt requirements.txt  <1>
-RUN pip install -r requirements.txt  <2>
+COPY requirements.txt requirements.txt  # <1>
+RUN pip install -r requirements.txt  # <2>
 
 COPY src /src
 
 WORKDIR /src
 
-CMD python manage.py runserver
+CMD gunicorn --bind :8888 superlists.wsgi:application
 ----
 ====
 
@@ -451,6 +445,7 @@ TIP: Forgetting the `-r` and running `pip install requirements.txt`
 // and then setting the user in the Dockerfile with `USER todoapp`.
 // But we can cover this in a later chapter (the next one looks like a good fit,
 // since it's related to the app being production ready).
+// TODO yep let's definitely do this.
 
 Let's do a build & run & test to check everything still works:
 
@@ -552,6 +547,7 @@ TIP: Better to fail hard than allow a typo in an environment variable name to
 // in a development environment relying on containerization, programmers usually
 // mount the whole /src minimizing the time-consuming rebuilding of their images.
 
+
 ==== Setting environment variables inside the Dockerfile
 
 Now let's set that environment variable in our Dockerfile using the `ENV` directive: